Re: FTP Extensions for Cryptographic Hashes (draft-bryan-ftp-hash)

Daniel Stenberg <daniel@haxx.se> Wed, 24 March 2010 21:59 UTC

Return-Path: <daniel@haxx.se>
X-Original-To: apps-discuss@core3.amsl.com
Delivered-To: apps-discuss@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 8DC4B3A6C7B for <apps-discuss@core3.amsl.com>; Wed, 24 Mar 2010 14:59:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.74
X-Spam-Level:
X-Spam-Status: No, score=0.74 tagged_above=-999 required=5 tests=[BAYES_20=-0.74, DNS_FROM_OPENWHOIS=1.13, HELO_EQ_SE=0.35]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YPJwc54Af85x for <apps-discuss@core3.amsl.com>; Wed, 24 Mar 2010 14:59:47 -0700 (PDT)
Received: from giant.haxx.se (giant.haxx.se [83.168.254.42]) by core3.amsl.com (Postfix) with ESMTP id 5615D3A6C2C for <apps-discuss@ietf.org>; Wed, 24 Mar 2010 14:59:47 -0700 (PDT)
Received: from giant.haxx.se (giant.haxx.se [83.168.254.42]) by giant.haxx.se (8.14.3/8.14.3/Debian-9) with ESMTP id o2OLxpLX014343; Wed, 24 Mar 2010 22:59:51 +0100
Date: Wed, 24 Mar 2010 22:59:51 +0100 (CET)
From: Daniel Stenberg <daniel@haxx.se>
X-X-Sender: dast@giant.haxx.se
To: Anthony Bryan <anthonybryan@gmail.com>
Subject: Re: FTP Extensions for Cryptographic Hashes (draft-bryan-ftp-hash)
In-Reply-To: <bb9e09ee1003241430g5c863bdbvb3320e2f40b0f686@mail.gmail.com>
Message-ID: <alpine.DEB.2.00.1003242249490.28656@tvnag.unkk.fr>
References: <bb9e09ee1003241430g5c863bdbvb3320e2f40b0f686@mail.gmail.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
X-fromdanielhimself: yes
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Tim Kosse <tim.kosse@filezilla-project.org>, =?ISO-8859-15?Q?Alfred_H=CEnes?= <ah@tr-sys.de>, john+ietf@jck.com, apps-discuss@ietf.org
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2010 21:59:48 -0000

On Wed, 24 Mar 2010, Anthony Bryan wrote:

> This ID proposes a feature where FTP clients can request the hash of a file. 
> A number of FTP clients and servers have implemented multiple commands 
> (XMD5, XSHA1, SITE SHOHASH, etc) that are not formally specified, leading to 
> non-interoperability and confusion.

Nice draft!

Here's one remark:

You use 550 as response code when the user isn't allowed to use the HASH 
command, but I find that 550 is otherwise often used for file-not-found in 
both SIZE, RETR and other responses.

Wouldn't it make sense to have a "file not found" response for when you try to 
HASH a non-existing file? Wouldn't it make sense to re-use the same error code 
(550) for that as other command use?

Maybe the "HASH not allowed" case can use 552 or 553?

-- 

  / daniel.haxx.se