Re: [aqm] Alia Atlas' No Objection on draft-ietf-aqm-fq-codel-05: (with COMMENT)

Dave Taht <dave.taht@gmail.com> Thu, 17 March 2016 20:41 UTC

Return-Path: <dave.taht@gmail.com>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5253012DAD5; Thu, 17 Mar 2016 13:41:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SQFpPEGd27Yj; Thu, 17 Mar 2016 13:41:36 -0700 (PDT)
Received: from mail-ob0-x22b.google.com (mail-ob0-x22b.google.com [IPv6:2607:f8b0:4003:c01::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21DAF12DAF3; Thu, 17 Mar 2016 13:41:35 -0700 (PDT)
Received: by mail-ob0-x22b.google.com with SMTP id fz5so97179271obc.0; Thu, 17 Mar 2016 13:41:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=Fo/eJisA9k+Bxl4W0sG7TPSTMOy3+BKSMslq7b2NjY4=; b=KqHRqbtEj0rNacslaPVMLtrZ3Uw45lknZMHNwe/YaMjoh31gGSp8fsZJUgiqtPC3/F J7xODkbyLx8EPs5vY2cqng2jIRWJKgb1ye4qcRpfq+z/7qUS6T2Wsyt8XAIMX33Ija9x dNVSQpV6CB/y2rYKeQaGFe8I0/EKX37sdap+gkEy1olG+GcNtB5UY0cTRJUTEC90OKTR fdgn9fgwa1lUmVOsw3XLq/2tGH38rn82daqb7vtg+2NtjpqP4nlFRqf9/Pf7u1/w2xxv RpV4CjONUpXKiDTOzhH6JkaFH/6C6ZRjwNuprcYTxityPBGhktZrZqagdMqAeBQTAxf2 S2Mg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=Fo/eJisA9k+Bxl4W0sG7TPSTMOy3+BKSMslq7b2NjY4=; b=CxG/dw6sM6VZ0or7d8xabrhhei9ej0f7Zb/lodlPFhr2nG/v4+o2IdLqpvhT3hrVJD f+pxIFxS04I8wy0e4GKPRJ57AxqWb+KjLSA8z7A1KZPeCMrVsk6gJeQHMkC6PW/1yqCe wi0I1JdvG+LEc87CdOM990NBZNiWbfWaVhaElv+8hCbU2PJA50ZwJAKW+gev0U6cbzoP BvP3811QGD2KXIS1lPMOC/VpRSvUJStmuS/YbSV1Ve5uBdVtD3+bWefYj+AazxwEolJn o0hl/9xD0h41Gi/TQd2wuyTEsLUAAnc8cilfG71SxbSoWKMAaEzJr0emF54xjmBXewZe OySg==
X-Gm-Message-State: AD7BkJLh2xDnctyP2Go+rT+9WnYD+IOak8f0hXM/XGK6JjLRmSNEeWs+j5+vl1VsmkrgtJObha24O1IvkJ6Ugg==
MIME-Version: 1.0
X-Received: by 10.182.58.81 with SMTP id o17mr7413310obq.25.1458247294410; Thu, 17 Mar 2016 13:41:34 -0700 (PDT)
Received: by 10.202.79.88 with HTTP; Thu, 17 Mar 2016 13:41:34 -0700 (PDT)
In-Reply-To: <87vb4lxc18.fsf@alrua-desktop.borgediget.toke.dk>
References: <20160317135919.14287.86691.idtracker@ietfa.amsl.com> <87vb4lxc18.fsf@alrua-desktop.borgediget.toke.dk>
Date: Thu, 17 Mar 2016 13:41:34 -0700
Message-ID: <CAA93jw5sDAGWCXNgaucGjmEG638mzGb7fKCwbonHVdaqOa1H=Q@mail.gmail.com>
From: Dave Taht <dave.taht@gmail.com>
To: Toke Høiland-Jørgensen <toke@toke.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/aqm/KcWipekvKL0dLppGNj1cZ-qyIqg>
Cc: draft-ietf-aqm-fq-codel@ietf.org, Wesley Eddy <wes@mti-systems.com>, aqm-chairs@ietf.org, Alia Atlas <akatlas@gmail.com>, The IESG <iesg@ietf.org>, "aqm@ietf.org" <aqm@ietf.org>
Subject: Re: [aqm] Alia Atlas' No Objection on draft-ietf-aqm-fq-codel-05: (with COMMENT)
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Mar 2016 20:41:39 -0000

On Thu, Mar 17, 2016 at 10:13 AM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> "Alia Atlas" <akatlas@gmail.com> writes:
>
>> ----------------------------------------------------------------------
>> COMMENT:
>> ----------------------------------------------------------------------
>>
>> I think it would be useful to have a reference to the Linux
>> implementation ("current" version and pointer).
>
> Hi Alia
>
> I've added a reference pointing to the fq_codel code in Linux git tree
> to the latest updated version, available here:
> https://kau.toke.dk/ietf/draft-ietf-aqm-fq-codel-06.html (or .txt).


I'm not huge on calling this reference [LINUX]. [LINUXSRC]? [SRC]?

I also felt compelled, after this round of cite-adding, to add a few
more cites, (what will be) rfc7806, BQL, HTB, and HFSC, with a brief
section explaining why they are needed also. BQL was the under
appreciated breakthrough that made scaling past a gbit possible, and
would (if implemented) make dsl and cable modems a lot better,
at their (much slower) speeds.

https://github.com/dtaht/bufferbloat-rfcs/commit/7d500133008857b7b78000abac9d592e66477ffb

adding:

## Device queues must also be well controlled

It is best that these AQM and FQ algorithms run as close to the hardware
as possible. Scheduling such complexity at interrupt time is difficult, so
a small standing queue between the algorithm and the wire is often needed
at higher transmit rates.

In Linux, this is accomplished via "Byte Queue Limits" {{BQL}} in the
device driver ring buffer (for physical line rates), and via a software
rate limiter such as {HTB}}, {{HFSC}}, or {{CAKE}} otherwise.

Other issues with concatenated queues are described in {{CODEL}}.

...

There has been such an accumulation of small changes in response to
this wonderful review process that I fear that going through another
"last, last" call will be needed.

> -Toke