Re: [aqm] I-D Action: draft-ietf-aqm-codel-03.txt

Wesley Eddy <wes@mti-systems.com> Tue, 22 March 2016 20:43 UTC

Return-Path: <wes@mti-systems.com>
X-Original-To: aqm@ietfa.amsl.com
Delivered-To: aqm@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 673F412D9B2 for <aqm@ietfa.amsl.com>; Tue, 22 Mar 2016 13:43:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.107
X-Spam-Level:
X-Spam-Status: No, score=-1.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RDNS_NONE=0.793] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dAqLgRggMlJd for <aqm@ietfa.amsl.com>; Tue, 22 Mar 2016 13:43:03 -0700 (PDT)
Received: from atl4mhob21.registeredsite.com (unknown [209.17.115.115]) by ietfa.amsl.com (Postfix) with ESMTP id B884212D9AB for <aqm@ietf.org>; Tue, 22 Mar 2016 13:43:02 -0700 (PDT)
Received: from mailpod.hostingplatform.com ([10.30.71.208]) by atl4mhob21.registeredsite.com (8.14.4/8.14.4) with ESMTP id u2MKgp2e092668 for <aqm@ietf.org>; Tue, 22 Mar 2016 16:42:51 -0400
Received: (qmail 3191 invoked by uid 0); 22 Mar 2016 20:42:51 -0000
X-TCPREMOTEIP: 65.189.201.79
X-Authenticated-UID: wes@mti-systems.com
Received: from unknown (HELO ?192.168.1.104?) (wes@mti-systems.com@65.189.201.79) by 0 with ESMTPA; 22 Mar 2016 20:42:51 -0000
To: Polina Goltsman <polina.goltsman@student.kit.edu>, aqm@ietf.org
References: <20160316000053.5163.88345.idtracker@ietfa.amsl.com> <56EEC35B.3000007@mti-systems.com> <56F0635A.7060004@student.kit.edu>
From: Wesley Eddy <wes@mti-systems.com>
Message-ID: <56F1AE49.3020107@mti-systems.com>
Date: Tue, 22 Mar 2016 16:42:49 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <56F0635A.7060004@student.kit.edu>
Content-Type: multipart/alternative; boundary="------------020008000202050507040605"
Archived-At: <http://mailarchive.ietf.org/arch/msg/aqm/PChDYFL88yipYM-9IIYz3UY0cIU>
Subject: Re: [aqm] I-D Action: draft-ietf-aqm-codel-03.txt
X-BeenThere: aqm@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Discussion list for active queue management and flow isolation." <aqm.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/aqm>, <mailto:aqm-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/aqm/>
List-Post: <mailto:aqm@ietf.org>
List-Help: <mailto:aqm-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/aqm>, <mailto:aqm-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Mar 2016 20:43:04 -0000

On 3/21/2016 5:10 PM, Polina Goltsman wrote:
>
> First of all our feedback regarding different "re-entering dropping 
> state" in the document and in the Linux implementation 
> (http://www.ietf.org/mail-archive/web/aqm/current/msg01686.html) was 
> not addressed.
>


Thank you for double-checking; the editors should look into this and 
respond.


> As FQ-CoDel  relies on CoDel, this issue is also (partly) relevant for 
> the FQ-CoDel document. In the introduction FQ-CoDel references ns-3 
> and Linux implementations where the first one uses the re-entering 
> logic from the CoDel document while the second from CoDel Linux 
> implementation. The algorithm that has seen widespread testing 
> according to Section 7 is (I suppose) the Linux version. Is this 
> situation acceptable for an algorithm specification?


This is a good question.  I believe for "Experimental", it's acceptable, 
but greater clarity would obviously be good.


> /[since this comment was supposed to be sent before the end of 2015, 
> feel free to (silently) ignore it]/

Since there are still some things that need to be tweaked in the 
document, there is still time to make constructive comments, so thanks 
for providing them!// I'd like the editors to examine them and respond./


/
>
> Second, unlike Rasool Al-Saadi (see 
> http://www.ietf.org/mail-archive/web/aqm/current/msg01693.html) I do 
> not like the document. Although I agree that the pseudocode is 
> sufficient to create a working implementation, however, in my opinion, 
> the rest of the document makes implementing CoDeL more confusing (at 
> least without reading [CODEL2012] first). Is it normal for a RFC, 
> which, as I assume, should primarily contain an algorithm 
> specification to contain the algorithm specification ONLY in form of 
> pseudocode?


To be clear, the RFC doesn't need to completely "stand alone" (there is 
an Informative References section for good reason), however, it should 
certainly be internally clear.    I definitely think the editors should 
consider and respond to your specific comments that were below this, as 
they seem like they might help improve clarity.

Thanks for your feedback!