Re: [art] Artart last call review of draft-ietf-alto-cost-mode-02

mohamed.boucadair@orange.com Thu, 12 May 2022 12:32 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: art@ietfa.amsl.com
Delivered-To: art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 30674C157B56; Thu, 12 May 2022 05:32:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z11bmc_aCv3q; Thu, 12 May 2022 05:32:06 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F2EEDC157B58; Thu, 12 May 2022 05:32:05 -0700 (PDT)
Received: from opfedar03.francetelecom.fr (unknown [xx.xx.xx.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfedar21.francetelecom.fr (ESMTP service) with ESMTPS id 4KzWPJ43lxz7w09; Thu, 12 May 2022 14:32:04 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1652358724; bh=iVow6ANjrDffk+DeIMUwF7P2om8a3GrUaI2dYWY1JI0=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=soXBAQn64I7vqChaDLqgXf5UX3OYYjkWcvvistvrlw45zwGnuoBZFIkFpAuM8uPtl Mlo4SvMj78GOLu/MmRkeli+km2aHAi/u4RWyXwcpVm5l3SSId1o3+DaZJLQorRioCZ 4WnFmVm/rjXtemA/LAfvktInsp1NIlfOXt64JqBkt54ymHTiDqwNHiDhfuhwChjes+ sRjDZmJYGEn/RUPa6zkf3vWofjcILVwRuOMege+6oNqFmla/I8u6UA1h3ZDYa7zRK5 uBRDgrwi1Yyb7XPw2m6t632lIyCO6M6EvzsCq07ABpaa4RM58W6zocqJz3Nw0YRwoM CMfuIcjnXbohQ==
From: mohamed.boucadair@orange.com
To: Jaime Jimenez <jaime@iki.fi>, "art@ietf.org" <art@ietf.org>
CC: "alto@ietf.org" <alto@ietf.org>, "draft-ietf-alto-cost-mode.all@ietf.org" <draft-ietf-alto-cost-mode.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Artart last call review of draft-ietf-alto-cost-mode-02
Thread-Index: AQHYZQ1EbU+9vBszPk208aH7Hr4hn60bK4pA
Content-Class:
Date: Thu, 12 May 2022 12:32:03 +0000
Message-ID: <11947_1652358724_627CFE44_11947_172_1_cab6507cd7e44b09b08b2abac2c6c698@orange.com>
References: <165225606200.27597.12526979685881022006@ietfa.amsl.com>
In-Reply-To: <165225606200.27597.12526979685881022006@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Enabled=true; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SetDate=2022-05-12T12:22:03Z; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Method=Privileged; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_Name=unrestricted_parent.2; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_SiteId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ActionId=21088d46-4a00-45d2-873b-81f0f3393b59; MSIP_Label_07222825-62ea-40f3-96b5-5375c07996e2_ContentBits=0
x-originating-ip: [10.115.26.52]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/art/24MtIXSOuIE69cFmeVKEpGWrawU>
Subject: Re: [art] Artart last call review of draft-ietf-alto-cost-mode-02
X-BeenThere: art@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Applications and Real-Time Area Discussion <art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/art>, <mailto:art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/art/>
List-Post: <mailto:art@ietf.org>
List-Help: <mailto:art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/art>, <mailto:art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2022 12:32:10 -0000

Hi Jaime, 

Thank you for the careful review. 

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Jaime Jimenez via Datatracker <noreply@ietf.org>
> Envoyé : mercredi 11 mai 2022 10:01
> À : art@ietf.org
> Cc : alto@ietf.org; draft-ietf-alto-cost-mode.all@ietf.org; last-
> call@ietf.org
> Objet : Artart last call review of draft-ietf-alto-cost-mode-02
> 
> Reviewer: Jaime Jimenez
> Review result: Ready with Nits
> 
> Dear all,
> 
> I am the assigned reviewer for the Applications and Real Time Area
> Review Team (ART-ART).
> 
> Nits/editorial comments:
> 
> One minor comment is that since this document sets a registry with
> a limited set of cost-modes (for now "numerical" and "ordinal")
> that require IANA registration anyways, why not assign some 8-bit
> codes ("0x0, 0x1") to save space on the wire.? 

[Med] We don't consider that because that would require changes to existing 7285 implementations. 

Probably this has
> already been discussed somewhere in the WG, so I apologize if I am
> way off on this.
> 
> Another minor comment is that RFC7285 defines variations of a JSON
> they use in now few different locations in the document, section
> 10.1, section 10.6, section 10.8.2 and after this document is
> approved also on section 10.5. To make transparent to the that
> they are different I would consider writing a line on section 3.2
> saying that neither the '.' separator nor the the at sign ('@')
> are allowed.

[Med] I don't think such a note is needed as the text is clear about allowed characters. Thanks.  

> 
> There is an extra space on 3.2: U+0041 -U+005A Should be: U+0041-
> U+005A
> 

[Med] Fixed.

> There is a typo on 3.2: ('_', +005F)
> Should be: ('_', U+005F)
> 

[Med] Fixed


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.