[art] Artart last call review of draft-ietf-add-dnr-10

Robert Sparks via Datatracker <noreply@ietf.org> Fri, 08 July 2022 15:39 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: art@ietf.org
Delivered-To: art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 9BD8DC15948C; Fri, 8 Jul 2022 08:39:29 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Robert Sparks via Datatracker <noreply@ietf.org>
To: art@ietf.org
Cc: add@ietf.org, draft-ietf-add-dnr.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 8.6.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <165729476963.37829.11777592836784898009@ietfa.amsl.com>
Reply-To: Robert Sparks <rjsparks@nostrum.com>
Date: Fri, 08 Jul 2022 08:39:29 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/art/6Iw-VYqtHg3pTJCEXsY7bjfSyPw>
Subject: [art] Artart last call review of draft-ietf-add-dnr-10
X-BeenThere: art@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Applications and Real-Time Area Discussion <art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/art>, <mailto:art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/art/>
List-Post: <mailto:art@ietf.org>
List-Help: <mailto:art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/art>, <mailto:art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jul 2022 15:39:29 -0000

Reviewer: Robert Sparks
Review result: Ready with Issues

Summary: Has issues to address before publication as a Proposed Standard RFC

Issues:

The document claims that Section 2.4.1 of I-D.ietf.dnsop-svcb-https defines the
encoding for the Service Priority field. It does not - it only discusses the
semantics. More clarity is needed. In _this_ document I suggest explicitly
saying you are encoding the Service Priority as a 16bit unsigned integer.

Nits:

You define Do53 and use it exactly once. It is unnecessary. Just say
unencrypted DNS the one place you use Do53.

Consider removing, or significantly expanding on, the last paragraph of 7.4.
The notion of unique pre-shared keys here seems under-described, and feels out
of place to me in a Proposed Standard document.

Micro-nit:

Consider changing the title of section 3.4 to "Multihoming is out of scope"
since you don't present any actual multihoming considerations.