Re: [art] [EXTERNAL] Artart last call review of draft-ietf-lamps-ocsp-nonce-update-04

Himanshu Sharma <himanshu@netskope.com> Thu, 04 April 2024 19:04 UTC

Return-Path: <himanshu@netskope.com>
X-Original-To: art@ietfa.amsl.com
Delivered-To: art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0ABE6C14F6A8 for <art@ietfa.amsl.com>; Thu, 4 Apr 2024 12:04:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.091
X-Spam-Level:
X-Spam-Status: No, score=-2.091 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=netskope.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d5WfZ5Qfg39R for <art@ietfa.amsl.com>; Thu, 4 Apr 2024 12:04:00 -0700 (PDT)
Received: from us-smtp-delivery-117.mimecast.com (us-smtp-delivery-117.mimecast.com [170.10.133.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1674FC14F6B3 for <art@ietf.org>; Thu, 4 Apr 2024 12:01:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netskope.com; s=mimecast20210603; t=1712257266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qaV1I4CW+toGJfMph7ECiSt7thrV/AoUugLY27dCKuo=; b=PFU2bKgoS15sl7EEKi5CSoB+QxuBxvQpq8Z8Y+7iahXtS39CJS2BZpLrfHDsMPc5zGsT7r zwAW8gIbTDjQKTD3Pu7pUPCxlDa1x9cL+Ok34tnWp2F9bhRaKDgBWMTQ+EUu4eo/dfTiuN MGSom7ETO0def1OGDDK/bIbTD2RMGZE=
Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-NmApMoC2M4q0pzCjO8PQnw-1; Thu, 04 Apr 2024 15:01:03 -0400
X-MC-Unique: NmApMoC2M4q0pzCjO8PQnw-1
Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-615404edc5fso14894567b3.0 for <art@ietf.org>; Thu, 04 Apr 2024 12:01:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712257263; x=1712862063; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=l0a4c/AcWgMwPK5+S+t8MYuHl65+yPh71PN8w9Sv1SY=; b=WuyOKNeQ35rF79OgJV1U3z+Xfip098Uz8ygOctxCEm3PeYBe39oS9h6jkUCPvRaTmg UZi3DMBIrTjBlwzNAyXfB5dvnZbkbUdEhRiazQNs5hor3suZIW16RU6w4YWV55T4wBRW Ql4SoaRSE8M5aDjNRmDXgN2x8qV4tMvHWR+oLb20SOsdFcMGw+urKe5Ou+uBddSRjKOA WNJ1bS7z8f+hDH4glnXQTAygFlyuOplxtV/d9sLyJsaEEC7yOYQ/mv9M9YLnQ+EynNZB ZCUYEwp2YG8Z9mtKeGAqs4JkKjGhgC7g6rmoxC51fTF4FpITv1zcaArGhl8CAXsZCoZN +QuA==
X-Gm-Message-State: AOJu0YxauH9xHi3FLXyWqlks/CxYJTO4iDExoV7mXr3HJr9AAPKhIRUy pIDLw82j0gVddjKHb1slBB5RFHG0YeXj3yOIrlHJkFqYUFjLisLjK95gdWcJZ8c1v4f3jvT+cMZ FW+LO2G1QTAycDL7Pid/rNM1rFnVkLhk7uO7sbAr+KMTgV0NAa1JOLDEfXz+wulPFGLRODoCkFB bIlZt9bgdHiOKba4Mb
X-Received: by 2002:a05:690c:c04:b0:615:1ad1:d6e6 with SMTP id cl4-20020a05690c0c0400b006151ad1d6e6mr348903ywb.16.1712257263433; Thu, 04 Apr 2024 12:01:03 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IGuwake0fZteWhq/nRMWrGiTccP5LSfFo0bGQ8tNbrknsuvjMd/qJwCZBvilBNPawxB7TcYd9OgN5PJ
X-Received: by 2002:a05:690c:c04:b0:615:1ad1:d6e6 with SMTP id cl4-20020a05690c0c0400b006151ad1d6e6mr348883ywb.16.1712257263114; Thu, 04 Apr 2024 12:01:03 -0700 (PDT)
Received: from netskope.com ([163.116.131.241]) by smtp-relay.gmail.com with ESMTPS id hk1-20020a05690c61c100b00608de16a1e2sm1319ywb.4.2024.04.04.12.01.02 for <art@ietf.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 12:01:03 -0700 (PDT)
X-Relaying-Domain: netskope.com
Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-5e4df21f22dso930460a12.0 for <art@ietf.org>; Thu, 04 Apr 2024 12:01:02 -0700 (PDT)
X-Received: by 2002:a17:902:ec90:b0:1e0:e8b5:3225 with SMTP id x16-20020a170902ec9000b001e0e8b53225mr452173plg.12.1712257261830; Thu, 04 Apr 2024 12:01:01 -0700 (PDT)
X-Received: by 2002:a17:902:ec90:b0:1e0:e8b5:3225 with SMTP id x16-20020a170902ec9000b001e0e8b53225mr452149plg.12.1712257261510; Thu, 04 Apr 2024 12:01:01 -0700 (PDT)
MIME-Version: 1.0
References: <171199463982.27279.13238273687080929241@ietfa.amsl.com> <CAL9pJ7mQg_eWye9OVV2w192Jcuchzcs_es6moFmSo=05DOLKsQ@mail.gmail.com> <CAL9pJ7n4gkYQSTRzC-ZH-dpEtDUzTvN9f8tTyPW73AZeh+QfhQ@mail.gmail.com>
In-Reply-To: <CAL9pJ7n4gkYQSTRzC-ZH-dpEtDUzTvN9f8tTyPW73AZeh+QfhQ@mail.gmail.com>
From: Himanshu Sharma <himanshu@netskope.com>
Date: Thu, 04 Apr 2024 12:00:50 -0700
Message-ID: <CAL9pJ7mfax5nM4PaL4gkXPp+1t8KN=MhOhJYs9Sm1k_C3t2BYA@mail.gmail.com>
To: Jim Fenton <fenton@bluepopcorn.net>
Cc: art@ietf.org, draft-ietf-lamps-ocsp-nonce-update.all@ietf.org, last-call@ietf.org, spasm@ietf.org, Joseph Salowey <joe@salowey.net>
x-netskope-inspected: true
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: netskope.com
Content-Type: multipart/alternative; boundary="000000000000d677b8061549f53f"
Archived-At: <https://mailarchive.ietf.org/arch/msg/art/9yF0J6bzecAr6xsYGrTBDhNkCWQ>
Subject: Re: [art] [EXTERNAL] Artart last call review of draft-ietf-lamps-ocsp-nonce-update-04
X-BeenThere: art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Applications and Real-Time Area Discussion <art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/art>, <mailto:art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/art/>
List-Post: <mailto:art@ietf.org>
List-Help: <mailto:art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/art>, <mailto:art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Apr 2024 19:04:05 -0000

Hi Jim,
   In case the updated ID was missed, Please have a look as It satisfies
all the feedback and suggestions provided by you.

-Thanks
Himanshu

On Tue, Apr 2, 2024 at 12:13 PM Himanshu Sharma <himanshu@netskope.com>
wrote:

> Hi Jim
>     Thanks for all the suggestions and pointing you the IDNITS errors.
> I have changed the content according to your suggestions, corrected the
> reference, and moved RFC 5912 to the informative reference section from
> normative reference section.
> Russ has verified the ASN.1 module and it compiles fine.
> Now this draft has 0 errors reported from IDNITS.
> Meanwhile I have reached out to Joseph Salowey and am working with him to
> address the feedback he has provided.
>
> Himanshu
>
>
>
> On Mon, Apr 1, 2024 at 3:12 PM Himanshu Sharma <himanshu@netskope.com>
> wrote:
>
>> Thanks Jim for your time to review the Draft.
>>  I will work on the suggestions and update the draft accordingly.
>>
>>
>>
>> On Mon, Apr 1, 2024 at 11:04 AM Jim Fenton via Datatracker <
>> noreply@ietf.org> wrote:
>>
>>> Reviewer: Jim Fenton
>>> Review result: Almost Ready
>>>
>>> I am the designated ART ART reviewer for
>>> draft-ietf-lamps-ocsp-nonce-update-04.
>>>
>>> Status: Almost ready
>>>
>>> Comments:
>>>
>>> Section 1, suggest replacing "[RFC8954] enforce the maximum" to
>>> "[RFC8954]
>>> limits the maximum"
>>>
>>> Section 2, suggest replacing "enforce" with "limit".
>>>
>>> Section 2.1 paragraph 1 can be deleted since this is replacing RFC8954
>>> in its
>>> entirety.
>>>
>>> Section 2.1 paragraph 3: "An OCSP client that implements this document
>>> SHOULD
>>> use a minimum length of 32 octets..." while RFC 8954 says, "Newer OCSP
>>> clients
>>> that support this document MUST use a length of 32 octets..." It seems
>>> like
>>> this requirement has been weakened; is there a reason for that? Also in
>>> that
>>> paragraph, rather than "in excess of what is permitted by RFC 8954"
>>> suggest
>>> saying "in excess of the limit of 32 octets that was specified in RFC
>>> 8954."
>>>
>>> Section 2.1 paragraph 4: replace "...MUST accept Nonce octets length of
>>> at
>>> least 16 octets..." with "...MUST accept Nonce lengths of at least 16
>>> octets..."
>>>
>>> Section 2.1 paragraph 5: replace "Nonce octet length" with "Nonce length"
>>>
>>> In the example, the object identifier, in addition to Offset and Length,
>>> is in
>>> decimal.
>>>
>>> I don't have the expertise in ASN.1 to fully review Appendix A; hopefully
>>> another reviewer can check that.
>>>
>>> IDNITS points out that you have a normative reference to RFC 5912, which
>>> is
>>> informational. I'm not sure the reference is really normative, though.
>>>
>>>
>>>