[art] Artart last call review of draft-ietf-ecrit-similar-location-17
Claudio Allocchio via Datatracker <noreply@ietf.org> Sun, 06 February 2022 21:56 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: art@ietf.org
Delivered-To: art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id BF7DC3A0E38; Sun, 6 Feb 2022 13:56:36 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Claudio Allocchio via Datatracker <noreply@ietf.org>
To: art@ietf.org
Cc: draft-ietf-ecrit-similar-location.all@ietf.org, ecrit@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.44.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164418459665.11182.16534615518046717365@ietfa.amsl.com>
Reply-To: Claudio Allocchio <Claudio.Allocchio@garr.it>
Date: Sun, 06 Feb 2022 13:56:36 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/art/gTqJGjkpYHmcYZPoX1oTvPqC_Zg>
Subject: [art] Artart last call review of draft-ietf-ecrit-similar-location-17
X-BeenThere: art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Applications and Real-Time Area Discussion <art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/art>, <mailto:art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/art/>
List-Post: <mailto:art@ietf.org>
List-Help: <mailto:art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/art>, <mailto:art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Feb 2022 21:56:46 -0000
Reviewer: Claudio Allocchio Review result: Ready with Issues The document does not have major issues, so it can be considered "ready". However the way the document is written is often very narrative, instead of preferring schemas, diagrams etc. and this can sometimes confuse the implementer while reading it. Here are my suggestions for improvement: - the abstract can be shortened just to specify directly why we need this extension - there are in section 3 cases where the sentence id a double negative (a MUST NOT followed by a negative sentence). They are correct, but may I suggest to turn them into a single positive (a MUST and a positive sentence to follow) ? - a "query", "response" etc flow schema may help in making sections 3 less narrative and more easy to read - all examples are just "US centric" (e.g. using US style postal addresses): I would suggest considering also examples take from other different postal addresses schema, both to show how they fit into the schema itself - there are some typos/nits to fix with a proof reading all the best
- [art] Artart last call review of draft-ietf-ecrit… Claudio Allocchio via Datatracker
- Re: [art] Artart last call review of draft-ietf-e… Francesca Palombini