Re: [Asap] [Last-Call] Artart last call review of draft-ietf-asap-siptrunkingcapability-link-03

Tim Bray <tbray@textuality.com> Fri, 10 March 2023 17:44 UTC

Return-Path: <tbray@textuality.com>
X-Original-To: asap@ietfa.amsl.com
Delivered-To: asap@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 565ECC16B5B3 for <asap@ietfa.amsl.com>; Fri, 10 Mar 2023 09:44:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.096
X-Spam-Level:
X-Spam-Status: No, score=-7.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=textuality.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QIsm8KPITyZv for <asap@ietfa.amsl.com>; Fri, 10 Mar 2023 09:44:45 -0800 (PST)
Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2883C16953F for <asap@ietf.org>; Fri, 10 Mar 2023 09:44:45 -0800 (PST)
Received: by mail-ed1-x52f.google.com with SMTP id g3so23690877eda.1 for <asap@ietf.org>; Fri, 10 Mar 2023 09:44:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=textuality.com; s=google; t=1678470284; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KmE17kxAVpK1mZCv60XnkQnLfx0KJHJEe3YGByyZpzE=; b=JL9x78+zKs5yuz1OGnsfZiBCVdXCsTjmypSlkXDD5jMbu56AjQIOMll1W6Ep1ZA3D2 9ZoZ+jvqsTicNoaz/d2Jf12XJ+RFFO4rl8CUPugAJFzYgfHtboxv7Jyiz1nbOZaggLKU wxynUbq7hKKOKU9qBe4GLGQB6aAoTTUoYQ2bk=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678470284; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KmE17kxAVpK1mZCv60XnkQnLfx0KJHJEe3YGByyZpzE=; b=fZJq6rCWFWvXS5zoL3FcgJAWGJUWeU9ZPLldIj0nZiz9bUup1BDu7jhyWPyxUQ2Yry NhcPTZxjKDW3rrSQoI53n3R//duVGoOtp7qfmP3yj1gPs5vq6ZvdQOFVtRaZbXKzTjkZ dMcAl2OeH+RoPLy52jQfzt+ORs12PZmmnHaaq+OoK0KunXii1Xuzvo/wEz5ioI6q3Brg Ibuis9fw0ciw31gVooVpZ10K5abkqsF45yy942bmn/RqOCWPYKGIEiR5NsGfbwPE+YRw WtXVEPGeg+178IMCfxoOjByoFXYnHrxUodgHQQrk7vDVhEe57IlqBDp0BmWCMciugqMb O2zg==
X-Gm-Message-State: AO0yUKVpw2XmeaEsANx3x3rd4rswJzYTAzV9+Uz0DCyhFbKSUT86q5ns VWeKV1FWfU29YHmgMe+cDbctVod1JVGNC2JgwvfWEN/xWbvvM1/u+2sKpQ==
X-Google-Smtp-Source: AK7set8lmqY8chhxf/arcnMJJa+rauwjqHe/hkAJDjZEhILH40YSxoH2U2b+vdRp126px73EvmCee0v6jsm/kejgUS4=
X-Received: by 2002:a17:906:3d51:b0:8f1:4c6a:e72 with SMTP id q17-20020a1709063d5100b008f14c6a0e72mr12863098ejf.0.1678470283916; Fri, 10 Mar 2023 09:44:43 -0800 (PST)
MIME-Version: 1.0
References: <167847017629.24446.1620622805905245537@ietfa.amsl.com>
In-Reply-To: <167847017629.24446.1620622805905245537@ietfa.amsl.com>
From: Tim Bray <tbray@textuality.com>
Date: Fri, 10 Mar 2023 09:44:32 -0800
Message-ID: <CAHBU6itM3vgcjkSsx0+gynARdjkDpQiiAA1EOvzcmY4yoi08xg@mail.gmail.com>
To: Tim Bray <tbray@textuality.com>
Cc: art@ietf.org, asap@ietf.org, draft-ietf-asap-siptrunkingcapability-link.all@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="0000000000000a0cf305f68f51b6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/asap/yck10x6ZWbJaJ2H-DOuVMBH3_6I>
Subject: Re: [Asap] [Last-Call] Artart last call review of draft-ietf-asap-siptrunkingcapability-link-03
X-BeenThere: asap@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Automatic SIP trunking And Peering WG <asap.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/asap>, <mailto:asap-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/asap/>
List-Post: <mailto:asap@ietf.org>
List-Help: <mailto:asap-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/asap>, <mailto:asap-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Mar 2023 17:44:49 -0000

[Now with line breaks. Sorry.]

- Reading section 1, I wondered what dereferencing a URI with this link
type would yield. Following the reference to draft-ietf-asap-sip-auto-peer-07,
I eventually found the YANG definition, but I was a little surprised that
it didn't seem to register a media type?  Now, RFC8288 is careful to
decouple link types and media types, but the lack of a media type does feel
like a gap.

- In the GET example in section 3, maybe a note that the line-breaks &
indentation are there for clarity? As presented it's not a valid GET
request.

- In the security considerations, perhaps a reference to
draft-ietf-asap-sip-auto-peer#name-security-considerations would be helpful?

On Fri, Mar 10, 2023 at 9:43 AM Tim Bray via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Tim Bray
> Review result: Ready with Nits
>
> I am the designated Artart Last Call reviewer for
> draft-ietf-asap-siptrunkingcapability-link-03.
>
> This document is good; I remember almost nothing about SIP and it was still
> easy to understand. Nits:
>
> - Reading section 1, I wondered what dereferencing a URI with this link
> type
> would yield. Following the reference to draft-ietf-asap-sip-auto-peer-07, I
> eventually found the YANG definition, but I was a little surprised that it
> didn't seem to register a media type?  Now, RFC8288 is careful to decouple
> link
> types and media types, but the lack of a media type does feel like a gap.
> - In
> the GET example in section 3, maybe a note that the line-breaks &
> indentation
> are there for clarity? As presented it's not a valid GET request. - In the
> security considerations, perhaps a reference to
> draft-ietf-asap-sip-auto-peer#name-security-considerations would be
> helpful?
>
>
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call
>