Re: [AVTCORE] Comments on draft-ietf-avtcore-leap-second-01

Kevin Gross <kevin.gross@avanw.com> Thu, 08 November 2012 22:06 UTC

Return-Path: <kevin.gross@avanw.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC19F21F8836 for <avt@ietfa.amsl.com>; Thu, 8 Nov 2012 14:06:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.651
X-Spam-Level:
X-Spam-Status: No, score=-0.651 tagged_above=-999 required=5 tests=[AWL=0.991, BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, IP_NOT_FRIENDLY=0.334]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e5tabqrxZC1w for <avt@ietfa.amsl.com>; Thu, 8 Nov 2012 14:06:17 -0800 (PST)
Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com [67.222.55.9]) by ietfa.amsl.com (Postfix) with SMTP id 90E9B21F87F2 for <avt@ietf.org>; Thu, 8 Nov 2012 14:06:16 -0800 (PST)
Received: (qmail 31521 invoked by uid 0); 8 Nov 2012 22:05:54 -0000
Received: from unknown (HELO host291.hostmonster.com) (74.220.215.91) by oproxy7.bluehost.com with SMTP; 8 Nov 2012 22:05:53 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=avanw.com; s=default; h=Content-Type:Cc:To:From:Subject:Message-ID:Date:References:In-Reply-To:MIME-Version; bh=mM4C9e8v858zmRTaLZTQDtXn/waKuReZnhkVInv/dt0=; b=TRxNHvwKBKSK1DujaFWlol0NIXqMINe/HmAO9KMoiNSK2J4u9Z2Vme+xAIa8Rz6Jl9rUxS09uW8vhkePh113rEnV1GSXogG45uTRYXeEu9E4pjvkgpzHqFzAIjfZmKeG;
Received: from [74.125.83.44] (port=57589 helo=mail-ee0-f44.google.com) by host291.hostmonster.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.76) (envelope-from <kevin.gross@avanw.com>) id 1TWaET-0005eR-Fn for avt@ietf.org; Thu, 08 Nov 2012 15:05:53 -0700
Received: by mail-ee0-f44.google.com with SMTP id d4so2088092eek.31 for <avt@ietf.org>; Thu, 08 Nov 2012 14:05:52 -0800 (PST)
MIME-Version: 1.0
Received: by 10.14.209.136 with SMTP id s8mr30951773eeo.33.1352412352021; Thu, 08 Nov 2012 14:05:52 -0800 (PST)
Received: by 10.223.152.201 with HTTP; Thu, 8 Nov 2012 14:05:51 -0800 (PST)
In-Reply-To: <509C26C2.30505@ericsson.com>
References: <509C26C2.30505@ericsson.com>
Date: Thu, 08 Nov 2012 17:05:51 -0500
Message-ID: <CALw1_Q1wneULhLR8kUz+nz-hX6dWhPQYj45L3FaDpifj0Aa8qg@mail.gmail.com>
From: Kevin Gross <kevin.gross@avanw.com>
To: Magnus Westerlund <magnus.westerlund@ericsson.com>
Content-Type: multipart/alternative; boundary="047d7b603a8ad5063b04ce030992"
X-Identified-User: {1416:host291.hostmonster.com:avanwcom:avanw.com} {sentby:smtp auth 74.125.83.44 authed with kevin.gross@avanw.com}
Cc: IETF AVTCore WG <avt@ietf.org>, draft-ietf-avtcore-leap-second@tools.ietf.org
Subject: Re: [AVTCORE] Comments on draft-ietf-avtcore-leap-second-01
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/avt>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Nov 2012 22:06:18 -0000

Thanks for the review. Responses below.

On Thu, Nov 8, 2012 at 4:40 PM, Magnus Westerlund <
magnus.westerlund@ericsson.com> wrote:

> Hi,
>
> I have reviewed the leap second document and have the following comments.
>
> 1. Section 1. It needs to say also in the introduction that it updates
> RFC 3550, not only in the abstract.
>

Ok.

>
> 2. Section 3.4:
>    +-------+--------------+--------------+--------------+--------------+
>    |  RTP  |      TAI     |      UTC     |     POSIX    |      NTP     |
>    +-------+--------------+--------------+--------------+--------------+
>    |  8000 | 00:00:32.500 | 23:59:58.500 | 23:59:58.500 | 23:59:58.500 |
>    | 12000 | 00:00:33.000 | 23:59:59.000 | 23:59:59.000 | 23:59:59.000 |
>    | 16000 | 00:00:33.500 | 23:59:59.500 | 23:59:59.500 | 23:59:59.500 |
>    | 20000 | 00:00:34.000 | 23:59:60.000 | 23:59:59.000 | 00:00:00.000 |
>    | 24000 | 00:00:34.500 | 23:59:60.500 | 23:59:59.500 | 00:00:00.000 |
>    | 28000 | 00:00:35.000 | 00:00:00.000 | 00:00:00.000 | 00:00:00.000 |
>    | 32000 | 00:00:35.500 | 00:00:00.500 | 00:00:00.500 | 00:00:00.500 |
>    +-------+--------------+--------------+--------------+--------------+
>
>                                   Table 1
>
> I am wondering if the RTP 20000 and 24000 is really correctly
> representing what you write in section 3.2 for the NTP column. Should't
> the 00:00:00.000 actually  00:00:00.000-, i.e. something that is prior
> to 00:00:00.000 but just?
>

A common system behavior is that when the NTP clock is
frozen, successive calls to retrieve system return incrementally larger
time values. This keeps applications from faulting from assumptions about
time being continuous and monotonic. This behavior occurs in the LS bits of
the time value and so is not generally visible in the human-readable format
shown in the table. I can add a discussion of this if you think it is
useful.

>
> 3. Section 4.1:
>
>    RTP Senders working to a leap-second-bearing reference SHOULD NOT
>    generate sender reports containing an originating NTP timestamp in
>    the vicinity of a leap second.  Receivers SHOULD ignore timestamps in
>    any such reports inadvertently generated.
>
> I wonder how you in practice are going to fulfill the sender
> recommendation. That only works if your regular reporting interval is on
> the order of a second or longer. Otherwise not sending a SR packet for a
> RTP packet sender within 1.5*Td (where Td is your deterministic
> reporting interval) will be counted towards source time-out or other
> methods detecting missing packets. So for a reporting interval of 100 or
> 200 ms you can't actually follow the SHOULD.
>

That's a good point. If we need to keep sending SRs during the 2second leap
second interval to avoid timeouts, they can be sent with a 0 NTP timestamp.
This might be a better approach for all RTCP rates. I have to research what
special receiver behavior may be required to accommodate this.

>
> 4. Section 5. Security Consideration.
>
> I wonder if this section really are covering some potential issues.
> First are there security replay mechanisms that uses the clock? SRTP is
> not effected as it uses packet index, i.e. roll over counter + seq_nr.
> But there might be other things that could be confused for example by
> the posix clock.
>
> Are there attack vectors that are created when by possibly fool an
> end-host to believe a leap-second event is happening and thus thinks the
> clock are freezing or repeating that otherwise would be possible?
>

Today I volunteered to review draft-ietf-tictoc-security-requirements. I
will take this and your comments into consideration and try to improve the
security considerations section.
>
>
> 5. Reference section:
>
> I don't believe that all references are normative. I think for example
> the note in section 3.0 uses [3] in an informative one. Additional ones
> may be similar. Please check the usage of all the references if they
> really are normative.
>

Sounds like I need to look at dividing informative vs. normative
references.

>
> Cheers
>
> Magnus Westerlund
>
> ----------------------------------------------------------------------
> Multimedia Technologies, Ericsson Research EAB/TVM
> ----------------------------------------------------------------------
> Ericsson AB                | Phone  +46 10 7148287
> Färögatan 6                | Mobile +46 73 0949079
> SE-164 80 Stockholm, Sweden| mailto: magnus.westerlund@ericsson.com
> ----------------------------------------------------------------------
>
> _______________________________________________
> Audio/Video Transport Core Maintenance
> avt@ietf.org
> https://www.ietf.org/mailman/listinfo/avt
>