[AVTCORE] AD review: draft-ietf-avtcore-ecn-for-rtp-06
Robert Sparks <rjsparks@nostrum.com> Thu, 08 March 2012 19:34 UTC
Return-Path: <rjsparks@nostrum.com>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7733621E8021 for <avt@ietfa.amsl.com>; Thu, 8 Mar 2012 11:34:17 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.546
X-Spam-Level:
X-Spam-Status: No, score=-102.546 tagged_above=-999 required=5 tests=[AWL=0.054, BAYES_00=-2.599, SPF_PASS=-0.001, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q9FYwsMRv1SP for <avt@ietfa.amsl.com>; Thu, 8 Mar 2012 11:34:17 -0800 (PST)
Received: from nostrum.com (nostrum-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:267::2]) by ietfa.amsl.com (Postfix) with ESMTP id A993421E8019 for <avt@ietf.org>; Thu, 8 Mar 2012 11:34:14 -0800 (PST)
Received: from unexplicable.local (pool-71-170-125-181.dllstx.fios.verizon.net [71.170.125.181]) (authenticated bits=0) by nostrum.com (8.14.3/8.14.3) with ESMTP id q28JYDc8015925 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 8 Mar 2012 13:34:14 -0600 (CST) (envelope-from rjsparks@nostrum.com)
Message-ID: <4F5909B5.9010603@nostrum.com>
Date: Thu, 08 Mar 2012 13:34:13 -0600
From: Robert Sparks <rjsparks@nostrum.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: avt@ietf.org, draft-ietf-avtcore-ecn-for-rtp@tools.ietf.org
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Received-SPF: pass (nostrum.com: 71.170.125.181 is authenticated by a trusted mechanism)
Subject: [AVTCORE] AD review: draft-ietf-avtcore-ecn-for-rtp-06
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/avt>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Mar 2012 19:34:17 -0000
Summary: Ready for IETF LC with minor issues to address during LC. Watch for the IETF LC announcement shortly. Chairs/shepherd: Please request a review from the SDP directorate. Please treat these as LC comments: *) ietf-avt-rtp-no-op is very expired. Are there plans to progress it? If not, can you point to something else? *) Section 5.2's definition of "Block Length" has a bug. This length is counting 32-bit words. "not a multiple of five octets" does not make sense. It should simply be "not a multiple of five". It might also help to say "The number of 32-bit words in the report block" instead of "The length of the report block" as the first sentence of the definition? *) In section 5.1, why is this sentence using 2119: "Thus handling of wrapping of these counters MUST be supported". It's not clear what "be supported" means, so it's hard to know what the MUST is constraining. Is this anything more than a implementation consideration saying "don't write code that will crash when the counter overflows"? *) Section 7.3.3 paragraph 2. Given this MUST, was the intent to require that any such "other reactions" only be deployed if they were standardized? In the IETF? Can this be clarified? *) In section 10.6, What name are you asking IANA to put in the attribute registry? It's not obvious when reading section 7.2.2. Do you want that to be "ECN", or would it be better if it were "ECN-CHECK"? *) Why isn't the reference to RFC4566 (SDP) normative? Nits: Section 1 paragraph 2 first sentence: "is getting attention" will not age well. Section 7.2.2 last paragraph: "SHALL be discard"->"SHALL be discarded" Section 7.4 first paragraph: How do you reduce an assumption? Should this say "The probability this assumption is correct" is reduced? Section 7.4.1 3rd paragraph: "then the two possible"->"then two possible" Section 11 first "Denial of service" section: "sender disable the usage"->"sender disables the usage"
- [AVTCORE] AD review: draft-ietf-avtcore-ecn-for-r… Robert Sparks