IETF Logo Mail Archive

Re: [AVTCORE] AD review of draft-ietf-payload-rtp-ttml-02

James Sandford <james.sandford@bbc.co.uk> Thu, 26 September 2019 09:13 UTC

Return-Path: <james.sandford@bbc.co.uk>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 60980120125; Thu, 26 Sep 2019 02:13:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8AVBFYSJkSam; Thu, 26 Sep 2019 02:13:13 -0700 (PDT)
Received: from mailout0.cwwtf.bbc.co.uk (mailout0.cwwtf.bbc.co.uk [132.185.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E81712084D; Thu, 26 Sep 2019 02:13:13 -0700 (PDT)
Received: from BGB01XI1012.national.core.bbc.co.uk (bgb01xi1012.national.core.bbc.co.uk [10.161.14.16]) by mailout0.cwwtf.bbc.co.uk (8.15.2/8.15.2) with ESMTP id x8Q9DBN5018861; Thu, 26 Sep 2019 10:13:11 +0100 (BST)
Received: from BGB01XI1015.national.core.bbc.co.uk (10.161.14.78) by BGB01XI1012.national.core.bbc.co.uk (10.161.14.16) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 26 Sep 2019 10:13:10 +0100
Received: from BGB01XUD1012.national.core.bbc.co.uk ([10.161.14.10]) by BGB01XI1015.national.core.bbc.co.uk ([10.161.14.78]) with mapi id 14.03.0408.000; Thu, 26 Sep 2019 10:13:10 +0100
From: James Sandford <james.sandford@bbc.co.uk>
To: Barry Leiba <barryleiba@computer.org>, "draft-ietf-payload-rtp-ttml.all@ietf.org" <draft-ietf-payload-rtp-ttml.all@ietf.org>
CC: "avt@ietf.org" <avt@ietf.org>
Thread-Topic: AD review of draft-ietf-payload-rtp-ttml-02
Thread-Index: AQHVdBgUFTh21K1Yg0mt896Qe9aVlKc9rK5G
Date: Thu, 26 Sep 2019 09:13:10 +0000
Message-ID: <734752AF0E88364D983373FE5CEFED5770DD04F3@bgb01xud1012>
References: <CALaySJ+_PgTJ=UObr21jAab7KSHLX2cZu6PLsxjB=uo2Sv+Sjg@mail.gmail.com>
In-Reply-To: <CALaySJ+_PgTJ=UObr21jAab7KSHLX2cZu6PLsxjB=uo2Sv+Sjg@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [132.185.132.12]
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.2.1013-24054.007
X-TM-AS-Result: No-6.563900-8.000000-10
X-TMASE-MatchedRID: X4bcv0S75Knr/497FfFvZhes/RxhysDbZa7LkubQvj8dMKZmwJi4SOZk tt2TiF8suiIcdMkoZb8DZCldP9AFvrQ/gWi/bNdVyPPRU9ScEDVr9+Kgn2XgeNrbWin3863fZGa XPLvxUHRe9N8X0ShXYNGLiYIi41QmuN0AXBH/oPF6pWmpFd8o3snlJe2gk8vIF+7/NKS75QcIZJ R7eWK/XEdPkJ3+RHyBbOQvzWn9Cmhu91Qj4cgn45YsKSXWWrsH6r3HCixfuKcc4ri4RJV/1RyUZ LFni6AmdvgGbsWpCcs+cjURnQbybFN5kIZnYeEYDB+ErBr0bAMl3afZehJEWaMLUT/MIQivd9Oj 2OGJopnXx+5C83iNtxJd38M4xt+YhFhuH8Sj5cVzmKcWXKl6qn0tCKdnhB58eVl+oyOKCVf3PDi XO/tFSQDaKM/bqKGRiHf2+2o/IMtM3Xusaj14R/rGHVIhNhU+1t51g1X0xSMAjm77aK0G0uL5gS gm6vEwwSASbfJcuD7euXsNnlUTNEFhOUSORqH4
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--6.563900-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.2.1013-24054.007
Content-Type: multipart/alternative; boundary="_000_734752AF0E88364D983373FE5CEFED5770DD04F3bgb01xud1012_"
MIME-Version: 1.0
X-EXCLAIMER-MD-CONFIG: c91d45b2-6e10-4209-9543-d9970fac71b7
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/WmNc20vm8YXuK2ONbaF1eYIlqEw>
Subject: Re: [AVTCORE] AD review of draft-ietf-payload-rtp-ttml-02
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Sep 2019 09:13:15 -0000

Noted. I'll make the changes you've suggested once last call is over. Thank you for your review.

Regards,
James


==========
James Sandford
R&D Project Engineer

BBC Research and Development
5th Floor
Dock House
MediaCityUK
Salford
M50 2LH

Tel: 030304 (09549)
Web: http://www.bbc.co.uk/rd
________________________________
From: Barry Leiba [barryleiba@computer.org]
Sent: 26 September 2019 04:11
To: draft-ietf-payload-rtp-ttml.all@ietf.org
Cc: avt@ietf.org
Subject: AD review of draft-ietf-payload-rtp-ttml-02


Nicely written, and I have little to say.  My comments are minor, and can be handled along with any other last-call comments; I will request last call as soon as I’ve sent this note.


— Section 4.1 —


      Note that the length of data

      words will depend on the character encoding used (e.g. 8 bit words

      for UTF-8, 16 bit words for UTF-16).


A reader could be confused by “length of data words” here.  I suggest this:


NEW

      Note that the length of each data

      word depends on the character encoding used: for UTF-8 a word

      is 8 bits, while it is 16 bits for UTF-16.


— Section 4.2 —


   Documents carried in User Data Words are encoded in accordance with

   one of the defined TTML profiles specified in its registry

   [TTML-MTPR].


The antecedent to “its” isn’t clear; I suggest “in the TTML registry”.  (You might, then, even make it, “one of the defined profiles in the TTML registry [TTML-MTPR].”)

Barry

v2.23.0 | Report a Bug | By Email