Re: [AVTCORE] Benjamin Kaduk's No Objection on draft-ietf-payload-rtp-jpegxs-16: (with COMMENT)

Benjamin Kaduk <kaduk@mit.edu> Sat, 19 June 2021 01:47 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: avt@ietfa.amsl.com
Delivered-To: avt@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70DCA3A1B2A; Fri, 18 Jun 2021 18:47:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.196
X-Spam-Level:
X-Spam-Status: No, score=-4.196 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l247OcvH3uGx; Fri, 18 Jun 2021 18:47:01 -0700 (PDT)
Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BB23F3A1B29; Fri, 18 Jun 2021 18:47:00 -0700 (PDT)
Received: from kduck.mit.edu ([24.16.140.251]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15J1kqLY031299 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Jun 2021 21:46:57 -0400
Date: Fri, 18 Jun 2021 18:46:52 -0700
From: Benjamin Kaduk <kaduk@mit.edu>
To: Tim Bruylants <TBR@intopix.com>
Cc: The IESG <iesg@ietf.org>, "draft-ietf-payload-rtp-jpegxs@ietf.org" <draft-ietf-payload-rtp-jpegxs@ietf.org>, "avtcore-chairs@ietf.org" <avtcore-chairs@ietf.org>, "avt@ietf.org" <avt@ietf.org>, Ali Begen <ali.begen@networked.media>, "bernard.aboba@gmail.com" <bernard.aboba@gmail.com>
Message-ID: <20210619014652.GB11634@kduck.mit.edu>
References: <162391594041.10475.10269870855508874539@ietfa.amsl.com> <PR3P192MB07483D1BE2863F6E6AACE16BAC0E9@PR3P192MB0748.EURP192.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <PR3P192MB07483D1BE2863F6E6AACE16BAC0E9@PR3P192MB0748.EURP192.PROD.OUTLOOK.COM>
Archived-At: <https://mailarchive.ietf.org/arch/msg/avt/cFQ5KDayCJlm9g6cnEl7FbkzObI>
Subject: Re: [AVTCORE] Benjamin Kaduk's No Objection on draft-ietf-payload-rtp-jpegxs-16: (with COMMENT)
X-BeenThere: avt@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Audio/Video Transport Core Maintenance <avt.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/avt>, <mailto:avt-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/avt/>
List-Post: <mailto:avt@ietf.org>
List-Help: <mailto:avt-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/avt>, <mailto:avt-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Jun 2021 01:47:04 -0000

Hi Tim,

Just to close the loop: your replies all make sense to me, and thanks for
providing the additional explanation and updating the draft as appropriate.

-Ben

On Thu, Jun 17, 2021 at 07:06:29PM +0000, Tim Bruylants wrote:
> > ----------------------------------------------------------------------
> > COMMENT:
> > ----------------------------------------------------------------------
> >
> > I'll echo the sentiment of other reviewers that the scope of review possible is limited witout access to the underlying ISO specification.
> > I further note that in the recent case of https://urldefense.proofpoint.com/v2/url?u=https-3A__datatracker.ietf.org_doc_draft-2Dietf-2Dpayload-2Dvp9_&d=DwICaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=lABbJkTi_k8nlRKSDgb6IQxDFAqulQ5BxeXA83yq3SI&m=EUpYAiLAgXylCuqQrCOWa_FavJHgm4h934uh2eTmjF8&s=Pdi60gBr_pxE6ALbEjNia0vvwAW1nUHIjda7-wGs8UE&e= (for which the underlying specification is freely available), there was an error in replicating the chroma subsampling details from the underlying reference to the internet-draft.  Any such errors are undetectable for this draft.
> 
> Indeed. See comment of "Francesca Palombini". This is a valid comment. We are unsure how to resolve this. ISO is very strict about distribution of documents outside of the working groups (i.e. it is not allowed at all).
> 
> > Section 4.3
> >
> > Does the value of the T and K bits need to be identical for all packets of a given RTP stream?
> 
> Indeed, the T and K bits are not allowed to change in the RTP stream session. We clarified this.
> 
> > Section 4.4
> >
> > It's perhaps needlessly confusing to have the human-readable slice labels in Figures 8 and 9 start at 1 but the SEP counter start at 0.
> 
> We chose to start the human counting with 1. The actual algorithm counter values for SEP and P however do indeed start at 0. It would be tricky to change the figures this late in the review process.
> 
> > nit: if SLH is an acronym it should be expanded somewhere (it only appears in the figures, at present).
> 
> SLH is an XS marker. We added this in Section 2 (without repeating its definition from ISO 21122-1).
> 
> > In the slice packetization modes, do we have reasonable guarantees that the JPEG XS header (including all markers and marker segments) will fit into a single RTP packet?
> 
> Yes. Slice packetization mode essentially states that each RTP packet contains data from only ONE slice. But slices can be split (at arbitrary boundaries) over multiple RTP packets (and this will almost always happen). Markers and marker segments can only occur in the first RTP packet of a slice (and these are very small -- 6 bytes for the SLH marker).
> 
> > Section 7.1
> >
> >    Applications that use this media type:
> >       For example: SMPTE ST 2110, Video over IP, Video conferencing,
> >       Broadcast applications.
> >
> > I think bland declarative statements like "applications that transmit video over RTP" tend to be more common than longer "for example"
> > listings, in this type of registration.
> 
> Agreed. We changed this to: "Any application that transmits video over RTP (like SMPTE ST 2110)."
> 
> > Section 8
> >
> > nit: s/SPD/SDP in the section heading.
> 
> That's a good catch. Fixed it.
> 
>