Re: [babel] Document Shepherd review of draft-ietf-babel-source-specific-04

Juliusz Chroboczek <jch@irif.fr> Sun, 30 December 2018 00:08 UTC

Return-Path: <jch@irif.fr>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79246130DC0 for <babel@ietfa.amsl.com>; Sat, 29 Dec 2018 16:08:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dgw8VcMNIwlg for <babel@ietfa.amsl.com>; Sat, 29 Dec 2018 16:08:08 -0800 (PST)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3045C1294D0 for <babel@ietf.org>; Sat, 29 Dec 2018 16:08:07 -0800 (PST)
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id wBU07xu0032683; Sun, 30 Dec 2018 01:07:59 +0100
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 0BF3D20508; Sun, 30 Dec 2018 01:08:05 +0100 (CET)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id o0sGc4B7kzvN; Sun, 30 Dec 2018 01:08:03 +0100 (CET)
Received: from pirx.irif.fr (unknown [80.50.139.114]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 3709520505; Sun, 30 Dec 2018 01:08:02 +0100 (CET)
Date: Sun, 30 Dec 2018 01:08:01 +0100
Message-ID: <87muonev1a.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: Donald Eastlake <d3e3e3@gmail.com>
Cc: Babel at IETF <babel@ietf.org>
In-Reply-To: <CAF4+nEEzuw=Fr-uwoQari1hknRJ32zq2k6BQizYKmQyTi53hpw@mail.gmail.com>
References: <CAF4+nEEzuw=Fr-uwoQari1hknRJ32zq2k6BQizYKmQyTi53hpw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [194.254.61.138]); Sun, 30 Dec 2018 01:07:59 +0100 (CET)
X-Miltered: at korolev with ID 5C280C5F.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 5C280C5F.000 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 5C280C5F.000 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/4c4sxrTK3-oxHXo993eqH6_4fvI>
Subject: Re: [babel] Document Shepherd review of draft-ietf-babel-source-specific-04
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Dec 2018 00:08:11 -0000

Thanks a lot for the review, Donald.

We're slightly incoherent here:

  - Section 7 says that multiple sub-TLVs in a single Update MUST NOT be
    sent and the whole TLV SHOULD be ignored;
  - Section 7 also says that a sub-TLV in a retraction MUST NOT be sent,
    while Section 5 says that such a sub-TLV MUST be ignored on reception.

(You appear to have missed the bit in Section 5, which I cannot blame you
for -- it needs repeating in Section 7).

The reason for the inconsistence is that an implementation must check for
the presence of the sub-TLV in any case, so the requirement to discard
retractions with the sub-TLV puts no extra onus on implementations.  On
the other hand, checking for the case of multiple occurrences of the
sub-TLV puts a small cost on implementations, but one that's probably
negligible.

I'm definitely going to update Section 7 to repeat the requirement in
Section 5.

I think you're right, that the SHOULD about multiple sub-TLVs should be
a MUST, but I want to sleep over it and check the implementation.  Toke,
do you have an opinion?

-- Juliusz