IETF Logo Mail Archive

Re: [babel] [Babel-users] Babel MAC auth fails due to packet reordering

Toke Høiland-Jørgensen <toke@toke.dk> Fri, 13 May 2022 22:37 UTC

Return-Path: <toke@toke.dk>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3C4FBC18D82C for <babel@ietfa.amsl.com>; Fri, 13 May 2022 15:37:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=toke.dk
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nBwRipHS8Sfo for <babel@ietfa.amsl.com>; Fri, 13 May 2022 15:37:21 -0700 (PDT)
Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 68626C18D82B for <babel@ietf.org>; Fri, 13 May 2022 15:37:20 -0700 (PDT)
From: Toke Høiland-Jørgensen <toke@toke.dk>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1652481437; bh=olFGJttdI5aj1Q3OQ77jewtpN/vOvM78p9LL29SXek8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OqDBpXSspshHmyESm15GHSC6OfmPCYPMtmIDuDX08ebJlBrwjv980P5bKj09fHNxb XULve85e0A/0kl01qtBN/ZMgINWwGkCr3Fl2O7vJlAzCs6fq57IDkpeAu10ik8i7Cv SrSGm+tF7FnZTz9LUFGzSP5FxMcml7eCUJ2KNXa7ty+upNlLU6b7DH3ISBcFKwdCIl 5BGHQhyd/0UXSej4uAj8PLVxqyr4+f4g9SMBdprDB5K9oumxP0Hx+6W5CykPsCqG9s DvnLz36pu+Udw5O6VgNjeX0DP5FuiR3YRo95RRCz5/Q1AOOW+u/o21/R4TDXLW5hCQ ii3EDONQ57/SQ==
To: Daniel Gröber <dxld@darkboxed.org>
Cc: Juliusz Chroboczek <jch@irif.fr>, babel-users@alioth-lists.debian.net, babel@ietf.org
In-Reply-To: <20220513220119.lmwxg2dr5jon36zr@House>
References: <20220505085059.mxbt3ssvryxw4doh@House> <87ilqj52bz.fsf@toke.dk> <20220506034354.kpj3rwkyw7rj2oe3@House> <874k233pwi.fsf@toke.dk> <87mtfufmet.wl-jch@irif.fr> <87wney1aw7.fsf@toke.dk> <87czgqfb6m.wl-jch@irif.fr> <87sfpl1t9g.fsf@toke.dk> <87v8uhqykw.wl-jch@irif.fr> <8735hj23pq.fsf@toke.dk> <20220513220119.lmwxg2dr5jon36zr@House>
Date: Sat, 14 May 2022 00:37:16 +0200
X-Clacks-Overhead: GNU Terry Pratchett
Message-ID: <87o801awkj.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/6eExR9vQty4H_0mLYrL6K2b6PNs>
Subject: Re: [babel] [Babel-users] Babel MAC auth fails due to packet reordering
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 13 May 2022 22:37:26 -0000

Daniel Gröber <dxld@darkboxed.org> writes:

> Hi Toke,
>
> after running with your patch for a short while I'm actually starting to
> see frequent crashes. Here's a backtrace for one:

Ah, oops; looks like I got my operator precedence wrong, so the code is
doing pointer arithmetic instead of adding to the value being pointed
to...

Pushed a fixed version here:
https://github.com/tohojo/bird/tree/babel-ooo-pc

Could you try if that works better, please? :)

-Toke

v2.23.0 | Report a Bug | By Email