Re: [babel] I-D Action: draft-ietf-babel-information-model-08.txt

[Juliusz Chroboczek <[e-mail]>]

# Section 1.

"one of these security mechanisms" -> "one or both of these security mechanisms"

"(contingent on a management protocol with Babel support being implemented)"
I don't know what this means

"a referential [...] structure."  I don't know what this means

# Section 3.2

"Default is ff02:0:0:0:0:0:1:6".  Why not write this as ff02::1:6, as is usual?

# Section 3.3

The metric computation algorithm is described twice, here and globally in
the babel-information-obj.  Is the global value a default for newly
created interfaces, or does it provide a value in case the interface-obj
doesn't specify it?  Please clarify.

The same goes for babel-hmac-algorithm.

# Section 3.4

Aren't we missing an entry for the total number of packets sent?

Should these entries be optional?

# Section 3.5

I don't think that the nbr-stats entries is useful.  A neighbour is
a transient data structure, and neighbours get destroyed when they become
unreachable.  Thus, there is no good place to persist the statistics.
I suggest moving all statistics into the interface-obj, and not keeping
per-neighbour stats.

babel-exp-{m,u}cast-hello-seqno: the use of 0 for undefined is not a good
idea, since 0 is a perfectly valid seqno.

babel-ucast-hello-seqno: what's the value when the implementation is not
sending unicast hellos?

babel-cost: this is written in a different style.  I suggest something
like "the link cost, as computed from...".

# Section 3.6

See above.  I suggest moving this into the interface-stats object, and
only keeping aggregate statistics.

# Section 3.7

babel-route-router-id: suggst "the router-id of the router that originated
this route".

# Section 3.9

babel-key-use-{sign, verify}: good idea, I'll add this to the implementation.

babel-hmac-test: why non-empty?