Re: [babel] MAC auth. for Babel in babeld

Antonin Décimo <antonin.decimo@gmail.com> Fri, 28 August 2020 22:46 UTC

Return-Path: <antonin.decimo@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06D293A0D5F for <babel@ietfa.amsl.com>; Fri, 28 Aug 2020 15:46:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XDiq5VVcRjT7 for <babel@ietfa.amsl.com>; Fri, 28 Aug 2020 15:46:19 -0700 (PDT)
Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76CF33A07F2 for <babel@ietf.org>; Fri, 28 Aug 2020 15:46:19 -0700 (PDT)
Received: by mail-wr1-x42b.google.com with SMTP id c18so524020wrm.9 for <babel@ietf.org>; Fri, 28 Aug 2020 15:46:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:cc:subject:from:to:date :message-id:in-reply-to; bh=S1V7jGbjF83H5CY+JDzne9GEZ1gqYkgPwcntNPlXK14=; b=MFqJjhrodgPoPKSku4OQX8IcWNWCPtF7tUDf3bkiByII7AuHmvb7rJT9ym0+KHNQWM TC/O4IqhIEVogd2bu0XDki3BgrqhBzui2Uy3v2ds/TuQ0sbLaztMWpbkioBMd6UWDpeC 2s0tAnICUHNG5lX4reKka8r4vhlXnNV303WjDWP7pgRGMwrqIe8pcPKHEOKE6ggCMjZW DdVCReK3fYuPQtVXUTqS9xB7qFKZpg/y6TBw7HVYVzNSMAZ3oa0IuO7eLEbjRhUXApui ukawe0QAMaert5tgqK0ADHoZek53Mjfypvxk9LiId3WGhDN7EWYesiUvp6vBeJoOVPbs RjpA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:cc :subject:from:to:date:message-id:in-reply-to; bh=S1V7jGbjF83H5CY+JDzne9GEZ1gqYkgPwcntNPlXK14=; b=KLPcs069gWcV58nzPcM/6p0XepPKPZfJc/Dem4cwrE4pKgJuaHkPqHlyRZa9jbCnod ngVUBKANJUOhZJzS0qVX1lwsj35J8Jv/GHPqC783/qhCkS0SR4zESlTJz397GBMDsmGG QwGLIpO/wBDR1iUupDFuGSfIYzX1O/6pIZqHh2L72uCgBpDroJTxGuPYSMiXe1xn27US M67PvwZ10FrsNwoHabOgyKu32BGJ9LSooSSP1UZSVVO28eLxMr/7042zXkZVnyvLXRxE KkeBEsaObzdNlovNZmCtszm8kgsYZMYBGbdakpJ/oFpXmOYfMDnfPZlX8tk1Kadn1IwX tf+Q==
X-Gm-Message-State: AOAM530/5mR4AHMU554R6Rk8a+/RH36RUPOOBi0c2dXHERKXmo3FCyZT p4gw2L78GuvoqeOSTF4WYzo=
X-Google-Smtp-Source: ABdhPJxhIJcKPVbd5sBUwZl7EUzyw/D5wDx97/cje8XNt4fNSy754pv2H7OdSBtI12+Dr/z0hEYS+g==
X-Received: by 2002:adf:a3c9:: with SMTP id m9mr1014448wrb.80.1598654777870; Fri, 28 Aug 2020 15:46:17 -0700 (PDT)
Received: from localhost (176-190-174-144.abo.bbox.fr. [176.190.174.144]) by smtp.gmail.com with ESMTPSA id x2sm1280601wrg.73.2020.08.28.15.46.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2020 15:46:17 -0700 (PDT)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Cc: Babel at IETF <babel@ietf.org>, babel-users <babel-users@lists.alioth.debian.org>
From: Antonin Décimo <antonin.decimo@gmail.com>
To: Juliusz Chroboczek <jch@irif.fr>
Date: Fri, 28 Aug 2020 22:41:11 +0200
Message-Id: <C58X5TPHZWLM.2X332UIGN9351@kobain>
In-Reply-To: <871rjsmdt7.wl-jch@irif.fr>
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/YRhoqA88M0WhWo3FFAyVmuazzxY>
Subject: Re: [babel] MAC auth. for Babel in babeld
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Aug 2020 22:46:21 -0000

Another thing that could be added: a separate table for uncompleted
challenges (see en paragraph of section 7).


> > There is one feature that I have not implemented (yet): expiring
> > per-neighbour state (section 4.4) using the Hello history or a timer
> > based on the last accepted packet.
>
> Yes, you have :-)

Well that’s a relief!

> Please find out if you're allowed to enter the office (not obvious
> due to COVID). If not, I'll ask the boss for permission, or else
> we'll meet at my place.

You’ll have to invite me to allow me to enter the premises 🧛

> > I’m also looking for feedback on the user interface.  [...]  In
> > particular, do you think that implementing keysets and allowing an
> > unbounded number of keys is too much for babeld?
>
> As a general rule, I'm in favour of reflecting the implementation
> details in the user interface to the extent possible -- if you don't
> do that, the interface becomes confusing to the user who cannot
> build an accurate mental model of what's going on.

After some failed attemps, I had started the other way around and
designed the most complete user interfacte I could think of, and then
build the implementation to match that model.

>  If that's too complicated, I'd rather we add some macros than dumb
> down the interface. (Commands that expand to a sequence of
> lower-level commands.)

Hmm, nice idea. We could have a single keyset of two key slots, shared
by all interfaces, with the simplest user interface. We can have a
pre-configured timer for key rotation during which both keys would be
available.

    interface default mac true
    rotate-key hmac-sha256 0000
    …
    rotate-key hmac-sha256 1111

It’s not clear right now how the 'complete' and the 'simple' interface
could be used in the same time, but that is absolutely workable.

> You should consider what happens to your code when there are too many
> keys, and the MACs no longer fit in a packet. A silent failure would be
> bad.

The packet is not send. There are two error messages. The buffer is
discarded.

-- Antonin