Re: [babel] Rtgdir early review of draft-ietf-babel-source-specific-01

Juliusz Chroboczek <jch@irif.fr> Thu, 09 November 2017 22:40 UTC

Return-Path: <jch@irif.fr>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 605F71279EB for <babel@ietfa.amsl.com>; Thu, 9 Nov 2017 14:40:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9X7_Nn0hsX0T for <babel@ietfa.amsl.com>; Thu, 9 Nov 2017 14:40:46 -0800 (PST)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEEDF127863 for <babel@ietf.org>; Thu, 9 Nov 2017 14:40:45 -0800 (PST)
Received: from potemkin.univ-paris7.fr (potemkin.univ-paris7.fr [IPv6:2001:660:3301:8000::1:1]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/75695) with ESMTP id vA9MeihC027409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 9 Nov 2017 23:40:44 +0100
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by potemkin.univ-paris7.fr (8.14.4/8.14.4/relay2/75695) with ESMTP id vA9Mei9S019813; Thu, 9 Nov 2017 23:40:44 +0100
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 2AC0AEB217; Thu, 9 Nov 2017 23:40:44 +0100 (CET)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id UkpdEhMowhWU; Thu, 9 Nov 2017 23:40:43 +0100 (CET)
Received: from trurl.irif.fr (unknown [78.194.40.74]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 1907DEB216; Thu, 9 Nov 2017 23:40:43 +0100 (CET)
Date: Thu, 09 Nov 2017 23:40:42 +0100
Message-ID: <8760ajqdn9.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: Denis Ovsienko <denis@ovsienko.info>
Cc: Babel at IETF <babel@ietf.org>
In-Reply-To: <15fa1bb81d7.109d24d1b49274.2604017698454390895@ovsienko.info>
References: <150983039829.26601.3109842491855567125@ietfa.amsl.com> <5FA8E8AC-6BBB-45D0-BDF6-2241179A5477@irif.fr> <15fa0994c65.ebeea8bf36247.925065931701393093@ovsienko.info> <437846EA-91C2-419B-AC9F-04D88C9C43D7@irif.fr> <15fa1bb81d7.109d24d1b49274.2604017698454390895@ovsienko.info>
User-Agent: Wanderlust/2.15.9
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]); Thu, 09 Nov 2017 23:40:44 +0100 (CET)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (potemkin.univ-paris7.fr [194.254.61.141]); Thu, 09 Nov 2017 23:40:44 +0100 (CET)
X-Miltered: at korolev with ID 5A04D96C.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-Miltered: at potemkin with ID 5A04D96C.000 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 5A04D96C.000 from potemkin.univ-paris7.fr/potemkin.univ-paris7.fr/null/potemkin.univ-paris7.fr/<jch@irif.fr>
X-j-chkmail-Enveloppe: 5A04D96C.000 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 5A04D96C.000 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Score: MSGID : 5A04D96C.000 on potemkin.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/h91Uw_mmRi5W0lthCx3ZcWJ_oFg>
Subject: Re: [babel] Rtgdir early review of draft-ietf-babel-source-specific-01
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Nov 2017 22:40:47 -0000

> As far as protocol encoding semantics could go, more than one source
> prefix sub-TLV per one destination prefix TLV could mean the destination
> is the same in every resulting source-destination pair -- a simple form
> of compression.

Smart idea, but for the sake of simplicity I'd prefer we go with Joel's
suggestion.  (SHOULD silently drop.)

>    An Update TLV advertises or retracts a route.  As an optimisation, it
>    can optionally have the side effect of establishing a new implied
>    router-id and a new default prefix.

> In this sense, if the instance skips a malformed Update TLV that was
> intended to establish the implied values, would it be right to skip
> subsequent TLVs because those depend on the implied values? Does this
> stand for both the basic protocol and the source-specific extension?

Please see 6126bis Section 4.5.  I think that an Update with multiple
source-specific sub-TLVs should behave just like an Update with an unknown
mandatory sub-TLV: it should establish the parser state, and only then be
dropped.  In other words, checking for duplicate sub-TLVs should happen
after parsing, not during parsing.

> Perhaps it would be useful to have a fail-safe statement about known
> (but malformed) TLV types handling in general (not just Update).

Yes, that makes sense.  I'm waiting for Susan's review before I make any
updates to the text.

> And a closely related point: given a series of properly formed Update
> TLVs, if one TLV wants to establish the implied values but the protocol
> instance considers the update unfeasible, does it still modify the
> implied values?

Yes.  Unfeasible updates are parsed and processed normally, they are
avoided much later (Sections 3.5 and 3.6.)

-- Juliusz