Re: [bess] Chair review of draft-ietf-bess-evpn-mh-pa-08

slitkows.ietf@gmail.com Wed, 18 October 2023 19:34 UTC

Return-Path: <slitkows.ietf@gmail.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EB46C151553; Wed, 18 Oct 2023 12:34:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lFOfONulBuIM; Wed, 18 Oct 2023 12:34:55 -0700 (PDT)
Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E3F2C151547; Wed, 18 Oct 2023 12:34:52 -0700 (PDT)
Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-d9c2420e417so3312450276.2; Wed, 18 Oct 2023 12:34:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697657691; x=1698262491; darn=ietf.org; h=content-language:thread-index:mime-version:message-id:date:subject :in-reply-to:references:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5IAX6NL3Mrfyy6NcpQhkRaZezSLoG1EoqmmPgaIzS4U=; b=jzbwKqRmYcFrcfKjaDhP7q/Bf+ikLrg18X9VqXkPnIaG8mBSnxvLXPKJ55jX02cXRS QgEwngKpXO9MnoagFm2FGSxQuyQ3QQ2cE0xrc4OrkOCrbAM3u1EBKES/CXCERxhFvv1M UAVCuWlwl+ypPBXX/G+ykci8/uGWuyan6OGRgaLVIK3/6CqYLRmA/OQKBorrahpJ39G2 szxk0pE132CCxlhBetMw90xGETLzGlQS+75si0N9yHTxFrd06oKM3Xatbdj2Ysn+/XvD V2OwV1FwgZ4yK/sU5SxQuqc8m9/uO2Ozz44/bI8y6HPNIUNTOH5Qbv/0E/aAqKFvedRj uPIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697657691; x=1698262491; h=content-language:thread-index:mime-version:message-id:date:subject :in-reply-to:references:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5IAX6NL3Mrfyy6NcpQhkRaZezSLoG1EoqmmPgaIzS4U=; b=Qz8ZQJKZfreVbVho2IXbs4UApYMvGYLckzylvOcIAXHMsAELqzZiheALBiaNpdGfpE dLftBrgp3fxRpFfTMZr4jFhcM4g4pcy61XID8Bx/F/wLHlL0XJqVpzSoJmz5l2Y8EnIu 2/zbyGbG7ECc412bYFt9+1ceWt0ndls3VjCreGpIKiSiw/0vYFku9jDW6F85eBnSdGx8 xMzWo9zFLDUUYnjQUSHMzifO561HwvAHgyH8dtBsk6WrBnFX3mqwiMW+16rcmq2l4TEf fFk2hWa2yfflVKrOgLhEAVvdSKavfwgS2866qgGpq7M9ynfJ7B47ONx1FlaYtnjwIwh8 QwVA==
X-Gm-Message-State: AOJu0YwQdARRr1bo+CfCKZ7ohe2h7+GH6d/lOehvoK6jJZLit5B0Rfvj UIAu7TYgWoNrRcxcYGw940Wc/SV8tg==
X-Google-Smtp-Source: AGHT+IG/65FWvZ0r2RbfcFxIYsdYPo7itezgqb5FjQUrnGuXtYgVbp7SMYJO4SSbplM4KcVCVmxXjw==
X-Received: by 2002:a25:ae4a:0:b0:d9a:3811:9c57 with SMTP id g10-20020a25ae4a000000b00d9a38119c57mr348193ybe.43.1697657691374; Wed, 18 Oct 2023 12:34:51 -0700 (PDT)
Received: from CSCOWPF2QW8Y3 ([173.38.220.49]) by smtp.gmail.com with ESMTPSA id d14-20020a5b0c4e000000b00d89679f6d22sm1481027ybr.64.2023.10.18.12.34.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2023 12:34:51 -0700 (PDT)
From: slitkows.ietf@gmail.com
To: "'Luc Andre Burdet (lburdet)'" <lburdet=40cisco.com@dmarc.ietf.org>, "'Stephane Litkowski (slitkows)'" <slitkows@cisco.com>, draft-ietf-bess-evpn-mh-pa@ietf.org
Cc: bess-chairs@ietf.org, bess@ietf.org
References: <SJ0PR11MB51369A1E5A54545B10C43DFFC2D5A@SJ0PR11MB5136.namprd11.prod.outlook.com> <DM6PR11MB3084C321F9D27471D1D5AABFBCD5A@DM6PR11MB3084.namprd11.prod.outlook.com>
In-Reply-To: <DM6PR11MB3084C321F9D27471D1D5AABFBCD5A@DM6PR11MB3084.namprd11.prod.outlook.com>
Date: Wed, 18 Oct 2023 21:34:46 +0200
Message-ID: <02f501da01fa$28cd5cd0$7a681670$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_02F6_01DA020A.EC584FB0"
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQD/HM56OsP7fvRRmCAJnZASokGnGQKqKh0+sfBpU0A=
Content-Language: fr
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/FXedzMic7F1P2-MB5R3eVlMSbtk>
Subject: Re: [bess] Chair review of draft-ietf-bess-evpn-mh-pa-08
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Oct 2023 19:34:56 -0000

I’m fine with changes.

 

Thanks

 

 

From: BESS <bess-bounces@ietf.org> On Behalf Of Luc Andre Burdet (lburdet)
Sent: Wednesday, October 18, 2023 7:31 PM
To: Stephane Litkowski (slitkows) <slitkows@cisco.com>;
draft-ietf-bess-evpn-mh-pa@ietf.org
Cc: bess-chairs@ietf.org; bess@ietf.org
Subject: Re: [bess] Chair review of draft-ietf-bess-evpn-mh-pa-08

 

Thanks Stéphane, I am uploading v09 shortly.

 

The missing references to i.e. LACP are actually in the MCLAG section and
some of the “first expansions” you mention also : I think the best solution
is to simply move Fig1 down into there.

 

Let me know what you think

 

Regards,

Luc André

 


Luc André Burdet  |  lburdet@cisco.com <mailto:lburdet@cisco.com>   |  Tel:
+1 613 254 4814

 

 

From: Stephane Litkowski (slitkows) <slitkows@cisco.com
<mailto:slitkows@cisco.com> >
Date: Wednesday, October 18, 2023 at 05:54
To: draft-ietf-bess-evpn-mh-pa@ietf.org
<mailto:draft-ietf-bess-evpn-mh-pa@ietf.org>
<draft-ietf-bess-evpn-mh-pa@ietf.org
<mailto:draft-ietf-bess-evpn-mh-pa@ietf.org> >
Cc: bess-chairs@ietf.org <mailto:bess-chairs@ietf.org>
<bess-chairs@ietf.org <mailto:bess-chairs@ietf.org> >, bess@ietf.org
<mailto:bess@ietf.org>  <bess@ietf.org <mailto:bess@ietf.org> >
Subject: Chair review of draft-ietf-bess-evpn-mh-pa-08

Hi,

 

Here is my last review (as WG chair) of the draft, I have also requested a
GEN-ART review.

 

 

Abstract:

Use “RFC7432” as a plain text reference and not as a link (xml xtarget) in
the abstract.

 

 

Introduction:

 

s/QOS/QoS/


I think this sentence is useless in the text as previous one already
mentions the same: 

“A new type of load-balancing mode,

   Port-Active redundancy, is defined. “

 

Need to expand MC-LAG on first use

 

Don’t you need to provide an informative reference for LACP ? you may need
to expand it on first use.

Also don’t need to say “LACP protocol” , but just say “LACP”, P=protocol.

 

s/aca tive/active

 

 

Section 2:

Refer to LACP and expansion should be intro, not here.

 

s/must synchronize… data among them/ must synchronize… data between them/

 

 

Not able to parse this properly:

“as are LAG misconfiguration and miswiring detection across
   peering PEs.”
 
 

Section 3.1:

 

s/QOS/QoS

 

Expand DF abbrev (first use)

 

Section 3.2:

 

I think the term “Peering PEs” is unclear and may need a better wording.

 

On Bullet d., it would be worth using some normative language regarding the
usage of DF election.

 

Bullet f. first sentence should use normative language IMO. “SHOULD by
default implement” ? or MUST ?

 

Should bullet g. use normative language ? Would it be a MAY (optional) or
SHOULD (if highly recommended) ?

 

 

Section 4:

s/ new Port Mode Load-Balancing capability/ new Port Mode Load-Balancing
capability bit
 
 

 

Section 4.4:

Add reference to pref-df-draft
 
 

Section 4.5:

Add reference to RFC8584