Re: [bess] Rtgdir last call review of draft-ietf-bess-evpn-df-election-framework-06

"Satya Mohanty (satyamoh)" <satyamoh@cisco.com> Fri, 07 December 2018 17:11 UTC

Return-Path: <satyamoh@cisco.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4291A130E6C; Fri, 7 Dec 2018 09:11:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.96
X-Spam-Level:
X-Spam-Status: No, score=-15.96 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dt8NekGj9lun; Fri, 7 Dec 2018 09:11:34 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 06244130DEC; Fri, 7 Dec 2018 09:11:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=10498; q=dns/txt; s=iport; t=1544202694; x=1545412294; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=y+dTQOAUO3F993GbcuQ99hOf6fhnKli/6nJ2kwiRr4g=; b=IPd5DoEmGnogQOkli9OymCQ5ALMzKiQkO7/ft5b+Ggl96av1v7on68O3 xp66kKWfVJzM5apeo64b9UTFdntCh55eSKYqPf1ILN7eBEyXou6Ur4+5P CkaIAS2s3FoSMLaslyqCO8xg+MgG//xMZ+LBzTCdgfhJVZczAyzA5cAe8 M=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ADAADBqApc/5tdJa1jGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAQGBUQQBAQEBAQsBgVopZoECJwqDcIgZi2Ewgg2XT4F6Awg?= =?us-ascii?q?BASWERwIXgwQiNAkNAQMBAQIBAQJtHAyFPQQCIxE0ERACAQgUBgImAgICMBU?= =?us-ascii?q?QAgQBDQUUgw0BQYFAD6QqBYExgS+ELQFQA4UtNFeIT4JIF4FAP4EQAScfgU5?= =?us-ascii?q?+gjZdCwEBAYFKFoMEMYImAok+lykJAocEikUYgVxNhEmDJ4cfiRCEcYpzAhE?= =?us-ascii?q?UgScfOIFVcBVlAYJBCYIeF38BAoJIhRSFP0ExARKKOoEfAQE?=
X-IronPort-AV: E=Sophos;i="5.56,326,1539648000"; d="scan'208";a="209840486"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2018 17:11:33 +0000
Received: from XCH-RTP-012.cisco.com (xch-rtp-012.cisco.com [64.101.220.152]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id wB7HBWuq002796 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 7 Dec 2018 17:11:33 GMT
Received: from xch-rtp-012.cisco.com (64.101.220.152) by XCH-RTP-012.cisco.com (64.101.220.152) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 7 Dec 2018 12:11:31 -0500
Received: from xch-rtp-012.cisco.com ([64.101.220.152]) by XCH-RTP-012.cisco.com ([64.101.220.152]) with mapi id 15.00.1395.000; Fri, 7 Dec 2018 12:11:31 -0500
From: "Satya Mohanty (satyamoh)" <satyamoh@cisco.com>
To: Adrian Farrel <adrian@olddog.co.uk>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>
CC: "draft-ietf-bess-evpn-df-election-framework.all@ietf.org" <draft-ietf-bess-evpn-df-election-framework.all@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Thread-Topic: Rtgdir last call review of draft-ietf-bess-evpn-df-election-framework-06
Thread-Index: AQHUjkBaTE3zadf04kOYxV/MIuvfAKVzUP8A
Date: Fri, 7 Dec 2018 17:11:31 +0000
Message-ID: <B65E51DB-82EE-42FD-8B51-094C2E55EA01@cisco.com>
References: <154419600663.20319.1134084541639124198@ietfa.amsl.com>
In-Reply-To: <154419600663.20319.1134084541639124198@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.47.200]
Content-Type: text/plain; charset="utf-8"
Content-ID: <24E793F1361E7042B4D53B0B3BB8A386@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 64.101.220.152, xch-rtp-012.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/Hcmrnar3j6etdNj-X1sumuiyrQA>
Subject: Re: [bess] Rtgdir last call review of draft-ietf-bess-evpn-df-election-framework-06
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Dec 2018 17:11:36 -0000

Hi Adrian,

Thank you very much for your detailed review and comments.
We will take care of all the nits that you have pointed out and include the reference to the IEEE/ACM TON paper (the link you have pointed out is indeed correct).

However, I had one query. Most of the time research journal/conference papers will be behind a paywall and there may not be a free cached copy available online.
How do we get across this problem?

Best,
--Satya

On 12/7/18, 7:20 AM, "Adrian Farrel" <adrian@olddog.co.uk> wrote:

    Reviewer: Adrian Farrel
    Review result: Has Nits
    
    Hello,
    I have been selected as the Routing Directorate reviewer for this draft. The
    Routing Directorate seeks to review all routing or routing-related drafts as
    they pass through IETF last call and IESG review, and sometimes on special
    request. The purpose of the review is to provide assistance to the Routing ADs.
    For more information about the Routing Directorate, please see
    ?http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments
    are primarily for the use of the Routing ADs, it would be helpful if you could
    consider them along with any other IETF Last Call comments that you receive,
    and strive to resolve them through discussion or by updating the draft.
    
    Document: draft-ietf-bess-evpn-df-election-framework-06.txt
    Reviewer: Adrian Farrel
    Review Date: 2018-12-07
    IETF LC End Date: 2018-12-18
    Intended Status: Standards Track
    
    Summary:
    
    This document is basically ready for publication, but has nits that should be
    considered prior to publication.
    
    Comments:
    
    This document addresses issues in the default election algorithm used for
    Designated Forwarder Election in EVPN (RFC 7432 and RFC 8124) by defining a new
    election algorithm and a capability to influence the election result for a
    VLAN, depending on the state of the associated Attachment Circuit.
    
    This is an exceptionally clear and well written document. The authors and the
    working group are to be congratulated.
    
    During my review I observed a number of small issues and editorial nits. I
    don't believe any of these is cause for discussion in the working group, but it
    would be sensible to resolve them before publication.
    
    Thanks and Happy Christmas,
    Adrian
    --
    It's Christmas.
    Buy someone you love a book of fairy tales.
    https://www.feedaread.com/profiles/8604/
    Available from your favourite online bookseller.
    Or contact me to receive a signed copy by mail.
    
    ===
    
    Major Issues:
     No major issues found
    
    ===
    
    Minor Issues:
    
    HRW1999 is provided as a normative reference, and from the text I can
    see why. But no URL (stable or otherwise) is given for the reference.
    Using my favorite search engine, I looked for and found a copy of
    the referenced document on the IEEE site behind a paywall. I don't
    think that will do at all. However, there is a version at
    https://www.microsoft.com/en-us/research/wp-content/uploads/2017/02/HRW98.pdf
    That appears to be dated 1998, but otherwise could be the same paper.
    
    ---
    
    When I read in Section 3...
    
       In addition, since the specification in EVPN
       [RFC7432] does leave several questions open as to the precise final
       state machine behavior of the DF election, section 3.1 describes
       precisely the intended behavior.
    
    ... I wondered whether this document is updating 7432 in that respect.
    
    Other features later in the document (such as section 5) confirm this.
    
    ---
    
    Notwithstanding the mention of backward compatiblity in section 6, I
    think it would be a good idea to include a very short section 3.2.1.
    
    3.2.1.  Backward Compatibility
    
       Legacy implementations (i.e., those that predate this specification)
       will not advertise the DF Election Extended Community.  That means
       that all other participating PEs will not receive DF preferences and
       will revert to the defailt algorithm without AC-Influenced DF
       Election.
    
       Similarly, a legacy implementation receiving a DF Election Extended
       Community will ignore it and will continue to use the default
       algorithm.
    
    ---
    
    On first reading, I missed an important subtlty in 3.2. The paragraph...
    
         - Otherwise if even a single advertisement for the type-4 route is
           not received with the locally configured DF Alg and capability,
           the default DF Election algorithm (modulus) algorithm MUST be
           used as in [RFC7432].
    
    ...is really important because it handles what to do if different
    participating PEs disagree about which algorithm to use.  Your text is
    perfectly fine and adequate, but the "locally configured" sort of hid
    it from me first time around.
    
    Maybe add a sentence to the end of the bullet point to say...
    
    "This procedure handles the case where participating PEs disagree about
    the DF algorithm and capability to apply."
    
    ---
    
    Section 4 introduces 8124 for the first time. It's good that this is
    applicable to private wire EVPN as well as 7432 EVPN. Maybe bring this
    into focus in the Introducion?
    
    It does make me wonder whether you are also updating 8124.
    
    ---
    
    I think section 7 is good. Since you note that the "unfair" situation
    may be created maliciously, should you note that there is also scope for
    a downgrade attach where the advertisement from one PE is hidden, the
    preferred algorithm is modified to any unexpected value, or any
    unexpected bit in the capabilities bitfield is set? I think such an
    attack assumes either a subversion of the PE (perhaps via its
    configuration) or modification of the BGP message. Thus, it is not a
    probable if adequate existing security mechanisms are used.
    
    ===
    
    Nits:
    
    The RFC Editor will require that the first section in the document is
    the Introduction.
    
    ---
    
    You use VNI and I-SID without expansion.
    
    ---
    
    2.1
    s/proposes/defines/
    
    ---
    
    2.3
    s/procedure Generally,/procedure.  Generally,/
    
    ---
    
    3.2 has
    
       For the DF election procedures to be consistent and unanimous, it is
       necessary that all the participating PEs agree on the DF Election
       algorithm and capabilities to be used.
    
    This is exactly the type of statement I was hoping for when I opened the
    document, so thanks. But... :-)
    
    This depends slightly on the definition of "all participating PEs". You
    don't need all PEs in the EVPN to use the same algorithm, only the PEs
    that share multi-homing connections.
    
    You also use the term in 2.1 and other places in the document, so
    perhaps I am worrying too much.
    
    ---
    
    4.
    s/the state of the server states/the server states./
    s/on Unix utilities rand and srand/on the Unix utilities rand and srand/
    
    ---
    
    I am not sure why you describe Wrand2 in section 4.2 because you
    immediately decide to not use it. Maybe you can just describe Wrand and
    observe that does the job?
    
    ---
    
    4.2
       s/HRW solves the disadvantage/HRW solves the disadvantages/