[bess] Lars Eggert's No Objection on draft-ietf-bess-mvpn-evpn-aggregation-label-12: (with COMMENT)

Lars Eggert via Datatracker <noreply@ietf.org> Tue, 03 October 2023 06:50 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: bess@ietf.org
Delivered-To: bess@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 8CEC4C14CEFF; Mon, 2 Oct 2023 23:50:26 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Lars Eggert via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-bess-mvpn-evpn-aggregation-label@ietf.org, bess-chairs@ietf.org, bess@ietf.org, slitkows.ietf@gmail.com, slitkows.ietf@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 11.12.1
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Lars Eggert <lars@eggert.org>
Message-ID: <169631582656.38533.14537897620895632425@ietfa.amsl.com>
Date: Mon, 02 Oct 2023 23:50:26 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/UvfCEfrcIfn9b5mcCvCEeXgWrF0>
Subject: [bess] Lars Eggert's No Objection on draft-ietf-bess-mvpn-evpn-aggregation-label-12: (with COMMENT)
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.39
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Oct 2023 06:50:26 -0000

Lars Eggert has entered the following ballot position for
draft-ietf-bess-mvpn-evpn-aggregation-label-12: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-bess-mvpn-evpn-aggregation-label/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-bess-mvpn-evpn-aggregation-label-12

CC @larseggert

Thanks to Russ Housley for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/3fAtK3w0wRrSeNCGgzBnr86jTRU).

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Grammar/style

#### Section 1, paragraph 14
```
onal label spaces is to be used to lookup the label, hence those label space
                                   ^^^^^^
```
The word "lookup" is a noun. The verb is spelled with a white space.

#### Section 1, paragraph 16
```
referred to as upstream-assigned. Otherwise it is downstream-assigned. An ups
                                  ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Otherwise".

#### Section 2.1, paragraph 5
```
VPN 1, and so forth. Now only 1000 label instead of 1,000,000 labels are nee
                                   ^^^^^
```
Possible agreement error. The noun "label" seems to be countable.

#### Section 2.2.1, paragraph 2
```
hen tunnel segmentation is applied to a S-PMSI, certain nodes are "segmentati
                                      ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 2.2.2.1, paragraph 1
```
 tunnel T2 and Flow-2 by tunnel T3. Then when the segmentation point receives
                                    ^^^^
```
Consider adding a comma here.

#### Section 2.2.2.1, paragraph 3
```
 labels for segmented S-PMSI independently from its assigned label block tha
                             ^^^^^^^^^^^^^^^^^^
```
The usual collocation for "independently" is "of", not "from". Did you mean
"independently of"?

#### Section 2.2.2.2, paragraph 1
```
-PMSIs for the same VPN/BD to share the a VPN/BD-identifying label that leads
                                    ^^^^^
```
Two determiners in a row. Choose either "the" or "a".

#### Section 3.2, paragraph 5
```
nel encapsulation of data packets arriving on the tunnel. * They MUST all hav
                                  ^^^^^^^^^^^
```
The usual preposition after "arriving" is "at", not "on". Did you mean
"arriving at"?

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool