Re: [bess] Shepherd's review of draft-ietf-bess-mvpn-fast-failover
Greg Mirsky <gregimirsky@gmail.com> Fri, 31 January 2020 21:41 UTC
Return-Path: <gregimirsky@gmail.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 44284120043; Fri, 31 Jan 2020 13:41:26 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.997
X-Spam-Level:
X-Spam-Status: No, score=-0.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wHYQ_ERDtaCG; Fri, 31 Jan 2020 13:41:24 -0800 (PST)
Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 45D8412004F; Fri, 31 Jan 2020 13:41:23 -0800 (PST)
Received: by mail-lj1-x22e.google.com with SMTP id y6so8633593lji.0; Fri, 31 Jan 2020 13:41:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w5ChG3X+nKXkDu9SSXGDx4gHSdTLIKvzQN7Qf6+/RpE=; b=fHNMjNjpkkzbDUgroZMsvbTaWCuRoS1pmgXvRe4hTMHhFAZidKc1xAInwFYcIDaNZ5 jdk7h/94YEBZqd8QxELhlp42RKy5DcymzSTZYlP/959qtm2Dyu0fQCHIqumO/TuomnV+ cscSIn3+IgajRcRC2B0XlNsZdT4kIAsaFRj0JKXHYQvk94LE1e1eCAmJ6mEtkF+8HwyM WMFdsiG1q+rIZ5OxI0c552oaul6z5tYiXmJLfS/dxShteh6FeXjkiFs8/CotzzMUDfRA JnWhKj4QwslMpoMuzwoP7rkBkv7SdkunlTCo7/jOWO85dqTzgDDrvuCEfPJsDE6gmMrW hFfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w5ChG3X+nKXkDu9SSXGDx4gHSdTLIKvzQN7Qf6+/RpE=; b=D4pfOzJStEda3zrRVxnOcJXxnzR+JKSHYtsqjrmS6jbkP9D1UoCbljYNEMQgXIaQKa /DUHB2j8GfXnxDkU1foPTMOXP14df6TKOd6Lal9W2/pa7iHiuW6D6iXf/bept9FfBQQm 6RaQwVyhf4DkhQ/OkRnij6hN9tFGdvXorL2tKGTaEgcXZL6qywN2Us+Iqn2kZ3UQ3jBR enTj7w+d51qqIVwFVCVBtUp6zJlMBz0LPlcDpX2v7xAeq0wmv1+NYOHzfxht2zbcs3E4 kSvPHJVyQMXyLXZyGztrhAElP6nPgD8/WYTtzsoKsnqTaa6sJJUikNwfjuSmibuMpPKL uooA==
X-Gm-Message-State: APjAAAVikevggO/ntQgvlBIBeri1Gb93D+Yf1seVk/v7StQ9FSTEro53 p97PJr6idiPdFFEvuWuDuUiJdD1qm6uun30oT8U=
X-Google-Smtp-Source: APXvYqyQwb4bqIUuELz+R4HVSdPnqL/SUrQDd6v/Tyws5L0BlmH2cI9LFSzxvkK21S/5wUoPxLPgVouzrx8ZOSBQO5k=
X-Received: by 2002:a2e:88c4:: with SMTP id a4mr7262420ljk.174.1580506880383; Fri, 31 Jan 2020 13:41:20 -0800 (PST)
MIME-Version: 1.0
References: <CA+RyBmWOYUnrzrb=M=dvHpn-huh_WFJURF0spOzX_752V0gkVg@mail.gmail.com> <04f301d5c4a0$6cd81690$468843b0$@gmail.com> <CA+RyBmVsFVz42sbPRF=oJ=wH-dVrZRaMgf+Kqr6ne5SO3HC0+Q@mail.gmail.com> <068e01d5c562$ad9cf7f0$08d6e7d0$@gmail.com> <CA+RyBmUQpVoGQkBcSuXOyf0YQx4PY2oi0z9Z05xtZjZUE-x5BA@mail.gmail.com> <MN2PR05MB5981F2CF3BB66DFD060C6EA2D4070@MN2PR05MB5981.namprd05.prod.outlook.com> <00c901d5d86f$8dd69f00$a983dd00$@gmail.com> <CA+RyBmWBxE_5VkoOR=FpCA0zAnuBYS3X9kYL=SSd1GCpRyMRGA@mail.gmail.com> <MN2PR05MB598164A5F0FD853F69C2A01BD4070@MN2PR05MB5981.namprd05.prod.outlook.com>
In-Reply-To: <MN2PR05MB598164A5F0FD853F69C2A01BD4070@MN2PR05MB5981.namprd05.prod.outlook.com>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Fri, 31 Jan 2020 13:41:09 -0800
Message-ID: <CA+RyBmVHurkbsZR7FRRT9bvznQ4YsqzttH91VKUTr=YNTTLXTA@mail.gmail.com>
To: "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>
Cc: "slitkows.ietf@gmail.com" <slitkows.ietf@gmail.com>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>, BESS <bess@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000002ba151059d766fe6"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/XzdHdLgxapLjDip6a6LooTnCajQ>
Subject: Re: [bess] Shepherd's review of draft-ietf-bess-mvpn-fast-failover
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jan 2020 21:41:26 -0000
Hi Jeffrey, my apologies, I misunderstood your proposed change. Should it be the following change: OLD TEXT The downstream PE can immediately update its UMH when the reachability condition changes. NEW TEXT As a result, the downstream PE can immediately update its UMH when the reachability condition changes. Thank you for your help. Regards, Greg On Fri, Jan 31, 2020 at 1:16 PM Jeffrey (Zhaohui) Zhang <zzhang@juniper.net> wrote: > In 3.1.4 you missed “as a result”. > > > > *From:* BESS <bess-bounces@ietf.org> *On Behalf Of * Greg Mirsky > *Sent:* Friday, January 31, 2020 3:55 PM > *To:* slitkows.ietf@gmail.com > *Cc:* Jeffrey (Zhaohui) Zhang <zzhang@juniper.net>; bess-chairs@ietf.org; > BESS <bess@ietf.org> > *Subject:* Re: [bess] Shepherd's review of > draft-ietf-bess-mvpn-fast-failover > > > > Hi Jeffrey, > > many thanks for your suggestions. I've updated the document accordingly. I > much appreciate you checking that changes are in the right places. I'll > upload the new version ones you approve the changes. > > > > Regards, > > Greg > > > > On Fri, Jan 31, 2020 at 11:49 AM <slitkows.ietf@gmail.com> wrote: > > I’m fine with the proposal > > > > > > *From:* Jeffrey (Zhaohui) Zhang <zzhang@juniper.net> > *Sent:* vendredi 31 janvier 2020 20:44 > *To:* Greg Mirsky <gregimirsky@gmail.com>; slitkows.ietf@gmail.com > *Cc:* BESS <bess@ietf.org>; bess-chairs@ietf.org > *Subject:* RE: Shepherd's review of draft-ietf-bess-mvpn-fast-failover > > > > Hi Greg, Stephane, > > > > The first MAY should actually be a SHOULD; for the second MAY, it actually > can go back to “can”. > > > > Then this will match the previous RSVP-TE section. The “in this case” > sentence is more about the result, not the action to take. Perhaps also > change “in this case” to “as a result” in both sections? > > > > Jeffrey > > > > *From:* Greg Mirsky <gregimirsky@gmail.com> > *Sent:* Wednesday, January 22, 2020 3:41 PM > *To:* slitkows.ietf@gmail.com; Jeffrey (Zhaohui) Zhang <zzhang@juniper.net > > > *Cc:* BESS <bess@ietf.org>; bess-chairs@ietf.org > *Subject:* Re: Shepherd's review of draft-ietf-bess-mvpn-fast-failover > > > > Hi Jeffrey, > > happy New Years (the Spring Festival is just upon us) and best wishes. > > Stephane suggested to ask you another, hopefully quick, review of the part > of this draft. Please see our discussion copied below: > > Section 3.1.4: > > As the document is standard track, could you introduce normative language > in the expected behavior description ? > GIM>> Updating to the normative language as follows: > > OLD TEXT: > > A PE can be removed from the UMH candidate list for a given (C-S, > C-G) if the P-tunnel (I or S, depending) for this (S, G) is leaf > triggered (PIM, mLDP), but for some reason internal to the protocol > the upstream one-hop branch of the tunnel from P to PE cannot be > built. In this case, the downstream PE can immediately update its > UMH when the reachability condition changes. > > NEW TEXT: > > A PE MAY be removed from the UMH candidate list for a given (C-S, > C-G) if the P-tunnel (I-PMSI or S-PMSI) for this (S, G) is leaf- > triggered (PIM, mLDP), but for some reason internal to the protocol > the upstream one-hop branch of the tunnel from P to PE cannot be > built. In this case, the downstream PE MAY immediately update its > UMH when the reachability condition changes. > > > [SLI] I understand the first “MAY” as optional feature, however the second > “MAY” is more a “SHOULD” IMO. Thoughts? > > GIM2>> Thank you for the clarification. The UMH list will certainly be > updated once the reachability of the downstream PE changes. In some > scenarios, such an update may be immediate, i.e., ASAP, but in some, it > might be better to delay it. Would you suggest adding a note about the > option to delay the update? > > > > [SLI] Could you check with Jeffrey Zhang on this point ? I’m not enough > expert here to tell what may be the best option. On my side, I just want > the text to be clear 😊 > > > > What do you think of the use of the normative language in the newly > updated text? > > > > Best regards, > > Greg > > > > On Tue, Jan 7, 2020 at 5:59 AM <slitkows.ietf@gmail.com> wrote: > > Hi Greg, > > > > More inline, > > > > > > *From:* Greg Mirsky <gregimirsky@gmail.com> > *Sent:* mercredi 4 décembre 2019 23:22 > *To:* slitkows.ietf@gmail.com; BESS <bess@ietf.org>; bess-chairs@ietf.org > *Subject:* RE: Shepherd's review of draft-ietf-bess-mvpn-fast-failover > > > > Hi Stephane, > > thank you for the review and your thoughtful comments. Please find my > answers and notes in-lined under GIM>> tag. > > Attached, please find the diff and copy of the working version. > > > > Regards, > > Greg > > > > Hi, > > > > Please find below my review of the document. > > > > Nits: > > > > > Section 3.1.1: > > As the document is standard track, could you introduce normative language > in the expected behavior description ? > > > > GIM2>> My apologies, I've pasted the same text twice. I propose to remove > "may be omitted" altogether. Hence the updated text: > > If BGP next-hop tracking is done for VPN routes and the root address > of a given tunnel happens to be the same as the next-hop address in > the BGP auto-discovery route advertising the tunnel, then the use of > this > > mechanism for the tunnel will not bring any specific benefit. > > Do you see this version without any normative language as acceptable? > > > > [SLI] Looks good thanks > > > > > > > Section 3.1.2: > > As the document is standard track, could you introduce normative language > in the expected behavior description ? > > > > “This method should not be used”. Wouldn’t this be a normative statement ? > > GIM>> Would the following modification of the text be acceptable: > > OLD TEXT: > > This method should not be used when there is a fast restoration > mechanism (such as MPLS FRR [RFC4090]) in place for the link. > > NEW TEXT: > Using this method when a fast restoration mechanism (such as MPLS FRR > [RFC4090]) is in place for the link requires careful consideration > and coordination of defect detection intervals for the link and the > tunnel. In many cases, it is not practical to use both methods at > the same time. > > > > [SLI] Are we strongly disencouraging the practice ? if yes, “it is not > practical” is a bit too soft. I’m wondering if “is NOT RECOMMENDED” could > be a good wording. But it is up to you. > > GIM2>> The use of OAM in multi-layer fashion is a question I'd be > interested to discuss. But I feel that it deserves a separate document and > would prefer to leave the text as a note of caution for now. > > > > [SLI] Ok > > > > > > Section 3.1.4: > > As the document is standard track, could you introduce normative language > in the expected behavior description ? > GIM>> Updating to the normative language as follows: > > OLD TEXT: > > A PE can be removed from the UMH candidate list for a given (C-S, > C-G) if the P-tunnel (I or S, depending) for this (S, G) is leaf > triggered (PIM, mLDP), but for some reason internal to the protocol > the upstream one-hop branch of the tunnel from P to PE cannot be > built. In this case, the downstream PE can immediately update its > UMH when the reachability condition changes. > > NEW TEXT: > > A PE MAY be removed from the UMH candidate list for a given (C-S, > C-G) if the P-tunnel (I-PMSI or S-PMSI) for this (S, G) is leaf- > triggered (PIM, mLDP), but for some reason internal to the protocol > the upstream one-hop branch of the tunnel from P to PE cannot be > built. In this case, the downstream PE MAY immediately update its > UMH when the reachability condition changes. > > > [SLI] I understand the first “MAY” as optional feature, however the second > “MAY” is more a “SHOULD” IMO. Thoughts? > > GIM2>> Thank you for the clarification. The UMH list will certainly be > updated once the reachability of the downstream PE changes. In some > scenarios, such an update may be immediate, i.e., ASAP, but in some, it > might be better to delay it. Would you suggest adding a note about the > option to delay the update? > > > > [SLI] Could you check with Jeffrey Zhang on this point ? I’m not enough > expert here to tell what may be the best option. On my side, I just want > the text to be clear 😊 > > > > > > > > > > > > Section 3.1.6: > > As the document is standard track, could you introduce normative language > in the expected behavior description ? > > GIM>> Sub-sections of 3.1..6 define the use of RFC 8562 and the new > attribute. In the introduction to these sub-sections, I propose s/can/MAY/ > > > >From a wider perspective, do you foresee other use case of signaling BFD > information in BGP ? I’m just wondering if we may need something > extensible for future use or not. > > GIM>> Great question. BGP, and I'm speculating here, may be used to for > other BFD-related scenarios. I think that we may use the Flags field. > [SLI] Is it enough or should you add some optional TLVs behind the > discriminator ? (with nothing defined yet). > > GIM2>> Great idea, thank you! Please see the updated figure and the text: > > 0 1 2 3 > 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | BFD Mode | Reserved | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | BFD Discriminator | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | Reserved TLV | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > > > Format of the BFD Discriminator Attribute > > Where: > > BFD Mode is the one octet long field. This specification defines > the P2MP value (TBA3) Section 7.1. > > Reserved field is three octets long and the value MUST be zeroed > on transmission and ignored on receipt. > > BFD Discriminator is four octets long field. > > Reserved TLV field is four octets long. It MAY be used for future > extensions of the BFD Discriminator Attribute using Type-Length- > Value format. This specification defines that the value in > Reserved TLV field MUST be zeroed on transmission and ignored on > > receipt. > > > > [SLI] If your field is 4-bytes long, it is not extensible, I was thinking > of options encoded as TLVs. > > If there is no TLV, the attribute ends on BFD discriminator, the attribute > length should tell if there are TLVs or not. > > > > 0 1 2 3 > 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | BFD Mode | Reserved | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | BFD Discriminator | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > | optional TLVs | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > Another point I have missed, you should define error handling procedures > for your attribute as per RFC7606. > > > > > > > > > > > > > > > > >
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… slitkows.ietf
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- [bess] Shepherd's review of draft-ietf-bess-mvpn-… slitkows.ietf
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… slitkows.ietf
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… slitkows.ietf
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Jeffrey (Zhaohui) Zhang
- Re: [bess] Shepherd's review of draft-ietf-bess-m… slitkows.ietf
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Jeffrey (Zhaohui) Zhang
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Jeffrey (Zhaohui) Zhang
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky
- Re: [bess] Shepherd's review of draft-ietf-bess-m… slitkows.ietf
- Re: [bess] Shepherd's review of draft-ietf-bess-m… Greg Mirsky