Re: [bess] Shepherd review of draft-ietf-bess-evpn-mh-split-horizon-05

"Jorge Rabadan (Nokia)" <jorge.rabadan@nokia.com> Mon, 23 October 2023 14:33 UTC

Return-Path: <jorge.rabadan@nokia.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D064FC16F3F1 for <bess@ietfa.amsl.com>; Mon, 23 Oct 2023 07:33:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=nokia.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Ca8-q4MOES1 for <bess@ietfa.amsl.com>; Mon, 23 Oct 2023 07:33:31 -0700 (PDT)
Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 10A52C16F3E1 for <bess@ietf.org>; Mon, 23 Oct 2023 07:33:09 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/Y4Pxnn8GxuKaUguGVCmmFys6TbMmsppya5RdvFTrjNM7TqzSTRKsSK/a+eCjuGwY5mXshGeUDSjJedhE6q7YJm5/OsG83wCx1VzsH5rIJ57GBJAdCJcDQqceu5Qb10D6kW8wxiSIc5xsoheHafCOCzHMNRubmjScnQZ6KwlODEoqL5spOz6g7m9esztoJ/Hg8EfuEqNoy3c7Nsr+AuGCG73OpyZ6IkGC6r4Hw1tumLlBD1yT1SH35VV5o/Dn8DSMJoRwLlBkZnfc32QgzVLkKGthQh/L3ZgYMHi6lY1TozbvlKhT+JPcW81CleOMph89owUdacYUcjqjk7CPzIjg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PH7DoWtj9IywQM7qouVZ9pTb83XHhKWMJdG1NAP13oU=; b=FEQ3G7Z06h37QpFJpY+MmtLmUhEVaT65YP1NeJiPTO+zeMeSARgwnijGX4IjslPF60PfGKjQWqEe2ALkQThMBwgLTZQEHv68zU62sOjAh7k78BVbD+ykv1Np8eTaO5JkkidBB+jeFIKhc+qNrsk7XHA7furA3bezFVDFSUkP5emMwih5j49ubeWeWmGirMjp8V959TnZxIgH6Y+s5OUUDF1IN/8x8JMKKnGWKWEO/juB0DOPhkiT7LZ5Wnaz+HJWR5W6kwokhWhYlBIxzSN5zrRgZ94sxJ1xJPmW3UgV1rOgUNpxvNfEBN3g2n5vS8cqGxILvuPmWUEQQEdXUEAXzA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PH7DoWtj9IywQM7qouVZ9pTb83XHhKWMJdG1NAP13oU=; b=iLPcRZHVStXkrs0lPJuGCeSRmhH6/DJXmRKDt5cfkkJzSTnPS2VDLCQVRGzwPAgDyc+SZ/z8KyoJnCKGSlywvZWagr+dl02M+kfvhrlo9LGy1q24+D+qKIYIEa75I3CbKTKmIRUZ+BSa6LVooW9rr6GmBQesr/j6Zj9hjNhv6sSN9sAKHH639Zd0+EnuChRC/fFBRH+Nr5Oj9e800/Mh/Q+Sf0cyQ+xuO9ZMxzxBhofkWcq8KCzdcjCB6O2aOamScWp1XTA8XrPMNHcysETJ+BWL9wL9ljyp3PEbAIBmGet0TBJ8tbaRgBnpv0+I/6r2XLX8+PA2HnJE1mWzTO5nWg==
Received: from DS0PR08MB9445.namprd08.prod.outlook.com (2603:10b6:8:1b7::10) by BY3PR08MB6994.namprd08.prod.outlook.com (2603:10b6:a03:364::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Mon, 23 Oct 2023 14:33:07 +0000
Received: from DS0PR08MB9445.namprd08.prod.outlook.com ([fe80::f036:f280:d5a9:ca7a]) by DS0PR08MB9445.namprd08.prod.outlook.com ([fe80::f036:f280:d5a9:ca7a%5]) with mapi id 15.20.6907.025; Mon, 23 Oct 2023 14:33:06 +0000
From: "Jorge Rabadan (Nokia)" <jorge.rabadan@nokia.com>
To: "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>, "Kiran Nagaraj (Nokia)" <kiran.nagaraj@nokia.com>, Wen Lin <wlin@juniper.net>, "'Ali Sajassi (sajassi)'" <sajassi@cisco.com>
CC: 'BESS' <bess@ietf.org>
Thread-Topic: Shepherd review of draft-ietf-bess-evpn-mh-split-horizon-05
Thread-Index: AdnxcV37qRP5dLZnS7Wqrp6XAE+TYwUQrvfD
Date: Mon, 23 Oct 2023 14:33:06 +0000
Message-ID: <DS0PR08MB9445C8FA0C8BD23DD5EED706F7D8A@DS0PR08MB9445.namprd08.prod.outlook.com>
References: <IA1PR05MB955077003CEC06204C4841FBD4C1A@IA1PR05MB9550.namprd05.prod.outlook.com>
In-Reply-To: <IA1PR05MB955077003CEC06204C4841FBD4C1A@IA1PR05MB9550.namprd05.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=True; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2023-09-27T18:34:37.0000000Z; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=0633b888-ae0d-4341-a75f-06e04137d755; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0; MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DS0PR08MB9445:EE_|BY3PR08MB6994:EE_
x-ms-office365-filtering-correlation-id: 850f621f-e09b-4cfe-ad7c-08dbd3d4f8ac
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: z1VjjJJ+FKW1TmVQ3zy/oJZEUQgmOSLAgAMmds5a1lR4bXacxMF9plwL9M46O/ylFeP60UwysBIAfb7jz+bSGqSyBF9u0fQxoqDOJDvSky2+rqSx029gXKKgv3Hgh02GjsIXtRPduLbOOFEYvm9N52/fW1zheBBPOoVLi3xEhm1mWpxJx1HECb6J4SjCS+T90pW24Ua/al1/Gir5+/Xs/SEKxitz8SwDUFAJtkSiOFjguhBe5cVBcipiAxSsAkqiWE4VU7EFTiTR5EyZCnwsVE76rEaAjGe9OQ4bQKT2YugN+q1tY4IaEbsN+jwNbFo5AJokQd6iK6vbakw8OKvsm97WDm4KQVRmC0b4+DZN2l10pI0U2wqmn2jd4z/4ewtLjj6TQyghOWrYBIX0cNB8rG0gFvHo89rAuBtm4qcjmMLFiSZx+qfFYW0hik/FOrNjSqSg+7oMv5VvB09ubMX+jc/wV6zOSKPJJg8ua/Bw47yNUvfzWi5qomw7RLUO8CP7ZFZn9selX4u9HkCI9i/W0Fmkqt4Z0pqYrZyYnoDSboAvlJi0+ueNBbzJKm9tU3xXWxPfSerk4Lw09A6pYv62X7YWGK18BbpV+BA22moVoIk=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR08MB9445.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(136003)(396003)(346002)(39860400002)(366004)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(7696005)(53546011)(9686003)(52536014)(6506007)(66946007)(66446008)(64756008)(66556008)(66476007)(316002)(76116006)(478600001)(5660300002)(8676002)(8936002)(4326008)(9326002)(110136005)(84970400001)(71200400001)(55016003)(38070700009)(41300700001)(2906002)(82960400001)(38100700002)(83380400001)(26005)(33656002)(122000001)(86362001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: Lm2Q2ZTs/5q0LBip6ZQCxIqr8c5o2Zs9s4vQpa4UDBZxsNc1w+7GjxUBz4nA50bp5gdLDggqTxxgyrokz8PFCu46XvRt3IjdKYbBBO35qB6DXBV7DLiowtiec6GGEea0+m8B4yDlO6lkoTXdjVI1/Gi6wqt0nEaMzHc+dAw/iRtVFhjQfriB40n+4dyFKn69G21jL9KWVKoYXokslL96XWsU46ooRgv1pEwdy4eigAgWrn2yBPN0MT0VUXClKMZXULOxbWDxNShV485idn59kk11Km9brFWngLbbpiELC7qY7airX34k5/x1Pbp+TbYmla5AnymydeutJ8zbaFV9Rkg87PnXKugOkZRbFG4aIJsTqmfUEDvJtKaaGaCc13Gu8ayLsQwPKAHyO3BoXMQuZPmcScQcZ3XGycGvGRSXNDtvRObgbY4jXMfBmJHiN8TJK5OUeLa4FEEFM6+i5jkUYaMrfZFnVZ4/kW6QeWeoTyNEEh/OMEcpOdUHhED6yG14SoVFLJj1l1iPz8CTLAzUM+hUQFa0XpdI9/Z7p/SDKX1SJvcGgUtdSW5ci5XxQKPeFBRaNi+Q52pwn0v/gcxa/qYmmNKxaLAYap5RRYowgHdcpQ1okAhR8LyNnZMRSYH3O3qZSIRjR1rmjSeUqyncxq8wt/CcsmcrKberA3YY6+XMm0HflClcnVBQHRP0IHoIwTX6LZkl4EZV1SRvepQtIjAYN8+DIXyrFeRkxAlQ69mXs6pGQuQ6AhGVpdp4+xwJRwxAgG4kyrZT5HY/c4ClALgSZxTCT2rPoEoq9kc6cMoPqXZiw6XZCEWdfhZefY0zFLNkX5b72gqVilToxgz8reEjOPbV8oTShHA05+z/GPBH0VRmhuT1IUPj+/GoXzbfO9AjsRMb9Ouv1Xrd/geXe6b0XutH4jI31BAMqbQnr20zzjKgoZX+eOPkxm7pOFdbdZsDHb09hMZrnpTcyK/Bk8MC/qrMUc3/ezG4COKrdVXOivAnYf2Sk6BglGFtEnLXumHl84R/bXMbN2p8LVXBQNKorDp+j5pwEmAtYcyQ2MlYIWpW9r49docastqiBAgi+wplzzRXu5u6wTujnJ8LKqclT5Bf4bk8Knnmj+zfTVU4dlLZao52Q6O3BZRpcxf25gX5tXJ4cxbUx6Ss0AcDVYQ9fJWfJWeYlRmcX+746pxBl1EBIRZgCsh6IqzomUU7ql5cK5gy/6NU9PmY7FsfNQ9qKa3fhLZpwjhDcWxw8xolXY7TPGUqH4H//Yut4MH1CQBuXpvJcH6pYXwfjiI3WeACSSjB46EJDMWwXPcbDnGD6Jx2F13CIrGYoSf4L/XGqLjHYz+4YqYDa4tnB6JEXg1CtEzOQG4FzSLRhrB5iF1dh2DF33Esg6bPCrZ8hsDDcYZF1ijEVpH7uGleS6yIUT/8V8eGtbRhYX7K7lkCgjaNooeqUFyd55OaCeLKFDVlwynOn+yhMeVFpDi6El4/35l7f7INme8XZqH7pEZUyHzds5fGq4t8klaLI6IHlyPAtYI8GUndUS9MTtUA+uOv1q61INhuyVrNwVr/Mp5p3buKGCxvOiUZQ6ybIwyA32AqxwwNEX8NNr2eKFOiq38fNQ==
Content-Type: multipart/alternative; boundary="_000_DS0PR08MB9445C8FA0C8BD23DD5EED706F7D8ADS0PR08MB9445namp_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR08MB9445.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 850f621f-e09b-4cfe-ad7c-08dbd3d4f8ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2023 14:33:06.1140 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C+VWquscB541zuJfbLOq1tSpG8Evf8bBL80pboRshzLtopc2wl/fzNfBkKAZ+/K3pjRS4F6ZCTekQoKo2a0gJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR08MB6994
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/lmbTjAza448XWhoLG-8XU6PGAoY>
Subject: Re: [bess] Shepherd review of draft-ietf-bess-evpn-mh-split-horizon-05
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Oct 2023 14:33:35 -0000

Hi Jeffrey,

Thanks very much for the review. Version 6 is published addressing your comments.

Please see in-line.

Thanks!
Jorge

From: Jeffrey (Zhaohui) Zhang <zzhang@juniper.net>
Date: Wednesday, September 27, 2023 at 5:34 PM
To: Jorge Rabadan (Nokia) <jorge.rabadan@nokia.com>, Kiran Nagaraj (Nokia) <kiran.nagaraj@nokia.com>, Wen Lin <wlin@juniper.net>, 'Ali Sajassi (sajassi)' <sajassi@cisco.com>
Cc: 'BESS' <bess@ietf.org>
Subject: Shepherd review of draft-ietf-bess-evpn-mh-split-horizon-05

CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



Hi,

I have the following comments/suggestions/questions:

Idnits reported:

  -- The draft header indicates that this document updates RFC8365, but the
     abstract doesn't seem to mention this, which it should.
[Jorge] good point. Added.


Would this update 7432 as well?
[Jorge] since 7432bis obsoletes 7432 and refers to this document, it is probably ok not to say it updates 7432… but I don’t have a strong opinion. It may depend on how fast 7432bis progresses as well?


  == Outdated reference: A later version (-06) exists of
     draft-ietf-bess-evpn-geneve-05

I normally don't reference a specific revision of a document, unless the revision number matters. If you remove the revision in the reference, you'll not need to worry about updating it again.
[Jorge] sure, done.


Given that this is ahead of rfc7432bis, the "EVPN ESI Multihoming Attributes" registry creation for the 1-octet Flags field in the ESI Label Extended Community should be moved to this draft.
[Jorge] As long as this document it is really ahead of 7432bis, sure. We added it to the IANA section, and we can always remove it if 7432bis goes out before this one.


"MPLS-based IP Tunnel" does not seem to be accurate to me. It should be "IP-based MPLS Tunnel". Related to that, the three tunnel types can be renamed to:

- IP-based MPLS Tunnel
- (SR-)MPLS Tunnel
- IP Tunnel

I don't think we need "group" in terms like "group MPLS-based IP" - it can simply be "IP-based MPLS".
[Jorge] ok, changed


There a few references like the following:

   [RFC9012] BGP Encapsulation extended community

I believe the reference should be put after the relevant text:

   BGP Encapsulation extended community [RFC9012]
[Jorge] ok, fixed.



Thanks.
Jeffrey

Juniper Business Use Only