[bess] RtgDir Early review: draft-ietf-bess-mvpn-msdp-sa-interoperation-00.txt

"Hejia (Jia)" <hejia@huawei.com> Tue, 17 April 2018 07:16 UTC

Return-Path: <hejia@huawei.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 664E212711E; Tue, 17 Apr 2018 00:16:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sBLcfJni92iU; Tue, 17 Apr 2018 00:16:36 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1DC981250B8; Tue, 17 Apr 2018 00:16:36 -0700 (PDT)
Received: from lhreml701-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 211DC2A1ADA0A; Tue, 17 Apr 2018 08:16:32 +0100 (IST)
Received: from DGGEMA406-HUB.china.huawei.com (10.3.20.47) by lhreml701-cah.china.huawei.com (10.201.108.42) with Microsoft SMTP Server (TLS) id 14.3.382.0; Tue, 17 Apr 2018 08:16:33 +0100
Received: from DGGEMA503-MBX.china.huawei.com ([169.254.1.5]) by DGGEMA406-HUB.china.huawei.com ([10.3.20.47]) with mapi id 14.03.0361.001; Tue, 17 Apr 2018 15:16:21 +0800
From: "Hejia (Jia)" <hejia@huawei.com>
To: "bess-chairs@ietf.org" <bess-chairs@ietf.org>, "draft-ietf-bess-mvpn-msdp-sa-interoperation.all@ietf.org" <draft-ietf-bess-mvpn-msdp-sa-interoperation.all@ietf.org>
CC: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Thread-Topic: RtgDir Early review: draft-ietf-bess-mvpn-msdp-sa-interoperation-00.txt
Thread-Index: AdPWG8zaoh7C+VioSLCYIrn+9cO1uQ==
Date: Tue, 17 Apr 2018 07:16:22 +0000
Message-ID: <735916399E11684EAF4EB4FB376B71955304528E@DGGEMA503-MBX.china.huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.57.113.123]
Content-Type: multipart/alternative; boundary="_000_735916399E11684EAF4EB4FB376B71955304528EDGGEMA503MBXchi_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/zHlb0XtBhQupPHdiFeX8T52BRts>
Subject: [bess] RtgDir Early review: draft-ietf-bess-mvpn-msdp-sa-interoperation-00.txt
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2018 07:16:38 -0000

Hello,

I have been selected to do a routing directorate “early” review of this draft.
https://datatracker.ietf.org/doc/draft-ietf-bess-mvpn-msdp-sa-interoperation/

The routing directorate will, on request from the working group chair, perform an “early” review of a draft before it is submitted for publication to the IESG. The early review can be performed at any time during the draft’s lifetime as a working group document. The purpose of the early review depends on the stage that the document has reached.

As this document has recently been adopted by the working group, my focus for the review is on providing a new perspective on the work, with the intention of catching any issues early on in the document's life cycle.

For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir


Document draft-ietf-bess-mvpn-msdp-sa-interoperation-00.txt
Reviewer: Jia He
Review Date: 16 April 2018
Intended Status: Standards Track

Summary
The document clearly describes the problem and specifies the MVPN/MSDP SA interoperation procedures. However, I have a minor concern that I think should be resolved before it is submitted to the IESG.

Comments
The current version of the draft lacks security considerations. Since the work in this draft is about interoperation between MVPN and MSDP, security considerations are need IMHO.

Nits:
1) Section 2, "...but [RFC6514] does not specify that it advertise MSDP SA messages to those MSDP peers... " , s/advertise/advertises
2) Section 2, "While MSDP Source Active routes contain the source, group and RP address of a given multicast flow,....", s/address/addresses


B.R.
Jia