Re: [Bier] AD review of draft-ietf-bier-mpls-encapsulation-08
Tony Przygienda <tonysietf@gmail.com> Tue, 26 September 2017 22:09 UTC
Return-Path: <tonysietf@gmail.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EDD2913449D; Tue, 26 Sep 2017 15:09:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EHIG0MPt6-ac; Tue, 26 Sep 2017 15:09:51 -0700 (PDT)
Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com [IPv6:2a00:1450:400c:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DFE5313306F; Tue, 26 Sep 2017 15:09:50 -0700 (PDT)
Received: by mail-wm0-x22a.google.com with SMTP id q124so12260436wmb.0; Tue, 26 Sep 2017 15:09:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zMrM5EjTN1sHb5P1rRJw90dQ3pzSPikYnIY8uRrIkHE=; b=tL95K9T5A7aP8V0wbeYnrQIbYV5nYNwNgGaxTpAVCKzPLpXee7g9X0N20DTC0Z7tcV VIF3xdKr1C5dUGoa6EIXim5jRRBjohb8U3kXyv1FQIyW6Stc/49PwA3YUA13LWh+q1BW XxEH7/dA11zUkgW/RP8JJUW7XgwxD753MEZdIAMwOrag74lGgfM8Z1yNRx2k7AO3+38u A9TUJb0EwbBc2ZgSjrSIfMVGM3H9N+NboMBsgB9uqZ7gsPJu3gMpb8XE281vGL62b3YZ YENanaB5hcITPjPfl/kPH4uZ++ww9tNfhQN3ZUvNTiViV+T3xGcY+2QhkJMuS64c2kSF xnpg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zMrM5EjTN1sHb5P1rRJw90dQ3pzSPikYnIY8uRrIkHE=; b=KY6UL5lpJbtQhYX9KNw+QNf5cGE5gmiewirnV1PwkRK813U9kAtLq2pVVfkOm3D3EM DmCmAgdssbQC3ux/wVM4+ODK56GKA5CF16blAl4PXor9S4tr3uc8soWwTjpg9ykZdc4p LBeFsQDLwooZhklhuxEVfCLKyJPrEWCCAkGX6A6Erw2G5vAVaIpUitQkNhMSIK9sn+YV eDcKwMqSLSqjUMVLjSLcd/aIBWS5uUEDegAtoVEMvzAAhxTHdLZLtKTvkCR3bPmylHRL Z7afgu1LCpckysn0CdabqjvbgFBtLX/DotNrkcS3F0vQgGmFfqWMF+4VN61b7AOFVLow 6Yqw==
X-Gm-Message-State: AHPjjUjDId6kDIf7uQGNS6O+BuzUlDoVcByMgQsVEy/TmoTNnAeFWjNI 3sDXuW3/2RdjX/ihOzzsamDrywIcMrFZFVe8wCI6YQ==
X-Google-Smtp-Source: AOwi7QDGErZYzM1V78mzemp76gUKuX/KdH5hNNiYlIKGhQORLC7+lfrQeMlq9RNtqMGSmdqYfAKM90R/HM/9okGTuro=
X-Received: by 10.80.206.73 with SMTP id k9mr19143110edj.145.1506463789335; Tue, 26 Sep 2017 15:09:49 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.80.140.187 with HTTP; Tue, 26 Sep 2017 15:09:09 -0700 (PDT)
In-Reply-To: <CAG4d1rdr1aGaeO9=dbD01RFAxdFAYh=35H6B4xuQu3VaGGMETw@mail.gmail.com>
References: <CAG4d1rdr1aGaeO9=dbD01RFAxdFAYh=35H6B4xuQu3VaGGMETw@mail.gmail.com>
From: Tony Przygienda <tonysietf@gmail.com>
Date: Tue, 26 Sep 2017 15:09:09 -0700
Message-ID: <CA+wi2hNA4kaXHuQ2wRJ2LGKFog6umaD=PTo99KgxbOE-qdGuZg@mail.gmail.com>
To: Alia Atlas <akatlas@gmail.com>
Cc: "bier@ietf.org" <bier@ietf.org>, draft-ietf-bier-mpls-encapsulation@ietf.org
Content-Type: multipart/alternative; boundary="f403045dbdfc07cb27055a1eef28"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/7Zx_ew3BXjOa7k0jSkQ2m8Lg2YE>
Subject: Re: [Bier] AD review of draft-ietf-bier-mpls-encapsulation-08
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Sep 2017 22:09:54 -0000
There is a -09 version pending where Eric already took care of all my nits in the shepherd writedown ... This can go in. My only observation here is that I'm confused ;-) since I assumed the EtherType is gated on architecture RFC and nothing else but if we want to request EtherType in this doc specifically I'm fine as well of course ... --- tony On Tue, Sep 26, 2017 at 2:05 PM, Alia Atlas <akatlas@gmail.com> wrote: > As is customary, I have done my AD review of draft-ietf-bier-mpls-encapsulation-08. > First, I would like to thank the authors & editors, Ice, Eric, Andrew, > Jeff, Sam, and Israel, as well as the WG for this solid document. > > I do have a couple major issues that need to be resolved ASAP so I can get > this document into IETF Last Call and scheduled for the telechat on Oct 26. > > Major: > > 1) First, this draft references draft-chen-ippm-coloring-based-ipfpm-framework-06 > for the only description of how the OAM bits are used. I think, based on a > very quick scan, that perhaps > draft-ietf-ippm-alt-mark-10 would work as well - but even that is > Experimental so would be a downref when this goes Standards Track. What > might be useful to say in this draft is: > > "'Specifying the values of the OAM bits or interpreting them is not done > by the BIER forwarding layer. Instead, an OAM layer can specify the value > to be used by a BFIR and process the received OAM values at a BFER. The > OAM bits MAY be set to any value by a BFIR; the OAM bits SHOULD NOT be > modified by BFRs as part of normal processing, unless instructed to by an > OAM process. The BFERs SHOULD provide a mechanism for reporting at least > the number of packets received in a row with each value. One example of > how such OAM bits can be used by different OAM processing is described in > [draft-ietf-ippm-alt-mark]." > > I'm sure it can be wordsmithed better. The key points are to define where > the OAM bits can be set, where they can be modified, and that packets > counts based on the values should be provided in some fashion. Then the > reference to what the OAM layer does can be informative. Regardless of the > reference type, this type of normative language is needed. > > 2) In Sec 2.2.3, it says: "Rather, a new ethertype would have to be > assigned and > used. Specification of the layer 2 codepoints to be used for the > non-MPLS BIER encapsulation is outside the scope of this document." > > I thought that this document is asking for a standard EtherType for the > non-MPLS BIER encapsulation?? Certainly, I need text like that to request > the allocation from IEEE. > Please be clear that this document is asking for an IEEE Ethertype to be > allocated, > if that is, as I understood, the WG's intent. > > Nit: > a) Sec 3 bullet 6a: s/BFIR's BFIR-id/BFIR's BFR-id > > Regards, > Alia > > _______________________________________________ > BIER mailing list > BIER@ietf.org > https://www.ietf.org/mailman/listinfo/bier > >
- [Bier] 答复: AD review of draft-ietf-bier-mpls-enca… Xiejingrong
- [Bier] 答复: 答复: AD review of draft-ietf-bier-mpls-… Xuxiaohu
- [Bier] 答复: AD review of draft-ietf-bier-mpls-enca… Xuxiaohu
- [Bier] AD review of draft-ietf-bier-mpls-encapsul… Alia Atlas
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Tony Przygienda
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Greg Mirsky
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Alia Atlas
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Alia Atlas
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Eric C Rosen
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Alia Atlas
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Tony Przygienda
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Eric C Rosen
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Alia Atlas
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Xiejingrong
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Tony Przygienda
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Xiejingrong
- Re: [Bier] AD review of draft-ietf-bier-mpls-enca… Eric C Rosen