Re: [Captive-portals] Genart last call review of draft-ietf-capport-api-07

Tommy Pauly <tpauly@apple.com> Fri, 08 May 2020 17:58 UTC

Return-Path: <tpauly@apple.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0741C3A0E92; Fri, 8 May 2020 10:58:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=apple.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jPmZJukfw5Gr; Fri, 8 May 2020 10:58:11 -0700 (PDT)
Received: from ma1-aaemail-dr-lapp01.apple.com (ma1-aaemail-dr-lapp01.apple.com [17.171.2.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0AFFE3A0E74; Fri, 8 May 2020 10:58:10 -0700 (PDT)
Received: from pps.filterd (ma1-aaemail-dr-lapp01.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp01.apple.com (8.16.0.42/8.16.0.42) with SMTP id 048HuNh5033043; Fri, 8 May 2020 10:58:08 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=20180706; bh=I0n0RMKBJHK0TYJQMdix0BLy/McxmgQOoO5mISI9AV4=; b=kYGrniG2n8gTNZS3DIHGmqo5LjTot/IpgAaF07UeKTiF7Ru4LRLuHnpbKBwPMAf/M0Cd YyqAi+JQ1fC9Xne7A7K1ITIbp2ayKK9h4zRlaedYILcSuO7IgCfWLqV3kQ8tG2fOqhR2 qYUC5NWpHDa1C9478EyRuNjuT7FIVzioYfKZ5BQ46ORhw3I8A58PJXvozIgabEq8F4RA Bo7BPIRhwTlPIahVYDIyxQemXtfZBAAhQulxyfNgnJ31qwN/eamyIKpZn1qXqYeFIyew pQkkJn8rY6nV4xdtHcRfhtIU6Y6OoTyr+p1C7k5atixOf4SWEd8194TiWIyGZA/3BsDw mA==
Received: from rn-mailsvcp-mta-lapp04.rno.apple.com (rn-mailsvcp-mta-lapp04.rno.apple.com [10.225.203.152]) by ma1-aaemail-dr-lapp01.apple.com with ESMTP id 30vtdqkk9r-9 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Fri, 08 May 2020 10:58:08 -0700
Received: from rn-mailsvcp-mmp-lapp04.rno.apple.com (rn-mailsvcp-mmp-lapp04.rno.apple.com [17.179.253.17]) by rn-mailsvcp-mta-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QA000GGCXWV94G0@rn-mailsvcp-mta-lapp04.rno.apple.com>; Fri, 08 May 2020 10:58:07 -0700 (PDT)
Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp04.rno.apple.com by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QA000300XB9EU00@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Fri, 08 May 2020 10:58:07 -0700 (PDT)
X-Va-A:
X-Va-T-CD: 3b08774d0891d2b54ec74cfa587472de
X-Va-E-CD: 2c3f0fd9294f35eaec40c438fc4b6ff8
X-Va-R-CD: 131238d0ea7ffc21f0f53de645b6a214
X-Va-CD: 0
X-Va-ID: b42d2471-faaf-4040-83df-7fdd5ed1163d
X-V-A:
X-V-T-CD: 3b08774d0891d2b54ec74cfa587472de
X-V-E-CD: 2c3f0fd9294f35eaec40c438fc4b6ff8
X-V-R-CD: 131238d0ea7ffc21f0f53de645b6a214
X-V-CD: 0
X-V-ID: 25fcae70-81af-4c7a-9385-b769214197b1
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-08_16:2020-05-08, 2020-05-08 signatures=0
Received: from [17.232.160.209] (unknown [17.232.160.209]) by rn-mailsvcp-mmp-lapp04.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QA000FDQXWUV000@rn-mailsvcp-mmp-lapp04.rno.apple.com>; Fri, 08 May 2020 10:58:07 -0700 (PDT)
Content-type: text/plain; charset=utf-8
MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.7.2.3\))
From: Tommy Pauly <tpauly@apple.com>
In-reply-to: <158856659566.16634.2637013886257923503@ietfa.amsl.com>
Date: Fri, 08 May 2020 10:58:06 -0700
Cc: gen-art@ietf.org, captive-portals@ietf.org, last-call@ietf.org, draft-ietf-capport-api.all@ietf.org
Content-transfer-encoding: quoted-printable
Message-id: <39C22CF4-19E2-4512-97CB-7E8B965467B0@apple.com>
References: <158856659566.16634.2637013886257923503@ietfa.amsl.com>
To: Brian Carpenter <brian.e.carpenter@gmail.com>
X-Mailer: Apple Mail (2.3608.80.7.2.3)
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-08_16:2020-05-08, 2020-05-08 signatures=0
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/0Ex9fSwhvHVx1LBR89hgiFC0jGk>
Subject: Re: [Captive-portals] Genart last call review of draft-ietf-capport-api-07
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 May 2020 17:58:13 -0000

Hi Brian,

Thanks for the review! I’ve updated our working copy to fix the nits you mention:

https://github.com/capport-wg/api/commit/a9d1dabf8b8b1e4275b98cc5d022d12bece97e70

> On May 3, 2020, at 9:29 PM, Brian Carpenter via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Brian Carpenter
> Review result: Ready with Nits
> 
> https://www.ietf.org/id/draft-ietf-capport-api-07.html
> 
> Gen-ART Last Call review of draft-ietf-capport-api-07
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-capport-api-07.html
> Reviewer: Brian Carpenter
> Review Date: 2020-05-04
> IETF LC End Date: 2020-05-11
> IESG Telechat date:  
> 
> Summary: Ready (almost...)
> --------
> 
> Minor Issue:
> ------------
> 
>>     If the client is captive (i.e. captive=true),
>>     it can still be allowed enough access for it to perform server
>>     authentication Section 4.1.
> 
> What does "can" mean? MAY or perhaps SHOULD? Is this a local policy decision?

Changed this to “will”. This does not need to be a normative claim here, as it is simply describing what the server deployment will do based on the referenced section.
> 
> Nit:
> ----
> 
>>     If the client is captive (i.e. captive=true),
>>     it can still be allowed enough access for it to perform server
>>     authentication Section 4.1.
> 
> Missing parentheses around "Section 4.1"?

Fixed!

Best,
Tommy