Re: [Captive-portals] Martin Duke's Discuss on draft-ietf-capport-architecture-08: (with DISCUSS and COMMENT)

Kyle Larose <kyle@agilicus.com> Tue, 09 June 2020 11:56 UTC

Return-Path: <kyle@agilicus.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 77A8C3A080E for <captive-portals@ietfa.amsl.com>; Tue, 9 Jun 2020 04:56:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=agilicus.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dfUGQKuNJIYE for <captive-portals@ietfa.amsl.com>; Tue, 9 Jun 2020 04:56:13 -0700 (PDT)
Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6FEE93A080C for <captive-portals@ietf.org>; Tue, 9 Jun 2020 04:56:13 -0700 (PDT)
Received: by mail-il1-x12e.google.com with SMTP id 9so19960442ilg.12 for <captive-portals@ietf.org>; Tue, 09 Jun 2020 04:56:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agilicus.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pmIDlGEvwfWVCud+VYrxC9Iz10SI6o0POGqjnQzmWdw=; b=mdxPAXBqgC5w0U9CG+09o73gW77YJrXlKzWl9/YgnMmZK5z+AUY1YsZXYf1GYlIIz0 8bdlpe3zCxE2GPg7lDSi6SmeaGKy2wOtsTcy1eJmKUEVVqKZND3IuxWh/OnqqNIWVV9H OPlREobvCU30D8YmnW7JeOWPgoApW3dMEtVLdZlQs9s4461WN4LuM0Y2/tFFXuI2Bdvq ap5x3c6dIBwlnFGnvLeCQuhbyH+0GJ/9ZHggU8yq43ef4NVC8FLaeSbqmP771xS4ABip quX9l6mPRE2vv021t7pkS4EpElMRSjGpdbrJpwygFn+Sxp3t8jKPmobRE8gxXA0RNRUO wPxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pmIDlGEvwfWVCud+VYrxC9Iz10SI6o0POGqjnQzmWdw=; b=MpwrDr5KDGI+4+czH8j4egLY+hWtC9zBxDfOgs+Yp/LXIvuzHsJ35t8o9bOd2g0yNM hvkrAPMabpfjB2K/RIRMIvHJO4vKJ4DahdNUD3ZUaIVBEUOycp63jxYo5ilEv5xlzDaR fOXnAmGJ5w/35SdK6HPCswae/qoIF/pdQTE3poRUDieQS4k9w1vMfgv9Hva8tnCV/IEb WXXbIrUKceXUT2VXdZZmpRfSmWD6JYS2nKcXMFYPlRrT3fRKpXMGSEMSG1XiLtoY5tuH KQaRxgnmG8Q/um9Kcht+yd/p+X7sqBBqibqTuXMCUjBDrLRzhrJMrlKyZf2y8ISFd7h8 4uKQ==
X-Gm-Message-State: AOAM532CHsij9M6Xo0fprfZyQP/+in0AtnDhxSe/dqRMEqDuzUdnsIei GfQHAvnQDQEu1gFSoFCgihRPx3bF68fXvvyp2B7s
X-Google-Smtp-Source: ABdhPJwX53djnp19sNMZOuBD0loAE5Qyn1Zqa9lVRcvEpW/T5vEfZZ8Smn82zVEXs2/5D9ZaUrm0AI41is4cgnpdmI4=
X-Received: by 2002:a05:6e02:4a7:: with SMTP id e7mr26320526ils.180.1591703772628; Tue, 09 Jun 2020 04:56:12 -0700 (PDT)
MIME-Version: 1.0
References: <159162878215.27666.15535605351295776647@ietfa.amsl.com>
In-Reply-To: <159162878215.27666.15535605351295776647@ietfa.amsl.com>
From: Kyle Larose <kyle@agilicus.com>
Date: Tue, 09 Jun 2020 07:56:02 -0400
Message-ID: <CACuvLgxu8U58YO10WRWBxsB8uqJwLQM-d8JQX7-DACj61OHRUw@mail.gmail.com>
To: Martin Duke <martin.h.duke@gmail.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-capport-architecture@ietf.org, capport-chairs@ietf.org, captive-portals <captive-portals@ietf.org>, Martin Thomson <mt@lowentropy.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/N_K6XHOFfBqXf1yMpQOBoT5V2oE>
Subject: Re: [Captive-portals] Martin Duke's Discuss on draft-ietf-capport-architecture-08: (with DISCUSS and COMMENT)
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jun 2020 11:56:16 -0000

Hi Martin,

Thanks again. I'll reply to the comment section with comments from the
earlier review for consistency.

Inline.

On Mon, 8 Jun 2020 at 11:07, Martin Duke via Datatracker
<noreply@ietf.org> wrote:
>
> Martin Duke has entered the following ballot position for
> draft-ietf-capport-architecture-08: Discuss
>

>
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
>
> Sec 2.3  says:
> At minimum, the API MUST provide: (1) the state of captivity and (2) a URI for
> the Captive Portal Server.
>
> But in section 5 of capport-api, user-portal-url is an optional field.
>
> Both a capport-api author and a WG chair agreed that the architecture doc
> should be fixed, so I'm moving the DISCUSS here.
>

I agree. We need to fix this in the architecture. Two suggestions were
proposed in the discussion on the API document.

- Require that the API be *able* to provide the URI
- Qualify the requirement to indicate when the URI is required (e.g.
when captive portal enforcement may be active).

I think I prefer the first option, since it's simpler. Does anyone
else have some input on this?

>
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
>
> I found the terminology around “Captive Portal API server” and “Captive Portal
> Server” to be a little confusing, as these are similar terms. The latter also
> doesn’t get its own discussion in Section 2 and is confusingly called the “web
> portal server” in Figure 1.

The Captive Portal API Server is the server hosting the Captive Portal
API. The Captive Portal Server is the server hosting the page(s) used
to communicate with the user visually via some form of client.

I think, given your comments in the API review, and of the other
working group members who commented there, that we should use Tommy's
suggestion of "User Portal" in place of Captive Portal Server. That
should hopefully remove any confusion caused by the similarity between
the two terms.

>
> After Figure 1, this seems to be consistently called the “web portal” (sec 2.6
> and 4). In the API doc it is called a "user portal." It would be great to unify
> the terminology across the documents as a whole.
>

I agree. That's a mistake; the document should be consistent. We'll fix that up.

>
>

Thanks!

Kyle