Re: [Captive-portals] Captive-Portal Identification in DHCP / RA draft-ietf-capport-rfc7710bis-03

Erik Kline <ek.ietf@gmail.com> Mon, 27 April 2020 23:01 UTC

Return-Path: <ek.ietf@gmail.com>
X-Original-To: captive-portals@ietfa.amsl.com
Delivered-To: captive-portals@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86EAC3A0D3C for <captive-portals@ietfa.amsl.com>; Mon, 27 Apr 2020 16:01:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6jZE1v7tSq7n for <captive-portals@ietfa.amsl.com>; Mon, 27 Apr 2020 16:01:16 -0700 (PDT)
Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BD6893A0D36 for <captive-portals@ietf.org>; Mon, 27 Apr 2020 16:01:16 -0700 (PDT)
Received: by mail-ot1-x333.google.com with SMTP id z17so29428303oto.4 for <captive-portals@ietf.org>; Mon, 27 Apr 2020 16:01:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kyk+EYVlXmbqXW77pTxrrCxBVjAxnX2HRkvnnkrh414=; b=ZtvZR+kRjz0ObXU/9omr4sl4nmySaJ0kRNu8OY3ZTWKZvicDCiMbzRMnB3oH/a9rvl 9tZNgTP8K0xH1BgCGU9lTXXM/6sgslYXtpuI2ePkXW9vroUp1cjt9zwyCuY69L4Jg6AD A8HBzvzHAGwW2c2fm3sPHDvqhi4lhOnEnpFLrS0+K7WOC56eO3CLbzWnu95qerAL/UV9 jMGe4+Gh7mfeUsIndK+sPtVQycaxbseAdP9tBlEZ1nwgjXhmVF0onYylNwO1FM4uSCll 0rHCFXAjS8kQ6lKl/WOOJVuPWW3PfgKVm6rTHqZuCNTZrt9TLa/yC1Ul1DhXtcZP/YTb WoWA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kyk+EYVlXmbqXW77pTxrrCxBVjAxnX2HRkvnnkrh414=; b=dK3SalnRmmaOMNCZT26iPvhad7PrRsXpP+ENKgEdwl2FwvA6vK2d8m5pGNRG7Dmkuy XTUTcS7tZ9l8Dlqli8roBrzuM6StEjXHDGk9VcE9M/SyImw1qcQUPCbm7UNkXItgygil v1hHOoRgCYvrFj1dp/o7v782/NfbG7Me/n+xdvhY/pZjyv5YIN0ceclGyn+BmaOskPwZ 4zDNGQ1VoMRtptDcJ9XZ6OFKOnbm4f4HVou/EQCBBzw/E4bpp72x0JJ9ZIrisODTMbJA A0Ned8xAxljnF8aPCcyluHSkU0UM6hffZiiTmHcA0Beb/qy6uptGOVOLzKtQ8BtnVfgJ NKMw==
X-Gm-Message-State: AGi0PubiK1y72hheE8MOqmZIQUN24B9E/qMha4+jWaGqm8sfjxdgzwkG wmvPd4E80tjZqkwITwgi5tj6UtIunpvOq7udBC377Q==
X-Google-Smtp-Source: APiQypKrh9mmMtqO/BDNfZkGX+ZBO62kpbKmUQuxUnWiS2sMKAiSczcbADqQgKX52tLJwEOrKkWyY1SmyU6EcC7kAVs=
X-Received: by 2002:a05:6830:1212:: with SMTP id r18mr3486567otp.144.1588028476007; Mon, 27 Apr 2020 16:01:16 -0700 (PDT)
MIME-Version: 1.0
References: <566F2FF8-6F5B-43F9-BB33-4D399013844E@commscope.com> <ae7991d5-9eed-4d91-aa43-9630401c21d4@www.fastmail.com>
In-Reply-To: <ae7991d5-9eed-4d91-aa43-9630401c21d4@www.fastmail.com>
From: Erik Kline <ek.ietf@gmail.com>
Date: Mon, 27 Apr 2020 16:01:05 -0700
Message-ID: <CAMGpriVOsYmjXt94uw7M3=iQqJvGhyyfXTf4uYwkwf3cB9uOUg@mail.gmail.com>
To: Martin Thomson <mt@lowentropy.net>
Cc: captive-portals <captive-portals@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000034a81c05a44db140"
Archived-At: <https://mailarchive.ietf.org/arch/msg/captive-portals/hQRok00cFiGJUnmmy8kfUcP1ylE>
Subject: Re: [Captive-portals] Captive-Portal Identification in DHCP / RA draft-ietf-capport-rfc7710bis-03
X-BeenThere: captive-portals@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion of issues related to captive portals <captive-portals.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/captive-portals/>
List-Post: <mailto:captive-portals@ietf.org>
List-Help: <mailto:captive-portals-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/captive-portals>, <mailto:captive-portals-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Apr 2020 23:01:19 -0000

And the 255 byte URI limit is mentioned in section 2 (~3rd paragraph).

I guess if someone wants longer URIs they have to move to an IPv6-only
network.  ;-)

On Mon, Apr 27, 2020 at 3:54 PM Martin Thomson <mt@lowentropy.net> wrote:

> Thanks for the input.  Apparently great minds think alike as another
> reviewer found the exact same shortcoming just days ago.  The next revision
> should have these fixed.
>
> On Tue, Apr 28, 2020, at 05:07, Tirupachur Comerica, Subash wrote:
> >
> > Hi,
> >
> > I was reviewing this draft and found a few missing text(sometimes
> > obvious) enumerated below(missing text in *_bold underline_*)
> >
> > Section 2.1 IPv4 DHCP Option
> >
> >  o Code: The Captive-Portal DHCPv4 option (TBD) (one octet).
> >
> >  o Len: The length, in octets of the URI.*_(one octet)_*
> >
> > Section 2.2: IPv6 DHCP Option
> >
> >  o option-code: The Captive-Portal DHCPv6 option (103) (two octets).
> >
> >  o option-len: The length, in octets of the URI.*_(two octets) --?
> > Please see question below_*
> >
> >  o URI: The contact URI for the captive portal that the user should
> >
> >  connect to (encoded following the rules in [RFC3986
> > <https://tools.ietf.org/html/rfc3986>]).
> >
> >
> > - *Question on the above option-len: If this is two octets in IPv6 DHCP
> > option, then the URI can be longer then 255. Option-len-value <=255,
> > correct?*
> >
> >
> > Section 2.3: The Captive-Portal IPv6 RA Option
> >
> >  o Type: 37*_(one octet)_*
> >
> >  o Length: 8-bit unsigned integer. The length of the option
> >
> >  (including the Type and Length fields) in units of 8 bytes.(*_one
> octet_*)
> >
> >  o URI: The contact URI for the captive portal that the user should
> >
> >  connect to. For the reasons described above, the implementer
> >
> >  might want to use an IP address literal instead of a DNS name.
> >
> >  This should be padded with NULL (0x0) to make the total option
> >
> >  length (including the Type and Length fields) a multiple of 8
> >
> >  bytes.
> >
> >
> > Thanks,
> >
> > Subash
> >
> >
> > _______________________________________________
> > Captive-portals mailing list
> > Captive-portals@ietf.org
> > https://www.ietf.org/mailman/listinfo/captive-portals
> >
>
> _______________________________________________
> Captive-portals mailing list
> Captive-portals@ietf.org
> https://www.ietf.org/mailman/listinfo/captive-portals
>