Re: [Cbor] Roman Danyliw's No Objection on draft-ietf-cbor-time-tag-11: (with COMMENT)

Carsten Bormann <cabo@tzi.org> Thu, 26 October 2023 15:13 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0A7CDC151086; Thu, 26 Oct 2023 08:13:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.906
X-Spam-Level:
X-Spam-Status: No, score=-1.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zwUirA6jsDlI; Thu, 26 Oct 2023 08:13:32 -0700 (PDT)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [IPv6:2001:638:708:32::21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5CCA6C151084; Thu, 26 Oct 2023 08:13:30 -0700 (PDT)
Received: from eduroam-pool10-182.wlan.uni-bremen.de (eduroam-pool10-182.wlan.uni-bremen.de [134.102.90.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4SGTnz706WzDCkv; Thu, 26 Oct 2023 17:13:27 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <169807400771.60097.6840152444442544033@ietfa.amsl.com>
Date: Thu, 26 Oct 2023 17:13:27 +0200
Cc: The IESG <iesg@ietf.org>, draft-ietf-cbor-time-tag@ietf.org, cbor-chairs@ietf.org, cbor@ietf.org, barryleiba@computer.org
X-Mao-Original-Outgoing-Id: 720026007.502336-36434d30bf1bbc2179c07d272d7c8783
Content-Transfer-Encoding: quoted-printable
Message-Id: <070C562F-FA98-4A36-BB70-895A50A1E6E4@tzi.org>
References: <169807400771.60097.6840152444442544033@ietfa.amsl.com>
To: Roman Danyliw <rdd@cert.org>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/jELZD09OxZSOspdcpHCEzz-qc2U>
Subject: Re: [Cbor] Roman Danyliw's No Objection on draft-ietf-cbor-time-tag-11: (with COMMENT)
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Oct 2023 15:13:35 -0000

Hi Roman,

thank you for this review.
Changes that should address these COMMENTS are in
https://github.com/cbor-wg/time-tag/pull/26

Details please see below.

Grüße, Carsten


> On Oct 23, 2023, at 17:13, Roman Danyliw via Datatracker <noreply@ietf.org> wrote:
> 
> Roman Danyliw has entered the following ballot position for
> draft-ietf-cbor-time-tag-11: No Objection
> ]
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-cbor-time-tag/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> ** Section 2.
>   For example, map keys could be registered for direct representations
>   of natural platform time formats.
> 
> What are “natural platform time formats”?

Something like the POSIX-Epoch-(1970-)based tv_sec/tv_nsec pair that UNIX uses (well, we cover that with keys 1/-9), or Windows’s 100-nanosecond intervals since January 1, 1601, which were in turn derived from VMS quadword time (100ns "ticks” since "Smithsonian Base Time”, i.e., 17-Nov-1858 00:00:00).  Java’s milliseconds from the POSIX Epoch has also been mentioned (which can already be covered employing key 4).

> ** Section 3.
>   The map must contain exactly one unsigned integer key that specifies
>   the "base time", and may also contain one or more negative integer or
>   text-string keys, which may encode supplementary information.
> 
> Should a normative MUST and MAY be used here?

Yes.

Now
3ad3548

> ** Section 8.
>   Time, of course, has significant security considerations; these
>   include the exploitation of ambiguities where time is security
>   relevant (e.g., for freshness or in a validity span) or the
>   disclosure of characteristics of the emitting system (e.g., time
>   zone, or clock resolution and wall clock offset).
> 
> Recommend citing the Security Considerations of
> draft-ietf-sedate-datetime-extended.  The text there covers a number of the
> topics mentioned above.

Yes.

Now
ab7edc7