[Cbor] Review of draft-bormann-cbor-cddl-control-01

Jim Schaad <ietf@augustcellars.com> Sun, 30 August 2020 02:58 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B4EE73A1396; Sat, 29 Aug 2020 19:58:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wvolrI6QQGXG; Sat, 29 Aug 2020 19:58:00 -0700 (PDT)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 319FF3A1392; Sat, 29 Aug 2020 19:57:57 -0700 (PDT)
Received: from Jude (73.180.8.170) by mail2.augustcellars.com (192.168.0.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 29 Aug 2020 19:57:50 -0700
From: Jim Schaad <ietf@augustcellars.com>
To: <draft-bormann-cbor-cddl-control@ietf.org>
CC: <cbor@ietf.org>
Date: Sat, 29 Aug 2020 19:57:48 -0700
Message-ID: <01b601d67e79$594d2960$0be77c20$@augustcellars.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 16.0
Content-Language: en-us
Thread-Index: AdZ+csWpRL6grQLsRCaGzhpYGtJ9gQ==
X-Originating-IP: [73.180.8.170]
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/jfKHVdzJ7B011ZAEVPmZGI-2Fc0>
Subject: [Cbor] Review of draft-bormann-cbor-cddl-control-01
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Aug 2020 02:58:02 -0000

A couple of comments on this document.  It is very possible that I have
already made this comments and they are on your to do list.

1.  Abstract needs to be expanded to identify what operators are in this
document.

2. Bikeshed topic - I don't really like the name of the .feature control.
The problem is that the definition of a feature is not at all clear from the
name of the control.  Among other things it does not say which extension
points are targeted.   I don't know that I have a good suggestion at this
point but something long the lines of .map-extensions is a much tighter
description of what is here.

3.  Section 2.1 - I just ran into a potential issue with RFC 8610 that is
highlighted here.    On my system I would expect the result to be b =
"foo\r\n  bar\r\n  baz\r\n".  Both "\n" and "\r\n" are considered as legal
inside of a byte string value and I did not find text to resolve it for the
non-hex/base64 case (where it is not relevant).  

4. Section 4 - Define behavior .feature is referenced outside of a map key.
Or are there other places where it can be used and thus these need to be
enumerated.

5. Acknowledgements - I think this does not read correctly as it says that I
suggested improvements on .feature rather than the document as a whole which
is what I think you meant to say.

6. Section 3 - The description says that following is legal, but does not
give a clue on what the correct behavior would be:

Value = text . abnf "full-date\n"

The text says that it is followed by zero or more rules, I would assume that
at least one rule would be required and the given target name must exist as
a rulename for a rule.  I think you might want to switch from element to
rulename in this text as well.  Element would allow for

Value = text .abnf "(WSP / CRLF WSP")


Jim