[CCAMP] 答复: YANG doctor review

Zhenghaomian <zhenghaomian@huawei.com> Wed, 20 November 2019 01:14 UTC

Return-Path: <zhenghaomian@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D9DA81208E2 for <ccamp@ietfa.amsl.com>; Tue, 19 Nov 2019 17:14:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wc88EQ-693hE for <ccamp@ietfa.amsl.com>; Tue, 19 Nov 2019 17:13:59 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [185.176.76.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7AC5E120116 for <ccamp@ietf.org>; Tue, 19 Nov 2019 17:13:59 -0800 (PST)
Received: from lhreml703-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id C708FEEB56FA2EA0FC07 for <ccamp@ietf.org>; Wed, 20 Nov 2019 01:13:56 +0000 (GMT)
Received: from DGGEML403-HUB.china.huawei.com (10.3.17.33) by lhreml703-cah.china.huawei.com (10.201.108.44) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Nov 2019 01:13:56 +0000
Received: from DGGEML511-MBX.china.huawei.com ([169.254.1.41]) by DGGEML403-HUB.china.huawei.com ([fe80::74d9:c659:fbec:21fa%31]) with mapi id 14.03.0439.000; Wed, 20 Nov 2019 09:13:51 +0800
From: Zhenghaomian <zhenghaomian@huawei.com>
To: tom petch <ietfc@btconnect.com>, "ccamp@ietf.org" <ccamp@ietf.org>
Thread-Topic: [CCAMP] YANG doctor review
Thread-Index: AdWZ99OXQJzjCZnnTAe4xaAXVMOEbwFR6fvA
Date: Wed, 20 Nov 2019 01:13:51 +0000
Message-ID: <E0C26CAA2504C84093A49B2CAC3261A43B8F0DE9@dggeml511-mbx.china.huawei.com>
References: <HE1PR0701MB22672662523D64EF02CE531FF0760@HE1PR0701MB2267.eurprd07.prod.outlook.com> <075401d59ed4$ff5036c0$4001a8c0@gateway.2wire.net> <000e01d59f0b$0dc26d00$4001a8c0@gateway.2wire.net>
In-Reply-To: <000e01d59f0b$0dc26d00$4001a8c0@gateway.2wire.net>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.52.35.63]
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/ADp8WZz76YM0L4AHneVJiQ1ANTM>
Subject: [CCAMP] =?gb2312?b?tPC4tDogIFlBTkcgZG9jdG9yIHJldmlldw==?=
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Nov 2019 01:14:02 -0000

Hi Mr. Petch, 

Thank you very much for the careful review and detailed comments. All the suggestions are noted and will be discussed with YANG doctors, after that we plan to address together with the comments from YANG doctor. 

Best wishes,
Haomian

-----邮件原件-----
发件人: CCAMP [mailto:ccamp-bounces@ietf.org] 代表 tom petch
发送时间: 2019年11月20日 2:57
收件人: tom petch <ietfc@btconnect.com>om>; ccamp@ietf.org
主题: Re: [CCAMP] YANG doctor review

Some more thoughts on layer0-types

The list in section 2.1 is quite long and I do not discern any underlying logic as to what order they might be in in which case, I suggest alphabetic within what kind of item they are, e.g.
2.1.1  typedef
2.1.2  identity
2.1.3. grouping

This would, for example, put the wson items together which at the moment they are not.

In passing, the I-D is inconsistent about what it is defining.
"common data types and groupings"
"data nodes and other data model objects"
"common Layer 0 TE types"
"YANG reusable types and groupings"
"typedef, identity and grouping statements"

Perhaps 'common Layer 0 YANG typedefs, identities and groupings'.

The order in the YANG module should match that of section 2.1

Also, the list mixes Capitals and lower case; since the corresponding YANG names are all lower case, then I think this section should be lower case.

The hyphenation is consistent, which is good.

Tom Petch

----- Original Message -----
From: "tom petch" <ietfc@btconnect.com>
Sent: Tuesday, November 19, 2019 12:29 PM

> Looking at layer0-types, as one who is not a YANG doctor, I see
>
> Introduction makes it clear that this is for optical layer0; Abstract 
> misses the work 'optical' which I think that it should include.
>
> Module references G.694.1 which I cannot see in the I-D references
>
> Generally, the YANG reference clauses are usually matched by
Normative,
> not Informative, references
>
> Where section 2.1 provides references for the types and groupings,
then
> I would see it as essential that those references appear as YANG 
> reference clauses for the types and groupings; most do not appear in
the
> YANG module e.g. for vendor identifier, wavelength assignment, layer0 
> grid type, term type, fec type etc etc
>
> If you think that a reference is needed in section 2.1, and I agree
with
> you that they are, then logically the same references must appear in
the
> YANG module since the YANG module is a stand-alone piece of text that 
> will be divorced from the rest of the I-D/RFC
>
> Tom Petch
>
> ----- Original Message -----
> From: "Daniele Ceccarelli"
> <daniele.ceccarelli=40ericsson.com@dmarc.ietf.org>
> To: <ccamp@ietf.org>
> Sent: Wednesday, November 13, 2019 7:56 AM
>
> > WG,
>
> >
> > We're requested the YANG doctor review of:
> >
> >  <https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer0-types/>
> > https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer0-types/
> >
> > https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer1-types/
> >
> > BR
> >
> >
> >
> > Daniele
> >
>
>
>
> ----------------------------------------------------------------------
--
> --------
>
>

_______________________________________________
CCAMP mailing list
CCAMP@ietf.org
https://www.ietf.org/mailman/listinfo/ccamp