Re: [CCAMP] Robert Wilton's Discuss on draft-ietf-ccamp-mw-topo-yang-10: (with DISCUSS and COMMENT)

[Scott Mansfield <[e-mail]>]

Thank you Rob,

Please see inline...
Delineated by <scott></scott>

----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

Hi,

Thanks for standardising another YANG model.  I'm balloting discuss because I
think that there is a small bug in the YANG module that needs to be fixed, but
otherwise I intend to move to Yes.

(1) p 10, sec 2.5.  Microwave Topology YANG Module

      augment "/nw:networks/nw:network/nw:node/tet:te"
           + "/tet:te-node-attributes" {
       when "/nw:networks/nw:network/nw:network-types"
          + "/tet:te-topology/mwt:mw-topology" {

I think that you probably need to change the when statement to a relative path,
otherwise it will be checking for any network having a microwave topology
rather that this network instance having a microwave topology.

<scott>
I will update this and validate all the examples and regenerate the trees.
</scott>

----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I also have a few non-blocking suggestions that may improve this document:

Minor level comments:

(2) p 16, sec Appendix A.  Microwave Topology Model with base topology models

    |  +--rw node* [node-id]
    |  |  +--rw node-id                   node-id
    |  |  +--rw supporting-node* [network-ref node-ref]
    |  |  |  +--rw network-ref  -> ../../../supporting-network/
   network-ref

I'm not sure whether a line length option has been specified to pyang when
generating the tree output, but that may help make it wrap better and become
more readable.  It might be worth adding a note to the RFC editor to see if you
can manually improve this tree diagram before RFC publication.  E.g., perhaps
the referenced path of some of the long leaf-refs should be elided altogether.

<scott>
There have been some editing, once I regenerate the trees, I will use the pyang line length and then hand edit for formatting.
</scott>

(3) p 18, sec Appendix A.  Microwave Topology Model with base topology models

A.1.  Instance data for 2+0 mode for a bonded configuration

Probably having a bit more of a description of what is being configured here,
e.g., referencing back to the diagram (if appropriate), may be helpful to
readers.

<scott>
The authors will provide a paragraph with more information.
</scott>

(4) p 24, sec Appendix A.  Microwave Topology Model with base topology models

A.2.  Instance data for 1+1 mode for a protected configuration

Similarly, having a bit more of a description of what is being configured here,
e.g., referencing back to the diagram (if appropriate), may be helpful to
readers.

<scott>
The authors will provide a paragraph with more information.
</scott>

(5) p 30, sec Appendix B.  Microwave Topology Model with example extensions

   This appendix provides examples of how the Microwave Topology Model
   can be used with the interface reference topology (ifref)

Do you want to explicitly state this as "This non-normative appendix", since I
presume that you only have, and only want to have, informative references to
those two RFCs?  You may also want to cite specific versions of those drafts
rather than the latest one.  You could also add a note to the RFC editor to
check/update this to the latest version of those drafts at the time of
publication.

<scott>
To be honest, I though Appendices were only non-normative.  But I don't mind adding some text to make that clear.
</scott>

(6) p 43, sec Appendix B.  Microwave Topology Model with example extensions

   This document was prepared using kramdown (thanks Martin Thomson).

Note the kramdown RFC tool is written/maintained by Carsten Bormann, Martin did
the github integrations.

<scott>
Thanks for the information, I will update the thanks line.
</scott>

Thank you for the review, I will discuss with the other authors on Thursday, and then provide a version 11 of the draft.

Regards,
-scott.