[CCAMP] Rtgdir last call review of draft-ietf-ccamp-flexe-yang-cm-02

Shuping Peng via Datatracker <noreply@ietf.org> Wed, 26 July 2023 01:27 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Shuping Peng via Datatracker <noreply@ietf.org>
To: rtg-dir@ietf.org
Cc: ccamp@ietf.org, draft-ietf-ccamp-flexe-yang-cm.all@ietf.org, last-call@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <169033484519.4031.16710011335112521213@ietfa.amsl.com>
Reply-To: Shuping Peng <pengshuping@huawei.com>
Date: Tue, 25 Jul 2023 18:27:25 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/LZ6DXluu4zeYMDYv9E0SMfxRXFM>
Subject: [CCAMP] Rtgdir last call review of draft-ietf-ccamp-flexe-yang-cm-02

Reviewer: Shuping Peng
Review result: Has Nits

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The
Routing Directorate seeks to review all routing or routing-related drafts as
they pass through IETF last call and IESG review, and sometimes on special
request. The purpose of the review is to provide assistance to the Routing ADs.
For more information about the Routing Directorate, please see
http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would
be helpful if you could consider them along with any other IETF Last Call
comments that you receive, and strive to resolve them through discussion or by
updating the draft.

Document: draft-ietf-ccamp-flexe-yang-cm-02
Reviewer: Shuping Peng
Review Date: 26 July 2023
IETF LC End Date: -
Intended Status: Standards

Summary:
This document is basically ready for publication but has nits that should be
considered prior to publication.

Comments:

1. Introduction

"Cross connection of FlexE timeslots in a network node is tentatively out of
the scope of this document." Should the word "tentatively" be deleted?

Major Issues:

No major issues found.

Minor Issues:

No minor issues found.

Nits:

1. Introduction
The YANG modules in this document s/conforms/conform to

1.2 Terminology
The terminology for describing YANG data models s/is/can be

2. Requirements of FlexE configuration
s/In following sections/In this section

s/FlexE YANG data model targets to provide the configurations of the functions,
as well as to report the real states and verify the consistency between the
configuration and the real states. /FlexE YANG data model aims to provide the
configurations of functions, report real states, and verify the consistency
between the configurations and real states.

s/SHOULD be invoked.&#12289;/SHOULD be invoked.

5. Security Considerations
s/an inappropriate configuration of them may cause an interrupt of a FlexE
client flow, drop of all Ethernet frames of a FlexE client, or even break down
of a whole FlexE group interface. /an inappropriate configuration may interrupt
a FlexE client flow, drop all Ethernet frames of a FlexE client, or even break
down a whole FlexE group interface.

6. IANA Considerations
s/be registred/be registered

[CCAMP] Rtgdir last call review of draft-ietf-cca… Shuping Peng via Datatracker