Re: [CCAMP] Thoughts on Flex-E YANG models

<wang.qilei@zte.com.cn> Mon, 09 December 2019 13:08 UTC

Return-Path: <wang.qilei@zte.com.cn>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1075D1201DE for <ccamp@ietfa.amsl.com>; Mon, 9 Dec 2019 05:08:54 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.198
X-Spam-Level:
X-Spam-Status: No, score=-4.198 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h_0NwlECNE23 for <ccamp@ietfa.amsl.com>; Mon, 9 Dec 2019 05:08:50 -0800 (PST)
Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5C4F81200C4 for <ccamp@ietf.org>; Mon, 9 Dec 2019 05:08:48 -0800 (PST)
Received: from mxct.zte.com.cn (unknown [192.168.164.217]) by Forcepoint Email with ESMTPS id C7B8EB8C4FF5479849A1 for <ccamp@ietf.org>; Mon, 9 Dec 2019 21:08:46 +0800 (CST)
Received: from mse-fl2.zte.com.cn (unknown [10.30.14.239]) by Forcepoint Email with ESMTPS id B12D7280AFB14DE025F4; Mon, 9 Dec 2019 21:08:46 +0800 (CST)
Received: from kjyxapp01.zte.com.cn ([10.30.12.200]) by mse-fl2.zte.com.cn with SMTP id xB9D8UZr056647; Mon, 9 Dec 2019 21:08:30 +0800 (GMT-8) (envelope-from wang.qilei@zte.com.cn)
Received: from mapi (kjyxapp05[null]) by mapi (Zmail) with MAPI id mid16; Mon, 9 Dec 2019 21:08:28 +0800 (CST)
Date: Mon, 9 Dec 2019 21:08:28 +0800 (CST)
X-Zmail-TransId: 2b075dee474cf5f00d9d
X-Mailer: Zmail v1.0
Message-ID: <201912092108289104878@zte.com.cn>
In-Reply-To: <MN2PR11MB43663484D7FA123131BD9BE6B5450@MN2PR11MB4366.namprd11.prod.outlook.com>
References: MN2PR11MB436635770A169EACDD7E0F54B5490@MN2PR11MB4366.namprd11.prod.outlook.com, MN2PR11MB43663484D7FA123131BD9BE6B5450@MN2PR11MB4366.namprd11.prod.outlook.com
Mime-Version: 1.0
From: <wang.qilei@zte.com.cn>
To: <rwilton@cisco.com>, <jiangyuanlong@huawei.com>
Cc: <ccamp@ietf.org>
Content-Type: multipart/mixed; boundary="=====_001_next====="
X-MAIL: mse-fl2.zte.com.cn xB9D8UZr056647
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/MAzRe9Zkr672V2HOaLxE638nn0w>
Subject: Re: [CCAMP] =?utf-8?q?Thoughts_on_Flex-E_YANG_models?=
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Dec 2019 13:08:54 -0000

Hi,


 


Sorry for the late reply.

We have reviewed the discussion about FlexE yang model in the maillist.

Thanks a lot for your reference FlexE-yang model, which helps understand the FlexE group, FlexE clients, slots and so on. Evenmore, some comments help for understanding the FlexE requirements, agreements/disagreements in the models.

Some differences in the models could be traced back to the differences in the respectively proposed requirements, for example, whether supports unidirectional FlexE client, whether FlexE instance should be considered in the model, etc. Maybe it's better to consider more application situations to understand the requirements, while not simplifying the requirements and hurrying to a concise model, which could not be applicable in some valuable situations.




For the proposed skeleton model, we still have some different understanding about the relationship between FlexE client and FlexE group in the model. According to the description in FlexE-IA, the FlexE group and FlexE client could be configured separately, e.g., a new FlexE client does not need to be configured simultaneously with the FlexE group, it may not be flexible to use one FlexE group construct to include the list of FlexE client information. In addition, there may exist another example that the switching of the carrier of FlexE client from one Group to another, in this case, change of the bonding relationship should be supported. In summary, from our understanding, decoupling the relationship between FlexE group and FlexE client would bring more flexibility.

 

There is another issue that we want to bring up, which is whether we need to configure the FlexE group as one interface. We can discuss about this. From our understanding, usually, when an interface is needed, there should have some strong requirements. For example, Ethernet LAG, the reason that we think to configure it as an interface is some traffic need to be switched directly to this interface, and obviously, this interface should be able to effect the routing of the traffic. But for FlexE group interface, the only use of this interface is to put FlexE client over it, and this interface only exists in the Ethernet PCS module, which need not be seen by others, so we are not sure whether an interface for FlexE group is needed.

 

Thanks

Qilei (on behalf of Xiaobing)















原始邮件



发件人:RobWilton(rwilton) <rwilton@cisco.com>
收件人:Jiangyuanlong <jiangyuanlong@huawei.com>;ccamp@ietf.org <ccamp@ietf.org>rg>;
日 期 :2019年11月27日 01:34
主 题 :Re: [CCAMP] Thoughts on Flex-E YANG models


_______________________________________________
CCAMP mailing list
CCAMP@ietf.org
https://www.ietf.org/mailman/listinfo/ccamp



Hi Yuanlong,


 


Okay.  I think that we seem to be in rough alignment on the overall structure.


 


I think that the next steps are to wait for comments from Xiaobing and Qilei to see if this top level structure would be an acceptable starting point to then try on the detailed configuration.


 


In case it helps, the updated YANG is here: https://github.com/rgwilton/flex-e-yang/blob/master/ietf-if-flex-e.yang


 


Thanks,
Rob


 



From: Jiangyuanlong <jiangyuanlong@huawei.com>
Sent: 26 November 2019 12:39
To: Rob Wilton (rwilton) <rwilton@cisco.com>om>; ccamp@ietf.org
Subject: RE: Thoughts on Flex-E YANG models




 


Rob,


 


Sometimes we do things faster than we think;)


Please see my further comments inline prefixed with[Jiang2].


 


Thanks,


Yuanlong


 


 



From: Rob Wilton (rwilton) [mailto:rwilton@cisco.com]
Sent: Tuesday, November 26, 2019 7:24 PM
To: Jiangyuanlong <jiangyuanlong@huawei.com>;ccamp@ietf.org
Subject: RE: Thoughts on Flex-E YANG models




 


Sorry, I accidentally hit send on my last email before typing anything!


 


Please see some further comments [RW] inline …


 



From: Jiangyuanlong <jiangyuanlong@huawei.com>
Sent: 26 November 2019 03:05
To: Rob Wilton (rwilton) <rwilton@cisco.com>;ccamp@ietf.org
Subject: RE: Thoughts on Flex-E YANG models




 


Rob,


 


I believe we are quite aligned in the abstract structure of the FlexE model.


Please see my further comments inline prefixed with[Jiang1].


 


Thanks again,


Yuanlong


 



From: Rob Wilton (rwilton) [mailto:rwilton@cisco.com]
Sent: Monday, November 25, 2019 11:40 PM
To: Jiangyuanlong <jiangyuanlong@huawei.com>;ccamp@ietf.org
Subject: RE: Thoughts on Flex-E YANG models




 


Hi Yuanlong,


 


Please see [RW] comments inline …


 



From: Jiangyuanlong <jiangyuanlong@huawei.com>
Sent: 25 November 2019 03:54
To: Rob Wilton (rwilton) <rwilton@cisco.com>;ccamp@ietf.org
Subject: RE: Thoughts on Flex-E YANG models




 


Hi Rob,


 


Thank you  a lot for your comments, they are very helpful.


Please see my further comments inline.


 


Cheers,


Yuanlong


 



From: CCAMP [mailto:ccamp-bounces@ietf.org]On Behalf Of Rob Wilton (rwilton)
Sent: Friday, November 22, 2019 11:01 PM
To: ccamp@ietf.org
Subject: [CCAMP] Thoughts on Flex-E YANG models




 


Hi,


 


I have some general thoughts on modelling Flex-E in YANG that may help the authors converge.  These comments mostly relate to what I would call the overall shape of the YANG model rather specific configuration
 (which I think can probably be sorted out once the shape has been agreed).


 


1.     Flex-E groups should be identified by their group-number (both models seem to do this, but the group number seems to be optional in one model)


2.     The configuration to identify the bonded phys should be under the flex-e group (both models do this).


[Jiang] Agreed to both...


 


3.     In the flex-e group’s bonded-phy interface configuration list, bonded-phy interface list entries could be keyed either by the bonded phy interface name, or the flex-e phy number. 


a.     I would suggest that the bonded-phy interface name is the more meaningful identifier to clients.  


[Jiang] Just to be clear, are your saying that the list of flexe-phy should be keyed by the interface name? I think in our model, current
 key “flexe-phy-if” is exactly the PHY interface name, as shown in RFC 8343:


“     typedef interface-ref {


       type leafref {


         path "/if:interfaces/if:interface/if:name";


”


[RW]


Yes.


 


b.     Either way, the entries should also indicate the binding to the bonded-phy interface (e.g. by an interface-ref – both models seem to do this).


4.     The configuration required to define the client interfaces associated with a flex-e group should be under the flex-e group list entry, based on the assumption that that 16 bit client id must be unique within the group rather than across
 groups.


[Jiang] Totally agreed...


 


5.     In the flex-e group’s client interface configuration list, client interface list entries could be keyed either by the client interface name, or the client id.


a.     Again, I would suggest that using the client interface name is the more meaningful identifier for clients.


[Jiang] Earlier we already planned to use “flexe-client-if” as the key to flexe-client-list. Could this resolve your comment?


[RW]


Yes, I think so.  It would be an interface-ref, similar to bonded-phy interface-ref.


 


However, I think that there is probably a slight difference in semantics:


 


In the case of the interface-ref for bonded phys, semantically it should probably be “require-instance true” (which is the default behaviour).  I.e. for the flex
 group configuration to be valid, it makes sense for the referenced bonded-phy interfaces to also exist in the configuration.


 


But in the case of the interface-ref for client interfaces, I think that it should be “require-instance false”...  This is because the flex-e client interface configuration
 defines the parameters to create the client interface but should not require that the client interface to exist in the configuration at the same time (even if that may often be the case).


 


[Jiang1] Agreed. My colleague Italo also expressed such an opinion during ITU-T Q14/SG15 interim meeting not long ago.


 


b.     Either way, the entries should also indicate the binding to the client interface (by interface-ref – both models seem to do this).


6.     Client interfaces should be modelled as regular interfaces, and use the normal iftype for Ethernet interfaces, i.e. the dubiously named iftype:ethernetCsmacd.  Without using this type regular Ethernet YANG configuration (e.g. as defined
 in 802.3.2) won’t work properly.


a.     I don’t think that there should be flex-e specific configuration under the client interface itself, instead, the flex-e specific configuration should be defined as part of the group + client interfaces.


[Jiang] Agreed to bullet a). But I have some doubts whether we can use the normal iftype for Ethernet interfaces directly. As FlexE Client
 includes only a thin MAC layer, while PHY layer is decoupled into the FlexE PHY, FlexE client management should be simpler than the regular Ethernet YANG configuration, furthermore, it seems to me all the YANG models defined in 802.3 or 802.2 more or less
 include some PHY configuration which cannot be applied to a FlexE client. Nevertheless, we look forward to seeing more discussions on this topic.


[RW]


From the rest of the system perspective, a client interface really should look/feel like a regular physical Ethernet interface, and I think that the majority of
 the 802.3.2 configuration/statistics should apply.  Auto-neg, duplex, speed shouldn’t be configurable, but then they can’t be configured on most higher speed optical interfaces anyway.  I would have thought that the rest of the module should apply (otherwise
 this Ethernet configuration would need to be duplicated in another module, which isn’t ideal).


[Jiang1] If a reference model can work, that will be better for sure.


 


But I think that the main issue to resolve is whether Flex-E group configuration is global or scoped to a FlexE group interface.  I can see pros and cons both ways:


1.     Putting the configuration under an FlexE group interface seems like a slightly artificial construct.


2.     However, this does mirror how LAG interfaces are represented (at least in our vendor model), and in some ways FlexE interfaces could be considered to be like an L1 LAG interface.  However, in the LAG case, the LAG interface can forward
 traffic, where as for FlexE groups, this would not be the case.


3.     There is probably a natural binding between a FlexE group and the client interfaces that closely relates to the parent child relationship between an interface and sub-interface.  E.g. disabling a FlexE group should have the effect of
 disabling each FlexE client interface.


4.     My overall feeling is that representing the FlexE groups as a type of interface seems like a reasonable configuration model.


[Jiang] Totally agreed...


[RW]


Note, I have made an assumption here that it is reasonable to represent the L1 layer of an interface as an entry in if:interfaces/if:interface.  It is worth noting
 that not all configuration/state in ietf-interfaces would apply sensibly to an L1 interface representation.  In particular, none of the statistics would seem to apply to the physical layer. 


[Jiang1] That is true indeed.


 


Anyway, hopefully these comments are useful to help the two sets of authors converge towards a common model.  I have other suggestions on the specific models but would suggest solving the big picture issues
 first.


[Jiang] Very useful indeed, we look forward to your further suggestions on the models.


[RW]


Thanks.  It would also be useful to see comments from other members of the WG, in particular, the authors of the draft-xiaobn-ccamp-flexe-yang-mod-03.


 


[Jiang1] Yes, we also hope to see more inputs from the WG.


In case it helps, here is the pyang tree output of the structure that I believe is most suitable to represent Flex-E interfaces:


 


module: ietf-if-flex-e


  augment /if:interfaces/if:interface:


    +--rw flex-e


       +--rw group


          +--rw group-number              uint32


          +--rw more-group-config-here?   string


          +--rw bonded-phy* [name]


          |  +--rw name                           if:interface-ref


          |  +--rw phy-number?                    uint8


          |  +--rw more-bonded-phy-config-here?   string


          +--rw client-interface* [name]


             +--rw name                              if:interface-ref


             +--rw id?                               uint16


             +--rw more-flex-e-client-config-here?   String


 


 


[Jiang1] Not sure we need both “flex-e” and “group” the same time (a little redundant in the structure IMO), otherwise I believe we are
 fully aligned in the overall structure.


 


[RW]


So this is a relatively minor point, and I could go either way on this.


 


From my perspective it is ‘nice’ from a modelling perspective if the configuration for a particular feature is under a single container:


-       It makes it easier to either just get that configuration, or to filter it out if it is not wanted.


-       It is easier for clients to immediately relate the configuration back to a particular feature/protocol.


 


E.g., if it is plausible that there is any need for any device-global flex-e configuration, then I would propose putting that under a single top-level flex-e container...


 


Equally, if there could ever be flex-e configuration on a flex-e-group interface that isn’t specific to the group then having the extra layer in the hierarchy is cleaner.  However, that this seems unlikely
 in this case, given that the interface represents a flex-e group …


[Jiang2] Yes, we had considered this option too. BTW, if such global inter-group FlexE configurations are found later, we can still follow
 this approach.


 


Another choice could be to only have a single layer of hierarchy, but call the top level container “flex-e” rather than “flex-e-group”, e.g. :


 


module: ietf-if-flex-e


  augment /if:interfaces/if:interface:


    +--rw flex-e


       +--rw group-number              uint32


       +--rw more-group-config-here?   string


       +--rw bonded-phy* [name]


       |  +--rw name                           if:interface-ref


       |  +--rw phy-number?                    uint8


       |  +--rw more-bonded-phy-config-here?   string


       +--rw client-interface* [name]


          +--rw name                              if:interface-ref


          +--rw id?                               uint16


          +--rw more-flex-e-client-config-here?   string


 


[Jiang2] Currently, I think this is a somewhat more graceful approach.


 


 


I don’t know whether phy-number and id should be mandatory.  I.e. always defined, or whether it is feasible that these could be automatically allocated by the device.


 


[Jiang1] phy-number and client id are mandatory. They can be configured in most use cases, but for static configuration as described in
 FlexE IA, they can be fixed (i.e., determined by the device), that means, they may be read-only.


 


[RW]


Okay, so from a YANG perspective, I think that makes them “mandatory false”, since they don’t have to be configured.  The description statements should make it clear
 that these fields must be provided in the operational datastore.


[Jiang2] Points taken. We can discuss more details on respective attributes if the WG could have an agreements on the overall structure.


 


Thanks,
Rob


 


Of course, I have excluded any specific configuration options.  I would suggest trying to get agreement on the overall structure (i.e. the shape of the YANG model) first.


 


The YANG model that this is built from is available at:https://github.com/rgwilton/flex-e-yang/blob/master/ietf-if-flex-e.yang


 


Regards,
Rob


 


 


Regards,
Rob