Re: [CCAMP] FlexE model updated draft-wang-ccamp-flexe-yang-cm-03

[tom petch <[e-mail]>]

From: CCAMP <[e-mail]> on behalf of [e-mail] <[e-mail]>
Sent: 02 June 2022 01:23

Hi，WG！

We have updated the draft of FlexE configuration model according the last IETF meeting. Pls see as follows.

<tp>
Quite a lot needs doing to this I-D

YANG module has no Copyright statement which means --- no copyright!

IANA Considerations are wrong.  Go read RFC8892 and follow the procedures there for registering a new iftype.  Meanwhile, I think it wrong to put 'flexEclient' in the module - the expert review may require a different value and then confusion can reign.  You should use a placeholder as you should do - but do not do - for the RFC number until a value is assigned.
I oppose adoption until this is fixed - it is very bad practice IMHO.  You can apply for the iftype here and now and should do so.  Start applying - now!

prefix in the YANG modules do not match IANA Considerations.

module name in the YANG modules do not match IANA Considerations

YANG import MUST have a reference and that MUST be a Normative Reference in the I-D

YANG needs references, at least to FlexE if not more

s.1.2.1 Ethernet PHY, FlexE PHY could do with a reference

http://tools should be https://datatracker

six authors are generally seen as too many

I do not see enough differentiation in the module description clauses.  I think that each should mention the other and why it exists.

bandwidth lacks a YANG units clause

timeslot-list could be enforced by a regex

Tom Petch


1、draft-wang-ccamp-flexe-yang-cm-03 can be find here:  https://www.ietf.org/archive/id/draft-wang-ccamp-flexe-yang-cm-03.txt

2、response to minutes inline：

7 11:30(40) 10 Title: Application of FlexE configuration model
Draft: https://tools.ietf.org/id/draft-xiaobn-ccamp-application-flexe-cm-00.txt
Presenter: Xiaobing Niu
[Robert Wilton] Welcome back. I agree to make the merge flexE-cm, to talk about the applicability and the YANG models. Explaining how to use the YANG model in the appendix will be useful. One comment for the current structure probably in the other daft rather than this one is, I question a bit about having the FlexE client configuration under the client interface rather than having it under flexE container.
【authors】----- comments addressed on list on 2022-3-30: https://mailarchive.ietf.org/arch/msg/ccamp/45MzxQJjFWgPjmcgY7n7N1KPitw/
My reason is that for flexE client configuration isn’t really so much abou the client interface, but related to how the flexE interfaces are set up. For exapmle you need to make sure the TS you are using are organized with other client interfaces. I think such change will help improve the consistency.
[Dieter Beller] (from chat) How is this Flex-E draft related to draft-wang-ccamp-flexe-yang-cm-02?
[Xiaobing Niu] In this work we construct examples based on that work, and summarized the requirement.
【authors】----- two drafts are merged together to better specify FlexE YANG model.
[Daniele Ceccarreli] Also suggest to merge. There is another configuration model (now expired) which is competing. Are they still competing or having a common ground? Or how do we proceed these works to make everyone happy? Just dont want to forget the other side.
[Xiaobing Niu] We were not renewing the draft-wang-ccamp-flexe-yang-cm-02 draft, but will merge it.
【authors】----- already well addressed.


________________________________
-------------------------------------
王敏学/ Wang Minxue
中国移动通信研究院 基础网络技术研究所 / China Mobile Research Institute
地址: 北京市西城区宣武门西大街32号创新大厦,100053
电话: [phone]-33202
传真：[phone]
Email: [e-mail]
-------------------------------------