Re: [CCAMP] YANG doctor review

tom petch <ietfc@btconnect.com> Tue, 19 November 2019 12:30 UTC

Return-Path: <ietfc@btconnect.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72FBD120913 for <ccamp@ietfa.amsl.com>; Tue, 19 Nov 2019 04:30:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.248
X-Spam-Level:
X-Spam-Status: No, score=0.248 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RATWARE_MS_HASH=2.148, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=btconnect.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RD__7ztoHo_H for <ccamp@ietfa.amsl.com>; Tue, 19 Nov 2019 04:30:06 -0800 (PST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10126.outbound.protection.outlook.com [40.107.1.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93BF4120902 for <ccamp@ietf.org>; Tue, 19 Nov 2019 04:30:05 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dXzI8XBALaZ/Z83y2hR/j8uKgOaqWP6j1Sz1E0Mn1bv7XULGsNaupSdouT4SB6bICH21EU7maRTA72TBfSCLRO0dXLDwzM2cRJciA5mCQ0A2ZgjAzvXSPDRB6jvzdSCP91a7X58lrQ9M3Pg/wcafbK9mCUw39+6YaCacJFHQ8CT7hrg5ZTyIDhnDt3z8+KaF+7ZLukKcU0Cqa7H2rQfVEdgr+z8i/2eMVTSK9lHJLaxLYNyjI/RTboufajgUYidfdEuY/6HkV4Bt6wUzuVDHhjSyrtHOIeBo8akBG0/8nJcDOqLijPwjdIo5ZBLr/Cvk8Ogmjg53eRnjJxUesGWDPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzuhcRoAj6Gm/296BglSy/7VpxeyUlLWD1Dq2dTVP/A=; b=b6bkEOC6UpC7GxmjOgum/oQKJeay2JnxSLdx4ZpWsLKtlXNhZMvroBCG0+JDK3ps1E6tLdzmketjfG2WIWTztdTUBWQYovEFh/GKLFnfXbncDPgSS1xS6HF3x98OY+OwODrDRGOvTiBdrASg3odVh7ioNjojk9//m4wqdcOrylk/mpMMCsfbvgvzwjze5lRDkxCzZMOOI7OY5j/Gz6d/VQgbQifDivnpUMUly/BQnNUFRLRw19m1zirlKAGUq2oCYHZf02B/AaekfTYN54ijnKXWZxdxlFsBmmJsgmajODzXYm+IA/alI+JKp0kdPS1EcUEakAgo/aiGTPCimZSLKA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=btconnect.com; dmarc=pass action=none header.from=btconnect.com; dkim=pass header.d=btconnect.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=btconnect.onmicrosoft.com; s=selector2-btconnect-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzuhcRoAj6Gm/296BglSy/7VpxeyUlLWD1Dq2dTVP/A=; b=RqFBbC1g9W3ICv7CqzwyICGyRLEKzEsdI3wJNVKU6I+KShK+BOjOjZAjYj3VLvBwRSCj/netp+3RX4HBpRMt7cOtxfpsd7a0c7WzRuBY5F/w21B3QVnAHkz+29zgteIMTrF9bAzBdbg55HlYfObudJCd7J/qhjhAVSw2iSqnpaQ=
Received: from DB7PR07MB5147.eurprd07.prod.outlook.com (20.178.42.32) by DB7PR07MB4043.eurprd07.prod.outlook.com (52.134.104.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.9; Tue, 19 Nov 2019 12:29:59 +0000
Received: from DB7PR07MB5147.eurprd07.prod.outlook.com ([fe80::e5bf:72e6:a66c:401a]) by DB7PR07MB5147.eurprd07.prod.outlook.com ([fe80::e5bf:72e6:a66c:401a%3]) with mapi id 15.20.2474.015; Tue, 19 Nov 2019 12:29:59 +0000
From: tom petch <ietfc@btconnect.com>
To: "ccamp@ietf.org" <ccamp@ietf.org>, Daniele Ceccarelli <daniele.ceccarelli=40ericsson.com@dmarc.ietf.org>
Thread-Topic: [CCAMP] YANG doctor review
Thread-Index: AQHVntTyF+l9r1b4QEKQeI1Hzup4dg==
Date: Tue, 19 Nov 2019 12:29:59 +0000
Message-ID: <075401d59ed4$ff5036c0$4001a8c0@gateway.2wire.net>
References: <HE1PR0701MB22672662523D64EF02CE531FF0760@HE1PR0701MB2267.eurprd07.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-clientproxiedby: CWLP123CA0085.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:5b::25) To DB7PR07MB5147.eurprd07.prod.outlook.com (2603:10a6:10:68::32)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ietfc@btconnect.com;
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: Microsoft Outlook Express 6.00.2800.1106
x-originating-ip: [86.139.211.103]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 226b1bb3-8673-45fc-374f-08d76cec3197
x-ms-traffictypediagnostic: DB7PR07MB4043:
x-ms-exchange-purlcount: 3
x-microsoft-antispam-prvs: <DB7PR07MB40430C300EFD4E1415A8C9BFA04C0@DB7PR07MB4043.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3044;
x-forefront-prvs: 022649CC2C
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(396003)(376002)(39860400002)(136003)(366004)(13464003)(189003)(199004)(51444003)(81166006)(6506007)(8936002)(386003)(8676002)(316002)(81156014)(26005)(25786009)(446003)(476003)(486006)(50226002)(478600001)(110136005)(229853002)(99286004)(71200400001)(71190400001)(66066001)(1556002)(86362001)(66476007)(66556008)(64756008)(66446008)(256004)(3846002)(5660300002)(6116002)(66946007)(2906002)(6436002)(62236002)(44716002)(81816011)(76176011)(14496001)(186003)(966005)(6306002)(9686003)(81686011)(2501003)(14454004)(6512007)(44736005)(6486002)(52116002)(305945005)(102836004)(4720700003)(6246003)(7736002)(74416001)(7726001); DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR07MB4043; H:DB7PR07MB5147.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0;
received-spf: None (protection.outlook.com: btconnect.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: wNLxHOHpDbYLlZ0fM3B4/RgnkfUJ5oGbiVm61F+s0QaG8YeCXwQigLTDmqHMz+7TRea0S2BSrZOi1WgRQWvbQtem38GiRbzshHc8KeKJo/rZzjt3yxK9fvB09L1zWTI93VeWz1YQZn81Am+ikUXep2+uqjATnFK85atz7jez9l3AK+YLlatEBz1p/MtGTyTp398oIrHDt+CYvvnKtAsTt/EyNQ0jV8+t1tPTdAbv3hKo9w4AXFWoNEsPRGHHru3A/hy1nOlyUohMrWIfa8fQcD1DIAr/O8kXoQcArdmrQrs/tiePMKmLBKHqYk5NGw9iO1jyVHeF5QjANlxAxYOMCA4J3ojp0jJCWMqinO177kKoug9x5sFsZkyzf5eM/A8zMBHpy2A8fLjeieuy6aRteJdll+jAWXi/9h65lkwr4lHaRGzUNwB1TYvelBNxaJ+YYADPhGTE6KheXuLt9PdWOS/aF/QYt77EqKdU01CFBjA=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <F3E76269B67EF34EBE8E8F54F7ABE1BC@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: btconnect.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 226b1bb3-8673-45fc-374f-08d76cec3197
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2019 12:29:59.8758 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf8853ed-96e5-465b-9185-806bfe185e30
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Lg/CUA3HbYDJJX8kXxcR/bBwpPUJQVqSqIrWqp4ITquxVovDtPjZ/G0va3nNU7aniz/8H2Hmr9K8vHtjH55N7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR07MB4043
Archived-At: <https://mailarchive.ietf.org/arch/msg/ccamp/dnCG4WgKMWe9UJyKukDCR60nt4w>
Subject: Re: [CCAMP] YANG doctor review
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 12:30:07 -0000

Looking at layer0-types, as one who is not a YANG doctor, I see

Introduction makes it clear that this is for optical layer0; Abstract
misses the work 'optical' which I think that it should include.

Module references G.694.1 which I cannot see in the I-D references

Generally, the YANG reference clauses are usually matched by Normative,
not Informative, references

Where section 2.1 provides references for the types and groupings, then
I would see it as essential that those references appear as YANG
reference clauses for the types and groupings; most do not appear in the
YANG module e.g. for vendor identifier, wavelength assignment, layer0
grid type, term type, fec type etc etc

If you think that a reference is needed in section 2.1, and I agree with
you that they are, then logically the same references must appear in the
YANG module since the YANG module is a stand-alone piece of text that
will be divorced from the rest of the I-D/RFC

Tom Petch


----- Original Message -----
From: "Daniele Ceccarelli"
<daniele.ceccarelli=40ericsson.com@dmarc.ietf.org>
To: <ccamp@ietf.org>
Sent: Wednesday, November 13, 2019 7:56 AM

> WG,

>
> We're requested the YANG doctor review of:
>
>  <https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer0-types/>
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer0-types/
>
> https://datatracker.ietf.org/doc/draft-ietf-ccamp-layer1-types/
>
> BR
>
>
>
> Daniele
>



------------------------------------------------------------------------
--------


> _______________________________________________
> CCAMP mailing list
> CCAMP@ietf.org
> https://www.ietf.org/mailman/listinfo/ccamp
>