Re: [CCAMP] AD review of draft-ietf-ccamp-wson-signaling

Leeyoung <leeyoung@huawei.com> Mon, 09 March 2015 21:03 UTC

Return-Path: <leeyoung@huawei.com>
X-Original-To: ccamp@ietfa.amsl.com
Delivered-To: ccamp@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CC3D11ACD74 for <ccamp@ietfa.amsl.com>; Mon, 9 Mar 2015 14:03:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HK_RANDOM_ENVFROM=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XdTt7e2cgWkI for <ccamp@ietfa.amsl.com>; Mon, 9 Mar 2015 14:03:23 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E9911ACD71 for <ccamp@ietf.org>; Mon, 9 Mar 2015 14:02:47 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml406-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BTL38610; Mon, 09 Mar 2015 21:02:46 +0000 (GMT)
Received: from DFWEML705-CHM.china.huawei.com (10.193.5.142) by lhreml406-hub.china.huawei.com (10.201.5.243) with Microsoft SMTP Server (TLS) id 14.3.158.1; Mon, 9 Mar 2015 21:02:45 +0000
Received: from DFWEML706-CHM.china.huawei.com ([10.193.5.225]) by dfweml705-chm ([10.193.5.142]) with mapi id 14.03.0158.001; Mon, 9 Mar 2015 14:02:38 -0700
From: Leeyoung <leeyoung@huawei.com>
To: Leeyoung <leeyoung@huawei.com>, "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "gregb@grotto-networking.com" <gregb@grotto-networking.com>, "xsg@nict.go.jp" <xsg@nict.go.jp>, "giomarti@cisco.com" <giomarti@cisco.com>, "harai@nict.go.jp" <harai@nict.go.jp>
Thread-Topic: AD review of draft-ietf-ccamp-wson-signaling
Thread-Index: AdBWijwn4CG/2CFPRJaoMn5GzUFRUAEH3OJgAAChYpA=
Date: Mon, 09 Mar 2015 21:02:37 +0000
Message-ID: <7AEB3D6833318045B4AE71C2C87E8E1729C95878@dfweml706-chm>
References: <016901d0568a$5c91d0c0$15b57240$@olddog.co.uk> <7AEB3D6833318045B4AE71C2C87E8E1729C9585B@dfweml706-chm>
In-Reply-To: <7AEB3D6833318045B4AE71C2C87E8E1729C9585B@dfweml706-chm>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.47.133.149]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/ccamp/tr071_h3bhrR6FwTJScan0fvGJA>
Cc: 'CCAMP' <ccamp@ietf.org>, "akatlas@gmail.com" <akatlas@gmail.com>
Subject: Re: [CCAMP] AD review of draft-ietf-ccamp-wson-signaling
X-BeenThere: ccamp@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Discussion list for the CCAMP working group <ccamp.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/ccamp>, <mailto:ccamp-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/ccamp/>
List-Post: <mailto:ccamp@ietf.org>
List-Help: <mailto:ccamp-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ccamp>, <mailto:ccamp-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Mar 2015 21:03:26 -0000

I forgot one item:

Section 2 has FOADM, but it is not used in the document.

I would delete FOAMD from the document.

Thanks,
Young

-----Original Message-----
From: CCAMP [mailto:ccamp-bounces@ietf.org] On Behalf Of Leeyoung
Sent: Monday, March 09, 2015 3:56 PM
To: adrian@olddog.co.uk; gregb@grotto-networking.com; xsg@nict.go.jp; giomarti@cisco.com; harai@nict.go.jp
Cc: 'CCAMP'; akatlas@gmail.com
Subject: Re: [CCAMP] AD review of draft-ietf-ccamp-wson-signaling

Hi Adrian,

Thank you for your AD review. Here's my response to your comment. 

Thanks,
Young

-----Original Message-----
From: Adrian Farrel [mailto:adrian@olddog.co.uk] 
Sent: Wednesday, March 04, 2015 8:49 AM
To: gregb@grotto-networking.com; xsg@nict.go.jp; Leeyoung; giomarti@cisco.com; harai@nict.go.jp
Cc: 'CCAMP'; db3546@att.com; akatlas@gmail.com; Alvaro Retana
Subject: AD review of draft-ietf-ccamp-wson-signaling

[Using explicit addresses because the tools aliases are currently unreliable]

Authors,

I've done my usual AD review of your document (the nth in the sequence of n+1 WSON drafts!). I have a few comments, and normally I would ask you for a new revision at once, but because of dates and things I am going to start the IETF last call and enter these as last call comments.

The last call will end on 3/18 and you can post a new revision then (by sending it to me to ask the Secretary to post it) or wait to post it yourselves when the gates reopen on 3/23.

Thanks for the work,
Adrian

===

You need to split the Authors' Addresses section and move out all those not on the current front page to be present in a Contributors section.

YOUNG>> Yes, agree. 

---

You seem to have the name of RFC 6205 in the references section a bit wrong!

YOUNG>> OK. Corrected to "Generalized Labels for Lambda-Switch-Capable (LSC) Label Switching Routers". 

---
                                              
Do you really mean that you are updating 6205? That is the document that defines lambda labels.

It has no mention of G.709 despite what you say in the Abstract. This
seems a little odd.                          

YOUNG>> I agree. No need to talk about G.709 and this document does not update 6205. So, I would delete the
Following paragraph from the Abstract: 

  "These extensions build on previous
   work for the control of lambda and G.709 based networks, i.e. update
   RFC6205, to make it applicable to WSON-LSC capable equipment."

What is more, I don't see any discussion of updates to the label format or usage in the document although Section 4 does say

   [RFC6205] defines the label format as applicable to LSC capable
   device. This document extends [RFC6205] as make its label format
   applicable also to WSON-LSC capable devices.

I don't think that applying the label to WSON without changing its meaning or the way it is used is really an "update".

YOUNG>> Yes, this is not correct. I would delete "This document extends [RFC6205] as make its label format
   applicable also to WSON-LSC capable devices." 

---

Section 2 has FOADM, but it is not used in the document.

You need to hyphenate "Cross Connect" unless you are really angry :-)


YOUNG>> Corrected. No reason to be angry with a "-" :) 
---

Section 3 gives a caption to a list

    List 1. WSON Signal Characteristics

I've not seen that before in an I-D, and since you don't refer to the list by name, I suggest you just delete this.

YOUNG>> Deleted. 

---

I wish you hadn't suggested explicit values for the two new Error Codes in 4.2.2 and 6. But we'll see what IANA says during IETF last call.

YOUNG>> Yes. Agree

_______________________________________________
CCAMP mailing list
CCAMP@ietf.org
https://www.ietf.org/mailman/listinfo/ccamp