Re: [CDNi] Review of draft-ietf-cdni-delegation-acme-00

frederic.fieau@orange.com Thu, 23 February 2023 10:06 UTC

Return-Path: <frederic.fieau@orange.com>
X-Original-To: cdni@ietfa.amsl.com
Delivered-To: cdni@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB94EC14CEE5 for <cdni@ietfa.amsl.com>; Thu, 23 Feb 2023 02:06:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.095
X-Spam-Level:
X-Spam-Status: No, score=-2.095 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fzFZ9OROsHPC for <cdni@ietfa.amsl.com>; Thu, 23 Feb 2023 02:06:42 -0800 (PST)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.70.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A08CC14F736 for <cdni@ietf.org>; Thu, 23 Feb 2023 02:06:42 -0800 (PST)
Received: from opfednr02.francetelecom.fr (unknown [xx.xx.xx.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by opfednr26.francetelecom.fr (ESMTP service) with ESMTPS id 4PMpb41z4xzyyR; Thu, 23 Feb 2023 11:06:40 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1677146800; bh=DpCTeTVsz7joYZIAH8AYI18/W+FGC5/w6ILNEtegLhY=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=q6IOflCveJoDlgGoOw4RyaUPIj6NC57kmIej5yeoJfLOPDcPRJjtZQeU+fh4Hcx7A DRB9UfecUpx1auGm9W0d1W+iv4KMZORDCMHPXY5681ORqoXrlmwerZbR5Sm4Ew6ckR KDaloxEgJBjfQ4nQ+huMl8qO1/bGRnK4fE4JRO0+gnQohzY0Sy+fG7c7RpsPsop0ds 6Li2WtQEf47dRmiVjws9Wqvl9ssYfenQIBTIBVwLkchbUUN+Vkk0P5xfCrHWl1Kqjl DaYbcIDw1DCwQdMJc8tNW+FLgQtKr6jaqW6+mghBG34xXeQYJzol3nZRQ1tMFWao9C HQjXFa/FEinxQ==
From: frederic.fieau@orange.com
To: Thomas Fossati <Thomas.Fossati@arm.com>, "cdni@ietf.org" <cdni@ietf.org>
Thread-Topic: Review of draft-ietf-cdni-delegation-acme-00
Thread-Index: AQHZL9sihHzh/6lPL0CR8yx6Kxf1l66xIPkxgBeAvIOABK9rEoAPLBES
Date: Thu, 23 Feb 2023 10:06:39 +0000
Message-ID: <24462_1677146800_63F73AB0_24462_230_1_103e6050487d4633b67ffe3627023ee1@orange.com>
References: <DB9PR08MB65241A19DCF2D10FF4FAF7609CC99@DB9PR08MB6524.eurprd08.prod.outlook.com>, <DB9PR08MB6524DB623478E0F8640EECFB9CCF9@DB9PR08MB6524.eurprd08.prod.outlook.com> <30583_1676055350_63E69336_30583_99_1_dff74c34c2c847c3b769e75d0f4999e8@orange.com>, <DB9PR08MB65244533DCB1DEF568D202139CDD9@DB9PR08MB6524.eurprd08.prod.outlook.com>
In-Reply-To: <DB9PR08MB65244533DCB1DEF568D202139CDD9@DB9PR08MB6524.eurprd08.prod.outlook.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.115.26.50]
Content-Type: multipart/alternative; boundary="_000_103e6050487d4633b67ffe3627023ee1orangecom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/cdni/gEEZjfI7FdyeRoc8Yb6JHNeR4Ew>
Subject: Re: [CDNi] Review of draft-ietf-cdni-delegation-acme-00
X-BeenThere: cdni@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "This list is to discuss issues associated with the Interconnection of Content Delivery Networks \(CDNs\)" <cdni.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cdni>, <mailto:cdni-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cdni/>
List-Post: <mailto:cdni@ietf.org>
List-Help: <mailto:cdni-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cdni>, <mailto:cdni-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Feb 2023 10:06:46 -0000

Hi Thomas,


Yes you're right. I took it into account.


regards,

Frédéric

________________________________
De : Thomas Fossati <Thomas.Fossati@arm.com>
Envoyé : lundi 13 février 2023 19:30:31
À : FIEAU Frédéric INNOV/NET; cdni@ietf.org
Objet : Re: Review of draft-ietf-cdni-delegation-acme-00

Hi Fred,

Thanks very much for addressing my comments.

The last suggestion I have is to change the “lifetime” and “lifetime-adjust” attributes to “star-lifetime” and “star-lifetime-adjust”.
This makes it is visually evident when a delegation is STAR vs non-STAR.
(Of course this is a non-blocking & completely debatable piece of advice 😊)

Cheers, t

PS: I’ve left a PR on your repo with a couple of typographic fixes.



On 10/02/2023, 18:56, "frederic.fieau@orange.com" <frederic.fieau@orange.com> wrote:


Hi Thomas,



Thank you for your review and comments.

I made the following changes on the Github https://github.com/FredericFi/cdni-wg/blob/main/draft-ietf-cdni-delegation-acme.md

If no further remarks, I will post the draft in the next days.



Thanks!

Frederic




> I just realised I had another comment that got lost in the translation

> between my notes and the email... which is: the lifetime-adjust property

> should be optional rather than mandatory, to mirror the STAR definitions

> in Section 3.1.1 [1].



Done



> ## abstract

>

> * why plural "metadata objects"?  Suggestion:

>

> OLD

>

> Specifically, this document defines CDNI Metadata interface objects to

> enable delegation of X.509 certificates leveraging delegation schemes

> defined in RFC9115.

>

> NEW

>

> Specifically, this document defines a CDNI Metadata interface object

> to enable delegation of X.509 certificates leveraging delegation

> schemes defined in RFC9115.

>

>



Done



> * expand FCI on first use:

>

>  Section 2 presents delegation metadata for the FCI interface.



Done




> * typo (extra “to”)

>

>   When a uCDN delegates to a dCDN to deliver HTTPS traffic using DNS

>   Redirection [RFC7975],

>

>   When a uCDN delegates a dCDN to delivery of HTTPS traffic using DNS

>   Redirection [RFC7975],

>

>



Done



> * typo (missing parentheses):

>

> OLD

>

>    The ACMEDelegationMethod applies to both ACME STAR delegation,

>    which provides a delegation model based on short-term certificates

>    with automatic renewal Section 2.3.2 of [RFC9115], and non-STAR

>    delegation, which allows delegation between CDNs using long-term

>    certificates Section 2.3.3 of [RFC9115].

>

> NEW

>

>    The ACMEDelegationMethod applies to both ACME STAR delegation,

>    which provides a delegation model based on short-term certificates

>    with automatic renewal (Section 2.3.2 of [RFC9115]), and non-STAR

>    delegation, which allows delegation between CDNs using long-term

>    certificates (Section 2.3.3 of [RFC9115]).

>



Done



> ## §3.1

>

> * this seems to suggest that the consumer can tell STAR and non-STAR

>   based on "delegation certificate validity", but it's not clear to me

>   what that means.

>

>    The ACMEDelegationMethod object allows a uCDN to both define STAR

>    and non-STAR delegation depending on the delegation certificate

>    validity.

>

>   From the following examples (§3.1.1) I gather there's an implicit

>   way to distinguish based on the presence/absence of the lifetime*

>   properties.  Is that what was intended?  If so, it should be

>   clarified.



Done





_________________________________________________________________________________________________________________________



Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc

pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler

a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,

Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.



This message and its attachments may contain confidential or privileged information that may be protected by law;

they should not be distributed, used or copied without authorisation.

If you have received this email in error, please notify the sender and delete this message and its attachments.

As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.

Thank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.