IETF Logo Mail Archive

Re: [Cellar] A few minor comments on draft-ietf-cellar-ebml-13

Dave Rice <dave@dericed.com> Thu, 24 October 2019 16:26 UTC

Return-Path: <dave@dericed.com>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5632B12011C for <cellar@ietfa.amsl.com>; Thu, 24 Oct 2019 09:26:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.118
X-Spam-Level:
X-Spam-Status: No, score=-1.118 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QYYzdpfnJCVV for <cellar@ietfa.amsl.com>; Thu, 24 Oct 2019 09:26:02 -0700 (PDT)
Received: from server172-3.web-hosting.com (server172-3.web-hosting.com [68.65.122.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8C45120113 for <cellar@ietf.org>; Thu, 24 Oct 2019 09:26:02 -0700 (PDT)
Received: from [146.96.19.240] (port=20068 helo=[10.10.201.21]) by server172.web-hosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from <dave@dericed.com>) id 1iNfvx-000GyT-Dv; Thu, 24 Oct 2019 12:26:02 -0400
From: Dave Rice <dave@dericed.com>
Message-Id: <CEFFB35B-0F6A-4EE7-BF6D-3B150B7A6F3B@dericed.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_AFB65FDB-D988-4E64-AF70-B23D5C2CEF8D"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Date: Thu, 24 Oct 2019 12:25:51 -0400
In-Reply-To: <f2f44248-6e5d-4719-89fe-28187228822f@www.fastmail.com>
Cc: cellar@ietf.org
To: Alexey Melnikov <aamelnikov@fastmail.fm>
References: <f2f44248-6e5d-4719-89fe-28187228822f@www.fastmail.com>
X-Mailer: Apple Mail (2.3445.104.8)
X-OutGoing-Spam-Status: No, score=-2.4
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - server172.web-hosting.com
X-AntiAbuse: Original Domain - ietf.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - dericed.com
X-Get-Message-Sender-Via: server172.web-hosting.com: authenticated_id: dave@dericed.com
X-Authenticated-Sender: server172.web-hosting.com: dave@dericed.com
X-Source:
X-Source-Args:
X-Source-Dir:
X-From-Rewrite: unmodified, already matched
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/0sUVAU6TqP4mkddUpZD2g0ConPg>
Subject: Re: [Cellar] A few minor comments on draft-ietf-cellar-ebml-13
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Oct 2019 16:26:04 -0000

Thank you Alexey,

> On Oct 24, 2019, at 8:47 AM, Alexey Melnikov <aamelnikov@fastmail.fm> wrote:
> 
> Hi,
> 
> Thank you for addressing most of my AD review comments. I followed up on a few remaining issues in a separate thread.
> 
> I just reviewed changed since version -10 and have a few new minor comments:
> 
> I think [W3C.REC-xmlschema-0-20041028] should be a Normative Reference, because of how it is referenced in Section 11.1.15. (I assume the XML Schema there is normative.)
> 
> It would be good to have an example of <implementation_note> in the document.
> 
> In Section 11.1.5.8 the following test was added:
> 
>   An unwritten mandatory
>   Element with a declared default value is semantically to that Element
> 
> I think the word "equivalent" is missing after "semantically".
> 
>   if written with the default value stored as the Element Data.
> 
> I would ask editors to address these in the next revision.

I started a pull request to address the noted 3 issues (changing a reference to normative, offering an implementation_note example, and adding the missing word). See: https://github.com/cellar-wg/ebml-specification/pull/297 <https://github.com/cellar-wg/ebml-specification/pull/297>.

> However the above are not serious enough to delay IETF LC, so I will start it now.
> 
> Best Regards,
> Alexey
> 
> _______________________________________________
> Cellar mailing list
> Cellar@ietf.org
> https://www.ietf.org/mailman/listinfo/cellar

v2.23.0 | Report a Bug | By Email