Re: [Cellar] [PATCH FFV1] Byte alignment is made explicit

[Michael Niedermayer <[e-mail]>]

On Wed, May 25, 2016 at 08:41:21AM +0200, Jerome Martinez wrote:
> Le 25/05/2016 à 01:32, Michael Niedermayer a écrit :
> >On Tue, May 24, 2016 at 10:58:28PM +0200, Jerome Martinez wrote:
> >[...]
> >>  # General Description
> >>@@ -541,6 +543,9 @@ See [NUT](#references) for more information about elements.
> >>  |            for( p = 0; p \< primary\_color\_count; p++ ) { |       |
> >>  |                Line( p, y )                                |       |
> >>  |    }                                                       |       |
> >>+|    if ( coder\_type )                                      |       |
> >coder_type == 0
> 
> Oops, very stupid typo.
> Fixed.
> 
> >
> >
> >>+|        while ( !byte\_aligned() )                          |       |
> >>+|            padding                                         |  u(1) |
> >>  |    if( i \|\| version \> 2 )                               |       |
> >>  |        slice\_size                                         | u(24) |
> >>  |    if( ec ) {                                              |       |
> >>@@ -551,6 +556,9 @@ See [NUT](#references) for more information about elements.
> >>  **primary\_color\_count** is defined as 1 + ( chroma_planes ? 2 : 0 ) + ( alpha_plane ? 1 : 0 ).
> >>+**padding** specifies a bit without any significance and used only for byte alignment.
> >>+MUST be 0.
> >ok, i suggest though to change this for the next version of the
> >bitstream
> >its better to write a 1 bit and then pad with 0 to a byte boundary
> >or (0 bit + padding with 1) that way the end of the previous bitstream
> >can be determind with certanity from the last byte
> 
> I keep it in mind for when I open discussions about v4+ improvements.
> 
> Jérôme

>  ffv1.md |    8 ++++++++
>  1 file changed, 8 insertions(+)
> fe47d32273bedfbe86a2d564af484e4687c311b7  0001-PATCH-Byte-alignment-is-made-explicit.patch
> >From ec4b9647c45834102e278d5f573e9180d13b6fde Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <[e-mail]>
> Date: Wed, 25 May 2016 08:28:37 +0200
> Subject: [PATCH] [PATCH] Byte alignment is made explicit

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA