[Cellar] Lars Eggert's No Objection on draft-ietf-cellar-matroska-16: (with COMMENT)

Lars Eggert via Datatracker <noreply@ietf.org> Thu, 25 May 2023 07:08 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: cellar@ietf.org
Delivered-To: cellar@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B4997C14CE5F; Thu, 25 May 2023 00:08:25 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Lars Eggert via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-cellar-matroska@ietf.org, cellar-chairs@ietf.org, cellar@ietf.org, mcr+ietf@sandelman.ca, mcr+ietf@sandelman.ca
X-Test-IDTracker: no
X-IETF-IDTracker: 10.4.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Lars Eggert <lars@eggert.org>
Message-ID: <168499850566.22896.14214483937378670886@ietfa.amsl.com>
Date: Thu, 25 May 2023 00:08:25 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/qSjuY8fkzW6mGivfSmRciOgT034>
Subject: [Cellar] Lars Eggert's No Objection on draft-ietf-cellar-matroska-16: (with COMMENT)
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.39
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2023 07:08:25 -0000

Lars Eggert has entered the following ballot position for
draft-ietf-cellar-matroska-16: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ 
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-cellar-matroska/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

# GEN AD review of draft-ietf-cellar-matroska-16

CC @larseggert

Thanks to Elwyn Davies for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/l2gsKdSbRBtCBNMrVZBmmRiu1IM).

## Comments

### Note to self

Check whether Expert Review is an appropriate registration policy here.

### DOWNREFs

Possible DOWNREF from this Standards Track doc to `[Twofish]`. If so, the IESG
needs to approve it.

Possible DOWNREF from this Standards Track doc to `[Blowfish]`. If so, the IESG
needs to approve it.

### Inclusive language

Found terminology that should be reviewed for inclusivity; see
https://www.rfc-editor.org/part2/#inclusive_language for background and more
guidance:

 * Terms `mastertrackuid`, `masteringmetadata`, `mastering`,
   `mastertrackseguid`, and `master`; alternatives might be `active`,
   `central`, `initiator`, `leader`, `main`, `orchestrator`, `parent`,
   `primary`, `server`
 * Term `native`; alternatives might be `built-in`, `fundamental`, `ingrained`,
   `intrinsic`, `original`
 * Term `blindly`; alternatives might be `visually impaired`, `unmindful of`,
   `unconcerned about`, `negligent of`, `unaware`, `uncomprehending`,
   `unaware`, `uncritical`, `unthinking`, `hasty`, `blocked`, `opaque`

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Duplicate references

Duplicate normative references to:
`https://csrc.nist.gov/publications/detail/fips/197/final`.

### Outdated references

Document references `draft-ietf-cellar-tags-09`, but `-10` is the latest
available revision.

Document references `draft-ietf-cellar-codec-09`, but `-10` is the latest
available revision.

### URLs

These URLs in the document can probably be converted to HTTPS:

 * http://web.archive.org/web/20110214132246/http://labs.divx.com/node/16602
 * http://web.archive.org/web/20101222001148/http://labs.divx.com/node/16601
 * http://web.archive.org/web/20160609214806/https://www.fourcc.org/yuv.php
 * http://web.archive.org/web/20160609214806/https://www.fourcc.org/rgb.php

### Grammar/style

#### Section 3, paragraph 3
```
ch should have been used instead. Therefore Matroska writers MUST NOT use EBM
                                  ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Therefore".

#### Section 4.4, paragraph 33
```
--------+ Figure 9: Representation of a Attachments Element. The Tags Element
                                      ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 5.1.4.1.29.2, paragraph 3
```
s this is the ID of the public key the the data was encrypted with. stream c
                                   ^^^^^^^
```
Possible typo: you repeated a word.

#### Section 5.1.4.1.31.6, paragraph 5
```
g ID to identify the Chapter. For example it is used as the storage for [Web
                                  ^^^^^^^
```
A comma is probably missing here.

#### Section 5.1.7.1.4.11, paragraph 1
```
SHOULD include a CRC-32 Element as a their first Child Element. The Segment
                                   ^^^^^^^
```
A determiner cannot be combined with a possessive pronoun. Did you mean simply
"a" or "their"?

#### Section 5.1.8.1.1.3, paragraph 1
```
yframe flag and Discardable flag. Otherwise everything is the same. Bit 0 is
                                  ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Otherwise".

#### Section 6, paragraph 1
```
er flags are set to 00. The Block for a 800 octets frame is as follows: +====
                                      ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 10.4.2, paragraph 8
```
multiplied Block Timestamp is a floating values in nanoseconds. The Matroska
                              ^^^^^^^^^^^^^^^^^
```
The plural noun "values" cannot be used with the article "a". Did you mean "a
floating value"?

#### Section 10.4.2, paragraph 8
```
-2 form [ISO639-2] (like "fre" for french), or such a language code followed
                                   ^^^^^^
```
"French" needs to be capitalized when you are referring to the language or
country.

#### Section 10.4.4, paragraph 1
```
 image SHOULD be presented with a 90 degree counter-clockwise rotation, with
                                  ^^^^^^^^^
```
When "90-degree" is used as a modifier, it is usually spelled with a hyphen.

#### Section 11.1.1, paragraph 3
```
ding to the cumulative duration of the the previous Ordered Chapters. As an
                                   ^^^^^^^
```
Possible typo: you repeated a word.

#### Section 11.3, paragraph 2
```
ack with a UID and all its flags. However the codec ID is meaningless becaus
                                  ^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "However".

#### Section 12, paragraph 2
```
red in the same channel as the track its linked to. When content is found in
                                     ^^^
```
Did you mean "it's" (contraction of "it is/has")?

#### Section 16.2, paragraph 2
```
during the film, which is an unusual specialized audio service that Matroska
                             ^^^^^^^^^^^^^^^^^^^
```
Make sure that the adjective "unusual" is correct. Possibly, it should be an
adverb (typically ~ly) that modifies "specialized". Possibly, it should be the
first word in a compound adjective (hyphenated adjective). Possibly, it is
correct.

#### Section 17, paragraph 1
```
udio tracks and finds that multiple seem equally and maximally preferable, i
                                    ^^^^
```
The verb "seem" is plural. Did you mean: "seems"? Did you use a verb instead of
a noun?

#### Section 17.2.1, paragraph 2
```
 only found in ordered chapters Furthermore there are other EBML Elements wh
                                ^^^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Furthermore".

#### Section 18.8, paragraph 2
```
 ChapterFlagHidden flag works independently from parent chapters. A Nested Ch
                              ^^^^^^^^^^^^^^^^^^
```
The usual collocation for "independently" is "of", not "from". Did you mean
"independently of"?

#### Section 19.2, paragraph 9
```
d.(jpg|png). The filenames are case sensitive. The following table provides
                               ^^^^^^^^^^^^^^
```
This word is normally spelled with a hyphen.

#### Section 20.1.2, paragraph 1
```
on. This Font Name can be different than the Attachment's FileName, even when
                                    ^^^^
```
Did you mean "different from"? "Different than" is often considered colloquial
style.

#### Section 20.1.2, paragraph 6
```
nts were used in existing files. Therefore it is RECOMMENDED for a Matroska
                                 ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Therefore".

#### Section 20.1.3, paragraph 1
```
e file extension check MUST be case insensitive. Matroska writers SHOULD use
                               ^^^^^^^^^^^^^^^^
```
This word is normally spelled with a hyphen.

#### Section 20.2.2, paragraph 3
```
e stream has neither a SeekHead list or a Cues list at the beginning of the
                                     ^^
```
Use "nor" with neither.

#### Section 20.3, paragraph 2
```
s Void Element should be adjusted depending whether the Matroska file already
                                  ^^^^^^^^^
```
The verb "depend" requires the preposition "on" (or "upon").

#### Section 20.4, paragraph 2
```
fore all the locations are known. Therefore shis layout is rarely used. * Se
                                  ^^^^^^^^^
```
A comma may be missing after the conjunctive/linking adverb "Therefore".
Also, shis -> this?

#### Section 20.4, paragraph 2
```
a Reader could include: * Storage of a arbitrary and potentially executable d
                                     ^
```
Use "an" instead of "a" if the following word starts with a vowel sound, e.g.
"an article", "an hour".

#### Section 20.5.1, paragraph 3
```
be allocated according to the "First Come First Served" policy [RFC8126]. The
                                     ^^^^
```
It seems that a comma is missing.

#### Section 27.1, paragraph 12
```
be allocated according to the "First Come First Served" policy [RFC8126]. Cha
                                     ^^^^
```
It seems that a comma is missing.

#### Section 27.1, paragraph 12
```
erTrackUID and MasterTrackSegUID should must be present and BlockGroups for t
                                 ^^^^^^^^^^^
```
Two modal verbs in a row. Did you mean: "should, must", "should" or "must"?

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool