IETF Logo Mail Archive

Re: [Cellar] AD Review: draft-ietf-cellar-ffv1

Adam Roach <adam@nostrum.com> Thu, 09 January 2020 21:15 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6343212081B; Thu, 9 Jan 2020 13:15:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.98
X-Spam-Level:
X-Spam-Status: No, score=-1.98 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5cbtRd06IzLX; Thu, 9 Jan 2020 13:15:22 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BCE60120810; Thu, 9 Jan 2020 13:15:22 -0800 (PST)
Received: from Svantevit.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id 009LEVhb092544 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 9 Jan 2020 15:14:34 -0600 (CST) (envelope-from adam@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1578604475; bh=rbZvymW+pl7ew74FCdxNgDnFGxP9t3QHVKb6CcpULJ8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=eB64K6Gb20Eau4OklqMc1lr+b2fIiIUkUxmG9yCcyICKAX24QRTLMGnlYkw/lkGg7 TyfVFHQjNa4VjS045eRHlxj7r2c2YS8lMce7kAtbyjP+VhYheqyVhOb+Dlqgew04+K 9iQYtL0BshLQ5s4URzDcBORH01bVPrqZPuvxi9gA=
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.local
To: Michael Niedermayer <michael@niedermayer.cc>, Dave Rice <dave@dericed.com>
Cc: cellar@ietf.org, draft-ietf-cellar-ffv1.all@ietf.org
References: <b71e9496-c924-b970-9094-2b29ba173bdd@nostrum.com> <7DDCA42B-8BDA-4EBD-9C04-F0615265E021@dericed.com> <20200109182335.GH1173@michaelspb>
From: Adam Roach <adam@nostrum.com>
Message-ID: <95c9d576-3683-208f-4e0a-0fa0cba70c42@nostrum.com>
Date: Thu, 09 Jan 2020 15:14:26 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20200109182335.GH1173@michaelspb>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/quDtJkbtEsZHGkbsl-J3-gfmTUw>
Subject: Re: [Cellar] AD Review: draft-ietf-cellar-ffv1
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jan 2020 21:15:24 -0000

On 1/9/20 12:23 PM, Michael Niedermayer wrote:
> The implementation definedness can be avoided by simply refering to an implementation
> and not just "C90" or other. not sure "twos complement" is strictly enough but it
> may be the cleanest way to specify it.


I don't think "two's complement" clearly indicates sign extension versus 
zero padding. I think you need to clearly specify precisely what happens 
to new high-order bits during a right-shift.

/a

v2.23.0 | Report a Bug | By Email