Re: [Cellar] Adam Roach's Discuss on draft-ietf-cellar-ebml-15: (with DISCUSS and COMMENT)

Adam Roach <adam@nostrum.com> Tue, 17 December 2019 19:57 UTC

Return-Path: <adam@nostrum.com>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E055120883; Tue, 17 Dec 2019 11:57:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.28
X-Spam-Level:
X-Spam-Status: No, score=-1.28 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, KHOP_HELO_FCRDNS=0.4, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (message has been altered)" header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2EYbPm44C-ZC; Tue, 17 Dec 2019 11:57:00 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0803120077; Tue, 17 Dec 2019 11:57:00 -0800 (PST)
Received: from Svantevit.local (99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id xBHJu8tX017992 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 17 Dec 2019 13:56:10 -0600 (CST) (envelope-from adam@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1576612571; bh=97LFby15o1UMhRWqM02RiT73X4AnBEEVg6JBIZLzdFE=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=N4USaSiqqwh+IE8lZ8igHtShPTE1daGGcZKy3nTmZXtVVwqlskomjiWr7HVeVcCzG uEy4IQ7XQa02Q9CmsSsKreFO7IQ39uT+Y6ljUg1vhfQny0LdrkgfdFyk0zI2uPWT3K 09NVvCqX9AaaPS0l268S/mJRVci8VBXdrEw7YA1w=
X-Authentication-Warning: raven.nostrum.com: Host 99-152-146-228.lightspeed.dllstx.sbcglobal.net [99.152.146.228] claimed to be Svantevit.local
To: Dave Rice <dave@dericed.com>
Cc: Steven Villereal <villereal@gmail.com>, draft-ietf-cellar-ebml@ietf.org, The IESG <iesg@ietf.org>, cellar-chairs@ietf.org, cellar@ietf.org
References: <157656052355.24550.17056837047628625307.idtracker@ietfa.amsl.com> <2D4A95A1-B570-47C7-B040-923EF3F24C9C@dericed.com>
From: Adam Roach <adam@nostrum.com>
Message-ID: <69d0eb8f-f790-293c-0cd9-deadc915254f@nostrum.com>
Date: Tue, 17 Dec 2019 13:56:02 -0600
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <2D4A95A1-B570-47C7-B040-923EF3F24C9C@dericed.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/vgs9s5NHyN86h8hZlrb1anAr1wo>
Subject: Re: [Cellar] Adam Roach's Discuss on draft-ietf-cellar-ebml-15: (with DISCUSS and COMMENT)
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Dec 2019 19:57:03 -0000

Dave --

Thanks for the quick response! The issues that the PR addresses look 
good to me. Two comments inline below.

On 12/17/19 9:27 AM, Dave Rice wrote:
>
>>
>> Abstract:
>>
>> I see that the Introduction has been revised to address Ben Campbell's AD
>> review comment regarding the document positioning itself as a 
>> general-purpose
>> data format rather than being scoped to its use in Matroska. The Abstract
>> still claims the much broader scope -- please update it to match the 
>> reduced
>> scope in the Introduction.
>>

I didn't see a response to this discuss point. See also the GENART 
review, which raises this issue in some detail.



>>
>> §17.1:
>>
>>> The VINT Data value of one-octet Element IDs MUST be between 0x01 and
>>> 0x7E.  These items are valuable because they are short, and need to
>>> be used for commonly repeated elements.  Values from 1 to 126 are to
>>> be allocated according to the "RFC Required" policy [RFC8126].
>>
>> This, combined with the values that are being registered, is extremely
>> confusing, and I don't know how IANA is supposed to understand what's 
>> going on
>> without reading and understanding the VINT bit encoding scheme (which 
>> is way
>> too much to ask of them). This is because of the document-wide practice
>> of speaking of IDs in their VINT-encoded values (e.g., 0xBF) instead 
>> of their
>> data values (e.g., 63 or 0x3F), including in the initial registry in 
>> this section.
>>
>> Please either revise the prose to speak in terms of VINT-encoded values
>> (e.g., "MUST be between 0x81 and 0xFE"), or revise the registration
>> tables to indicate the VINT data values (e.g., "0x3F" for CRC-32).
>
> I understand the request and the reason for it and am interested in 
> assessing rough consensus amongst the other authors before making this 
> change. These elements have been long-associated with these particular 
> vint expressions of the Element IDs, so I have some concerns that a 
> global change of Element ID reference from VINT to the Element Data of 
> that VINT would confuse readers.


Given that information, I imagine that the better path would be revising 
the IANA instructions to operate on VINTs ("MUST be between 0x81 and 
0xFE") instead of VINT element data. This should be very 
straightforward, as the encoding of VINTs results in contiguous ranges 
that should be easy for IANA to deal with.


/a