[Cellar] A few minor comments on draft-ietf-cellar-ebml-13

"Alexey Melnikov" <aamelnikov@fastmail.fm> Thu, 24 October 2019 12:47 UTC

Return-Path: <aamelnikov@fastmail.fm>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 76B4F12010C for <cellar@ietfa.amsl.com>; Thu, 24 Oct 2019 05:47:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fastmail.fm header.b=TspNTv7Z; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=P/qTHS8R
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hbUzbfGgmJ6o for <cellar@ietfa.amsl.com>; Thu, 24 Oct 2019 05:47:39 -0700 (PDT)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4BB3F120105 for <cellar@ietf.org>; Thu, 24 Oct 2019 05:47:39 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B059C455 for <cellar@ietf.org>; Thu, 24 Oct 2019 08:47:38 -0400 (EDT)
Received: from imap1 ([10.202.2.51]) by compute7.internal (MEProxy); Thu, 24 Oct 2019 08:47:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= mime-version:message-id:date:from:to:subject:content-type; s= fm1; bh=t2F6GP7jblLUXjKEzQXzbrRLdHweawIu7QJsD//3nR4=; b=TspNTv7Z lFTGTeXSQ25VLZM0hM10vYCsgGzX08sA0GXZ9/NHSJcHyOjamT13cjlv2OY0hqvr /IA8NjA2Y/4CldkbMhwKu9+BKJ8AWsKBmA3Urj+iCYNJQMlNuwboFslZe2ha0ndR Li2yGQxg9gJ0G32F/Sk2fIGOYlxI7mYP4U/qr1fvUUIUCnHOo4wmWaL1fG1MnQMi u0oSNwjA8ezf5ExuixyinFDoCiXEC42hjvFflKyXa+YDNYh65qkhi2keruTIXM2T jkoSkI4HU/19ZM9E8NYFemf9KNj8JLnRkqCUPeSyta/972YH/UFCzQ1LnFHVAfoR axDO3M81xpNGcQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=t2F6GP7jblLUXjKEzQXzbrRLdHwea wIu7QJsD//3nR4=; b=P/qTHS8R38v9jJhBZBTY58dDNpZky1aE7pG69SkIz4kB/ 9T0I/Lo3DSfsIJ7rFNj0L35SR6yWIYiOpGgfh5MuVhA/AWWk19c+I4+Z1w20wC7u /CfZ21BQMdr0evz9jn9I47SWEzcGvu74EbkgsLlAlIf8qNtiOvppXb+LF3jLYekZ VAl+hoXxcUim3OmPlJEoh/CtpY5JLcRQVo8W2gloFpIT3pId+ui25VIla/wG/URV ab/gjOMLEmlqQx05GEeY91JVZIZR1tW9VBMA5M7akBLjAC2zT3oyX8zZjTTlOayk P2/k6WgUGhRtkf/xETFjpe4ga4ffkXTzpNBK+LRNA==
X-ME-Sender: <xms:ap2xXexF_am95CdXVYj0A9Bobuy5ZbINzwlMusNMYULWIfqNXSCNyw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrledugdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre ertdenucfhrhhomhepfdetlhgvgigvhicuofgvlhhnihhkohhvfdcuoegrrghmvghlnhhi khhovhesfhgrshhtmhgrihhlrdhfmheqnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrg hmvghlnhhikhhovhesfhgrshhtmhgrihhlrdhfmhenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:ap2xXd_A_qhnua5SR6VzAn6CfI25GPziS0_9mIhHyiLuwWDIKX-O-w> <xmx:ap2xXY_Gy8yQU469Tpml6B4e1Dh6Eq22el55GGzqfnRyaMaxduNF_A> <xmx:ap2xXV5MfIWIc_Tbql_IlQ3nB5Y99vbiOgBqmoJlpgN-VH-jSiPkpg> <xmx:ap2xXSJjP0BjLj_K7bCaP6yWJQOem9JUS3dvI_832cQEfcxM_pvWPQ>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 061CAC200A5; Thu, 24 Oct 2019 08:47:38 -0400 (EDT)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-470-gedfae93-fmstable-20191021v4
Mime-Version: 1.0
Message-Id: <f2f44248-6e5d-4719-89fe-28187228822f@www.fastmail.com>
Date: Thu, 24 Oct 2019 13:47:05 +0100
From: Alexey Melnikov <aamelnikov@fastmail.fm>
To: cellar@ietf.org
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/xy0WUr07zuMhwotQrybYN18mI30>
Subject: [Cellar] A few minor comments on draft-ietf-cellar-ebml-13
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Oct 2019 12:47:40 -0000

Hi,

Thank you for addressing most of my AD review comments. I followed up on a few remaining issues in a separate thread.

I just reviewed changed since version -10 and have a few new minor comments:

I think [W3C.REC-xmlschema-0-20041028] should be a Normative Reference, because of how it is referenced in Section 11.1.15. (I assume the XML Schema there is normative.)

It would be good to have an example of <implementation_note> in the document.

In Section 11.1.5.8 the following test was added:

   An unwritten mandatory
   Element with a declared default value is semantically to that Element

I think the word "equivalent" is missing after "semantically".

   if written with the default value stored as the Element Data.

I would ask editors to address these in the next revision. However the above are not serious enough to delay IETF LC, so I will start it now.

Best Regards,
Alexey