Re: [Cfrg] draft-mcgrew-hash-sigs implementation and findings

Paul Selkirk <paul@psgd.org> Fri, 06 April 2018 04:30 UTC

Return-Path: <paul@psgd.org>
X-Original-To: cfrg@ietfa.amsl.com
Delivered-To: cfrg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C04E512E87C for <cfrg@ietfa.amsl.com>; Thu, 5 Apr 2018 21:30:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.235
X-Spam-Level:
X-Spam-Status: No, score=-6.235 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_SOFTFAIL=0.665] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QWZcRDRScGZJ for <cfrg@ietfa.amsl.com>; Thu, 5 Apr 2018 21:30:38 -0700 (PDT)
Received: from psg.com (psg.com [IPv6:2001:418:1::62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1FD0E127863 for <cfrg@ietf.org>; Thu, 5 Apr 2018 21:30:37 -0700 (PDT)
Received: from [73.119.134.196] (helo=[192.168.1.170]) by psg.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1 (FreeBSD)) (envelope-from <paul@psgd.org>) id 1f4J1I-000Q0k-Mz; Fri, 06 Apr 2018 04:30:36 +0000
To: "Scott Fluhrer (sfluhrer)" <sfluhrer@cisco.com>
Cc: "cfrg@ietf.org" <cfrg@ietf.org>
References: <5d590027-50d9-637e-8ef0-9b5a8ac22565@psgd.org> <f9d4c3bbf70c43948f2b49cef41de8a0@XCH-RTP-006.cisco.com>
From: Paul Selkirk <paul@psgd.org>
Openpgp: preference=signencrypt
Autocrypt: addr=paul@psgd.org; prefer-encrypt=mutual; keydata= xsBNBFOWH1IBCADNXe/g3+5BWdSlzNhfDgrpnvbzWlcZgPdi7oWq4wd5ueufRPGggQ/bg89M KbgEj9ZOoJ0Nb6rJk0oxA3FDcumtOSlm9I1wgttG72YDNfFGeyDv2Gx2bPqRHxlzKe/GSQCa sbx0/alHD/PbmZpKAQ9dI0fGn59m3cbptmWckMsm7E0C+qnwasdiOL3CvM6JDh0W1Ty95oVj XkW5T4lFuNgepWWaTm6A9DIdReZ1pI2Hplj6AWF99fPE/N0dh44wie1OIVPW4sWp+RVJZvlA LqodwHzGpq7r6iAYawew2KqodQkr5nISRUCk3qWsaBJWDeYU0DEZ0+w55BfVTSh4V8aFABEB AAHNHFBhdWwgU2Vsa2lyayA8cGF1bEBwc2dkLm9yZz7CwHgEEwECACIFAlOWH1ICGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJELAqzRn9CEWT5zQH/Rbfjyi/5CvsetK7JjAOVCKb TfFOk2eiXmC1lrCKiy41u1jxYl7zi3y3xwaMRSVWd2xzhc3unwf93T4D5B3yxrw1CssbWUAr XnfNZ3fA9SxRpzNeQJ4WgNL1Jq2vgTzY5TxOmJhM3eyZRCeTzQDLkdH8misqNA12dOSrWaCa SolVYdYMO1PMBNGGBpQC4EcUp1VlWy5/y0kV8fcNhq4kqE5EemnTWGCY/oQXejXat5t2MiMv Rv3pBkHOp+KezqD1bwea7YA9jYoa1y/VZ5x5WICjEemDXBV+7KxDUtEdcoCyzu3e79P3Rws2 tLJqssJni49I9Z3gOF+AWo7NVNaOFzfOwE0EU5YfUgEIAMW+bvQ6MlJ5EOhNuJmL/V9kNgO/ qtVIugWaia7rdwv+jHeP3JyTZFBSdtc10FsgyzNaA2aXSprdc0OWGspWyj540nL5U0DoNLVC sm3gzTd95oA/OmAHSlI05Y4aNhWzq9KDBe/3BlVZH4qTV0ndtfwFKa8uGNRLm7DzbnWkoZhE 5Bs0X3b3XwiYt3BJdK8CFJMzDKTlW0VSwfWdjNofs2gk72QEvwKZTfyQZs2J6e3/xpxQsecM HkL4Mv+FLu9f8s4RlJ1Klv7uKOKOH+WoCnEOg+RckOf3QxtT0VBe5bmiETF0VpVW1hN6frYm B11jPeWQJpNQgGIgnU14f0IRYJkAEQEAAcLAXwQYAQIACQUCU5YfUgIbDAAKCRCwKs0Z/QhF k5eXCACdjmUo91/9cXlJAiw6AAsQgT8eJiKkNrrYjpRlpMC73biT1uqU7S+IYiFhKxAxTA0i rwkZtZz3jrxLk0Rc/eI5PqnpW4WVUejEYkA1SuUHyhDRFl62LOXsMU+aLekYe0iEOC5gan8O vcRf9HK4w6xMn73mzpRnZ6hOe/L/nit7xcuIdn0611hw6edVeskb89AsRKPKIDaQDjp+gEZq oX9VzpyPa+lnxzRtrz6PISLKNbZ9q5uRPdOL6dFJ2dLSZWGD/fa5U/9jBfDvYmzCplUNKIDI ht3Z3U7wKzoEYxruHGnPcHSNC1Qlu3ZAxQIsFfw1LVvjCmIbxjd49LgAdd2y
Message-ID: <08b1e675-7d2d-7b49-df0a-b8c2ac660db5@psgd.org>
Date: Fri, 06 Apr 2018 00:30:35 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <f9d4c3bbf70c43948f2b49cef41de8a0@XCH-RTP-006.cisco.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/cfrg/HGy0RLHRUXMKUvqhTQ0ZJGkej-c>
Subject: Re: [Cfrg] draft-mcgrew-hash-sigs implementation and findings
X-BeenThere: cfrg@irtf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Crypto Forum Research Group <cfrg.irtf.org>
List-Unsubscribe: <https://www.irtf.org/mailman/options/cfrg>, <mailto:cfrg-request@irtf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cfrg/>
List-Post: <mailto:cfrg@irtf.org>
List-Help: <mailto:cfrg-request@irtf.org?subject=help>
List-Subscribe: <https://www.irtf.org/mailman/listinfo/cfrg>, <mailto:cfrg-request@irtf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2018 04:30:40 -0000

On 04/04/2018 08:16 PM, Scott Fluhrer (sfluhrer) wrote:
> Ok, I went through all your suggestions (from both reviews), and I've modified the draft accordingly.

Thank you for your kind reply. I look forward to seeing the updated draft.

> so that I ideally won't have to have a -12 version

FWIW, the one draft I was intimately involved with (pcp-base) went to
-29 before it was accepted as an RFC. I don't wish that on you, or
anyone else, but it's a thing that sometimes happens.

> - One thing that was constantly raised was the relative lack of pseudocode.  Part of this is our intentions; we wanted people to understand what the data structures and algorithms are, and if we included any pseudocode, it was with the hope that it would be informative, not normative.

Okay, but in most cases the pseudocode *is* normative - i.e. you can't
implement the draft without implementing some form of the pseudocode;
the text does not adequately describe what needs to happen.

While we're on the subject, section 7 has XDR format definitions for
keys and signatures - are they normative or informative? If XDR encoding
(big-endian, 4-byte padded) is mandatory (which it seems to be), you
might say so in the text.

More comments maybe after more sleep...

				paul