Re: [CFRG] HPKE: final call for objections on the changes

[Christopher Wood <[e-mail]>]

On Thu, Aug 5, 2021, at 1:46 AM, Martin Thomson wrote:
> I have read, implemented, and deployed the changes in HPKE since -07.
> 
> I do want to confirm however that the change in test vectors between 
> -08 (where the final version string was added) and -09 was just the 
> result of missing the test vectors in the -08 update.  I've code that 
> uses the source JSON file, which were updated one day after -08 was 
> published.

-08 was not missing test vector updates. The test vector changes in -09 came from renaming some fields in the test vector generation code, and then rerunning that code:

   https://github.com/cfrg/draft-irtf-cfrg-hpke/pull/224

The JSON file in the repository matches those in the latest version of the document. (These have been checked and confirmed by multiple people, though we welcome additional confirmation.)

> Nit: in \S9.7.5, the first sentence could use an em-dash (' - ' or ' -- 
> ' to taste):
>    If the randomness used for KEM encapsulation is bad - i.e., of low	
>    entropy or compromised because of a broken or subverted random 
> number	
>    generator - the confidentiality guarantees of HPKE degrade	
>    significantly.

Done: https://github.com/cfrg/draft-irtf-cfrg-hpke/pull/236

Best,
Chris