[core] Re: Review of draft-ietf-core-dns-over-coap-11

Martine Sophie Lenders <martine.lenders@tu-dresden.de> Thu, 13 February 2025 11:35 UTC

Return-Path: <martine.lenders@tu-dresden.de>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEEF8C180B41; Thu, 13 Feb 2025 03:35:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.405
X-Spam-Level:
X-Spam-Status: No, score=-4.405 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=tu-dresden.de
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EFqhhjY4N-px; Thu, 13 Feb 2025 03:35:07 -0800 (PST)
Received: from mailout3.zih.tu-dresden.de (mailout3.zih.tu-dresden.de [141.30.67.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1304BC14F6A8; Thu, 13 Feb 2025 03:35:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tu-dresden.de; s=dkim2022; h=Content-Type:In-Reply-To:From:References:CC:To :Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XGuPUspLpAXm3RznqATDsxUYryKdrQy/IzgiAryW/sc=; b=tTQ2c7KLm1IioXRK9nQI1McGY+ uQAhB31VYGPTWwjjPioFnIVBwusraXqYMdG0H5x2H5UEdh6jbJOQwUTGm9YXEXfA63I5bCknyBt3T UkX+IJNCmV+pmWbSEi1nobYJBAtCABskgLWNgVZoNtgCYr7P5QuGWq+zNbHn5rUuQwQrGLvWjbZBB nz71+P6mlno5vKiM+c6p/M0/D/+OAYthI0bd+e/1fUUnClU+8UJp89Zbm1O1dSAhLDLokv4zFd8jD JDuXqOIvf3JQaIu3+gI6C6IZa9Vrz1vK/sAoHpP6YPcdAxlYYBHoQIUO+7Mle47bxZomjZ/yWsVwq vpenTF4g==;
Received: from [172.26.35.138] (helo=msx.tu-dresden.de) by mailout3.zih.tu-dresden.de with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <martine.lenders@tu-dresden.de>) id 1tiXUn-007x4G-Pr; Thu, 13 Feb 2025 12:35:05 +0100
Received: from [192.168.101.107] (84.143.155.52) by msx-t421.msx.ad.zih.tu-dresden.de (172.26.35.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 13 Feb 2025 12:34:57 +0100
Message-ID: <337a25a9-7300-4cbd-b616-8bd5b437c16a@tu-dresden.de>
Date: Thu, 13 Feb 2025 12:34:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Carsten Bormann <cabo@tzi.org>, "core@ietf.org WG (core@ietf.org)" <core@ietf.org>
References: <1096b4a0b6a24fa4928eb776dd79a0d2@msx-t421.msx.ad.zih.tu-dresden.de>
Content-Language: en-US
From: Martine Sophie Lenders <martine.lenders@tu-dresden.de>
In-Reply-To: <1096b4a0b6a24fa4928eb776dd79a0d2@msx-t421.msx.ad.zih.tu-dresden.de>
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha-512"; boundary="------------ms010806090405090907000104"
X-ClientProxiedBy: MSX-L420.msx.ad.zih.tu-dresden.de (172.26.34.140) To msx-t421.msx.ad.zih.tu-dresden.de (172.26.35.138)
X-TUD-Virus-Scanned: mailout3.zih.tu-dresden.de
Message-ID-Hash: H5JRBXDLTCJMTN64QR7MC76BUAQ5ETG7
X-Message-ID-Hash: H5JRBXDLTCJMTN64QR7MC76BUAQ5ETG7
X-MailFrom: martine.lenders@tu-dresden.de
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-core.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-core-dns-over-coap@ietf.org" <draft-ietf-core-dns-over-coap@ietf.org>
X-Mailman-Version: 3.3.9rc6
Precedence: list
Subject: [core] Re: Review of draft-ietf-core-dns-over-coap-11
List-Id: "Constrained RESTful Environments (CoRE) Working Group list" <core.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/2hyjF9gnAde-9Jp_OLjmfjzlpD8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Owner: <mailto:core-owner@ietf.org>
List-Post: <mailto:core@ietf.org>
List-Subscribe: <mailto:core-join@ietf.org>
List-Unsubscribe: <mailto:core-leave@ietf.org>

Hello Carsten,

again, thanks for the review!

Since I sometimes used different wordings than we discussed in 
yesterday's interim to fix the issues you pointed out, I opened 
https://github.com/core-wg/draft-dns-over-coap/pull/39.

Best
Martine

On 12.02.25 15:18, Carsten Bormann wrote:
> Below is a quick review of draft-ietf-core-dns-over-coap-11 ahead of the meeting in 40 minutes.
> A number of nits that probably don’t need more attention beyond merging them are in PR #[38], the rest is quickly summarized below.
> 
> Grüße, Carsten
> 
> ## Minor
> 
> The DNS update discussion uncovered that we are not really addressing
> anything but DNS queries (OPCODE = 0).  This could be made clear in a
> general scope statement about opcodes: this doc is only about opcode 0.
> Section 4.3.3 would then not be necessary.
> 
> We probably need an example for a "Not Implemented" response triggered
> by an unsupported opcode.
> 
> 4.3.1: what is a "valid DNS response" (not defined by RFC 1035)?
> 
> 4.3.1 "Communication errors with a DNS server (e.g., timeouts) SHOULD be indicated
> by including a SERVFAIL DNS response in a successful CoAP response."
> -- what is an exception to this?  Should this not be a MUST?
> 
> 5.3 "it is NOT RECOMMENDED".  Not sure what "it" is.  Directly mapping
> CoAP to HTTP without the use of a DNS server?
> 
> s/Unencrypted/Unprotected/ (it seems the text using "unencrypted" is
> mostly about not having integrity protection)
> (and s/unencrypted/unprotected/ as well)
> 
> ## Nits
> 
> Nit fixes have been collected in PR #[38]
> 
> [38]: https://github.com/core-wg/draft-dns-over-coap/pull/38
> 
> Some I did not want to just fill in:
> 
> ### Typos
> 
> (Nits listed:)
> 
> ... Clarify that DoC and DoC are...
> 
> ### Editorial
> 
> (Nits listed:)
> 
> * prevent TCP and HTTPS resource requirements
> * prevent resource requirements of DTLS or TLS
> 
> (We don't prevent these requirements, we cause them not to apply)
> 
> CoAP resource identifier
> 
> (Not a defined term)
> 
> For reliability and energy saving measures content decoupling and thus
> en-route caching on proxies takes[...]
> 
> (can't really parse)
> 
> refresh stale cache entries without large messages
> 
> (neither -- when do stale cache entries have large messages?)
> 
> algorithm to assure the requirement for the DoC
> 
> (one more)
> 
>