[core] Artart last call review of draft-ietf-core-oscore-edhoc-09

Shuping Peng via Datatracker <noreply@ietf.org> Tue, 14 November 2023 09:27 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: core@ietf.org
Delivered-To: core@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B220C14CF18; Tue, 14 Nov 2023 01:27:10 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Shuping Peng via Datatracker <noreply@ietf.org>
To: art@ietf.org
Cc: core@ietf.org, draft-ietf-core-oscore-edhoc.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 11.14.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <169995403049.46907.612833618941949882@ietfa.amsl.com>
Reply-To: Shuping Peng <pengshuping@huawei.com>
Date: Tue, 14 Nov 2023 01:27:10 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/2jCRvv6eWQxP7RMu0WPulmVHi4E>
Subject: [core] Artart last call review of draft-ietf-core-oscore-edhoc-09
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2023 09:27:10 -0000

Reviewer: Shuping Peng
Review result: Ready with Issues

I am the assigned ART-ART reviewer for this draft.

Summary:
I have some minor concerns about this document that I think should be resolved
before publication.

Comments:
I think this document is basically ready for publication.

Major Issues:
"No major issues found."

Minor Issues:
Where the "C_R" is actually carried is not clear. It would be good if the
following text in Section 3 could be more clear about it, and it might also be
helpful to show the "C_R" in Figure 2. "     EDHOC data consisting of the pair
(C_R, EDHOC message_3) required
      for completing the EDHOC session.  Note that, as specified in
      Section 3.2, C_R is transported in the OSCORE Option of the OSCORE
      Request rather than in the CoAP payload of the EDHOC + OSCORE
      request.
"