Re: [core] [art] Artart last call review of draft-ietf-core-senml-data-ct-04

Francesca Palombini <francesca.palombini@ericsson.com> Thu, 09 September 2021 11:43 UTC

Return-Path: <francesca.palombini@ericsson.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5C5113A1072; Thu, 9 Sep 2021 04:43:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.553
X-Spam-Level:
X-Spam-Status: No, score=-2.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.452, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e0s8gvl8dTG2; Thu, 9 Sep 2021 04:43:30 -0700 (PDT)
Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 78B113A1078; Thu, 9 Sep 2021 04:43:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OViWrdEScKd3+rzYOOaKKbtq70z5qpZ3qz0xqQ52MZE+IPpWmZPTRDfov8bys3A6t9vv+pVZd3+ymtZNApTCCLYJrG3xLBxz5OE/jpOvtADR8dgziLFnqnP5wPudeiuc7MdUcohKIUiownchLWHIboJMQwIf3SYEzCdz9nMXhc9bv4wrRhz04/4Vgcil17CGmOQZ4FrHpa33B5KDFDbJEtZzICOF5RNNf6luAvo1rOExLyWH1zoVmgKT2RFobeA62lSkpJafnujEpiloKIYRItjAObFDfLc2Ju1aIdSAi2gCefvdKtSDxuW8yAqYlB1ni1PMc9KTMaah2e92DkwUqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mJuZfeqD/locQt0tRwtKF61MAq8nnLrYwo7DxCfO1G0=; b=aikRvdq7RjOpA3mPAfIEUicx/mZ/hOBtyXbDu8EAfLHE6tDiGGq/iTfGZT4F/5l1nF0xkKXlGaHlntuDX6m1n++yg5mXfgKkJNABnbSBqm3TZtyZnH4L1W423/6WIXrWb8SeMAX5/In8OceamAYSgcTgcRxosiE68LazjeSFD7fPlcFBIPWoAGAepo8/cPctQB9XEhPG8LLnyjpEwJcWjCQzhD8tzoGrJtEsE1R+MRl1hsCoWE18ykoV+SPS/CtkRipYewVd2jXVEl+LMOUEH0sU3b7JCgKG8jlILD0MEnunV1P3Cvh/ZCNr2ZoiZLMYN7zWl/Wxcu3vOEAzoFpDAg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJuZfeqD/locQt0tRwtKF61MAq8nnLrYwo7DxCfO1G0=; b=Kl4nURFE9SAUyzxeVhAH5dSubVfT0P62S3r7cohLhhQHIMGqLwx/u+3Pp3gNYyDKRLH76t67xs/gyBv77Htkp+zx++CrKkw4lT3bnCVwAPnehmLK3KR4myPN2AH0n+YTXq9he4rJ0gmPg0kBKOwtMZjRJyKsoudMl/pubeODuNg=
Received: from HE1PR07MB4217.eurprd07.prod.outlook.com (2603:10a6:7:96::33) by HE1PR0701MB2426.eurprd07.prod.outlook.com (2603:10a6:3:70::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6; Thu, 9 Sep 2021 11:43:26 +0000
Received: from HE1PR07MB4217.eurprd07.prod.outlook.com ([fe80::94b7:db6b:3aa3:8875]) by HE1PR07MB4217.eurprd07.prod.outlook.com ([fe80::94b7:db6b:3aa3:8875%5]) with mapi id 15.20.4500.015; Thu, 9 Sep 2021 11:43:26 +0000
From: Francesca Palombini <francesca.palombini@ericsson.com>
To: Carsten Bormann <cabo@tzi.org>, Bron Gondwana <brong@fastmailteam.com>
CC: "art@ietf.org" <art@ietf.org>, "core@ietf.org" <core@ietf.org>, "draft-ietf-core-senml-data-ct.all@ietf.org" <draft-ietf-core-senml-data-ct.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: [art] Artart last call review of draft-ietf-core-senml-data-ct-04
Thread-Index: AQHXmbVnLXYrYpL60UytXyU3w+yR4KuEgFAAgBdNmIA=
Date: Thu, 9 Sep 2021 11:43:26 +0000
Message-ID: <42CEDAAF-0719-4A49-AAE4-EEE2BBC6B3D9@ericsson.com>
References: <162989820511.22802.13018106629607951033@ietfa.amsl.com> <8AE2D0CA-C259-4E4A-8369-601D750DAA9D@tzi.org>
In-Reply-To: <8AE2D0CA-C259-4E4A-8369-601D750DAA9D@tzi.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.52.21080801
authentication-results: tzi.org; dkim=none (message not signed) header.d=none;tzi.org; dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8f321c9d-93a0-4dcd-eab3-08d97387097f
x-ms-traffictypediagnostic: HE1PR0701MB2426:
x-microsoft-antispam-prvs: <HE1PR0701MB2426AC54BABD7E8A52E9FB6E98D59@HE1PR0701MB2426.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7lNYor9kQXPizPFJ4pM+vfgVWyF9hNGcJmv8GB2u39BDDY4qCZQyCwOp1IweQzmPp/hKtIZqJCv/8ztNEpSKRgnekW+dwHC7yN0Dar55zSCCtDfAz6ljqusXgXPo+P8RkDR7aeOCIr3r7c92Qqk8DC5eC2miDHUORuP/AiuKfpYRTQJQZg5tSsm0rDyrJoeiIysSa5Nwcbj5NDpz7cZDLhP74CbL8u3EisBu+n9TWhiMvETEL1q5OboN4FW6jSCtnkZFjg+5IuhyP8DBOKXGi5GV6xH25WnHp/QczE6Or7wt4zoKO8d4tzvWTS2zVV89/SFhdR1O3BD/yD0Aon8dq0xQ9AxeTPzTLn5rqhF4dcZg8cQ0xF/Ag0Z8dma77Dm01cq6pxVcS1o0g0ssKShOpVp2f9ju2mdMwCSSDgfKdSqiHE6wdAPlb7zceS+gbT88dci8VBt1mYCT6PA9cKBpUmBd1aI9d7k25b8xhk/CvEY5T9zBCMWjth8LGzy38kDYOhKZpa6Q981a7sKgc5ylXV/Nnam499QqlzUD1D3Iw6Ubl1RSkeQzXDG/vOEIgyD412DYX2WYqwuMUYfwJ5kFS9CTwb2WjlOUSFWvQd+MFF5w8q5LK3TdCeDx8Cr/cobr8jgXeDDbpxyWLpg8vC5Jg0C9sVjXEYJ0PPe34a0NMfBd/BTCJR047xem412MLpUv76hwAbcR2ipgh+bCfV+cF7HcE4PIjELNxWwJOxpdrrCUPEBWon/NVVBzpsTRjrazrdJfP58BmabDXUk9+68pldbU+QWbUCdbYw2kp4dAiyGY2Zf2sT8h1f/U4Pee28NWXJVjlJZk7faESjeF43pRBmQG6vXlJt9ZcfLymNpmLME=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4217.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(376002)(39860400002)(136003)(36756003)(5660300002)(64756008)(66476007)(4326008)(122000001)(33656002)(38070700005)(6512007)(8676002)(6506007)(66946007)(8936002)(71200400001)(478600001)(66446008)(38100700002)(2616005)(6486002)(54906003)(110136005)(316002)(83380400001)(2906002)(44832011)(86362001)(186003)(966005)(66556008)(76116006)(45980500001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MVNYdkRhb0Q3UUhHOTJNYjJPSldTa3lXMlhOY3F5ZmN2MkVmeGtVOG1PQ3NJ?= =?utf-8?B?QVlxdTlLdytxQmh0U2VpVjJ1cTMwZGkvMk4vOFIxK3ZXeTFubTgvZ01RcVBB?= =?utf-8?B?dkZoSlp1d25BM2UzdkxVK1RHU3c4b2FFd2RMTnpLMGJkL21LVWxENDZKOStM?= =?utf-8?B?T2J0RW5xUkhXWVczM1o1Z1NVMUZMd01Kb1M1bDVENkpUVWM3SzBkbDBtSlJC?= =?utf-8?B?bU5hL29oU3NxKzJuc0cvTGJLbFBXR01ZM1RlZXowZE5MWDBqdlF6NjR3cCtp?= =?utf-8?B?OGVtYWZ0NkR5MGxrRllwYngwRHdBc29HTkx6RVZTd2xPNnJrNHRKWVlqRVNJ?= =?utf-8?B?c2FJakx4WXVHcVI4aHJROHJoOHlnOFh3bk9NemNRSkNYaWVkWXpUT0UzUnRY?= =?utf-8?B?MzFiTmhEeUNvc05pa2ZsQ0laZlNGa1Z3RjNXV3VCb3VKYjZoU3g3aC9kT2p6?= =?utf-8?B?SDlPNXNZSklTZlhUdlo0OHdjTTFqckptWERsQm9MWnRpTTJzc1JieHkzUHBN?= =?utf-8?B?NjdKbEpRNG96eEhVdmpBc0dqQ25PZEdkUmJsbGUrOG1nbFltY3p4TERHYzBG?= =?utf-8?B?Vm1yaElXL29vN2J2OHU0REV6Y2hMQXZUR0RJRktways5b1QrMitRZ0trTys0?= =?utf-8?B?Vk9ESHZDemh4NnNJaVowVDV6bHJtaGtHdVpVRzRacUNCT2RBa1VhaTNaZmRu?= =?utf-8?B?WVE2MXJKT1U1TTR4ejlSb05icVJIT0JtMXZxMVZ1L1p3dHlFRjNWMVJaRGky?= =?utf-8?B?V0hVUzNaOWVEbVBHQ2NDZUd4OXBuRjFRRHRzcGoxYTArdDlFSnJIZGVOTG5z?= =?utf-8?B?MGVmMGFGT0t2Y2QwY1ZPYU9udDU0dzlDdmdUYU9yZ0hkeU53bnJUVkdKaEF5?= =?utf-8?B?Q3VxazBJRzBTK3gwMk1GYmVaYnNreUhZVUpleHRRTkVxcVJqbWx6UGtNNzlN?= =?utf-8?B?ekdlMWdwWWRxREVac28vZ29ZRG5EYjdlc0lXQWh3NjBmNG9NOVVjcGtlWXhQ?= =?utf-8?B?R0dhSGxJa0R2aExqOTViQXdRekI4UGphQ2tKSzJNWWxNZ2RlTXRkeEJHbG5O?= =?utf-8?B?SWR4cHZrTVJ5Nk9RS2JUZi84YUtpM1BCUXIxcEc3b1A2SUt0U0hHblg3bjZ4?= =?utf-8?B?K2hZS2xvYXJmS2JpN0Jzb1Q0NWl3dUhDdU5PUWQ3b1BSR2xYV3BRMXVnUnRI?= =?utf-8?B?U1A5YVhoTEs3RGI1ZytxWnErUm4ydVBjM0tRSTFieHFrNkl4cENIQjZRNHU3?= =?utf-8?B?VGNZSnROMFEwb3dOZ0tWTjAvNUs4djg0Vy9Mc24xRkRROUsyYXVMYkxaakll?= =?utf-8?B?VHhIVnd6SDBSYVVZL1NvSm40NTMvWnpYeC9QWEpyR0VuQThldHZLYXJuL2pS?= =?utf-8?B?cmFBcUNqRnJFU2FqcU9oaFgzRWxNbVdTRGFSRWhkU2FzSUZkOHVTaktMVkJ2?= =?utf-8?B?d0NHci96TjdDekVrb0QxSERTS1p3bjNsYmhuQW1oenp0YnNBZ0lUM3VRQjhj?= =?utf-8?B?bG9KMTh1eEZQVjllbklyMWJONHJwOEJMRU4vREsvTUxYMCtsU0h2aHJYbDNy?= =?utf-8?B?VEZTblBrZzVaQTRoQ0t3VjFCaDc2NC9nTHZIMkl0R2FqMmoxRDM5UzdSbXEv?= =?utf-8?B?V1JGckg4NUtaTmUwaCtjQk80UXN5QTRaQXRGdW9VOHgrSFBVNVhNTmxGQUZR?= =?utf-8?B?ekJrWmFQbDBNWGRnRzZpL3hSVmhqWnMzbEx1eURvUHZHVU1Uc3diOWoyR1dX?= =?utf-8?B?ZHlzbUNiYmVPd3hTR001RFV4aXRkakJSKzR0d0UwVjVkcndFNmUwdmlpTDIz?= =?utf-8?B?SVVMRE01WThrRFBjeFJQN0plMWVEdVRLRjdEWk9jZXpMSGt2SUdVSk55Q3dL?= =?utf-8?B?aDNIWFduTFgrMjVoMTA3SGRRZjZZdG9sRjJjT2t2T0ZsRmc9PQ==?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <754C9BCC88284646BC97F9B1B927FEAC@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4217.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f321c9d-93a0-4dcd-eab3-08d97387097f
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2021 11:43:26.5084 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4WAJBCpiE72kKVv0sVXjIzFq9s1QXMpfJS6fVVeu3p5JNC83ahCG6QcFmtGukY5SOjmOWBhs2a7hbfyNeM3W+854KzroccKeW4AjHqU1qXbN7cxLmzfiB5C95Lobiwm9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0701MB2426
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/748g2ixiqFeLthxgCNaF_DLjrrk>
Subject: Re: [core] [art] Artart last call review of draft-ietf-core-senml-data-ct-04
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Sep 2021 11:43:36 -0000

Bron: thanks for this ARTART review! Carsten, authors, thanks for addressing Bron's review. I am waiting on the updated revision before sending the document to IESG.

Francesca

On 25/08/2021, 19:52, "art on behalf of Carsten Bormann" <art-bounces@ietf.org on behalf of cabo@tzi.org> wrote:

    Hi Bron,

    Thank you for this quite actionable review!

    > It is mostly easy to understand, however there is a missing reference to one
    > registry, and some phrases that may be confusing.
    > 
    > The missing registry is here:
    > http://www.iana.org/assignments/http-parameters/http-parameters.xhtml#content-coding
    > (I found it by following normative references, however other similarly
    > registered data fields in this document link to their registries, and could
    > likewise be found by following references)

    I completely agree that we need to become better in identifying the registries that we are using.  Fix below.

    > The document specifies `Content-Coding` as:
    > 
    >   Content-Coding:  a registered name for an encoding transformation
    >      that has been or can be applied to a representation.  Confusingly,
    >      in HTTP the Content-Coding is then given in a header field called
    >      "Content-Encoding"; we *never* use this term (except when we are
    >      in error).
    > 
    > I found this quite confusing, and it also comes across as very snarky and
    > suggesting infighting.  

    (It’s more about being humbled by having made the same mistake before, say in Section 12.3 of RFC 7252…)

    > I suggest removing the "except when we are in error"
    > entirely.
    > 
    > I also found "has been or can be" is also confusing.  In the context of this
    > document, I understood Content-Coding in a `ct` field to mean that said coding
    > HAS BEEN applied to the value in `vd`, however this wording makes me question
    > that assumption.

    That text was stolen from RFC 7231:

       Content coding values indicate an encoding transformation that has
       been or can be applied to a representation.  Content codings are

    But “can be" here probably is more about Accept-Encoding, for which we don’t have an equivalent in SenML, so we can leave this aspect out.

    > Maybe something like this is sufficient?
    > 
    > Content-Coding: a name registered in [IANA.content-coding] as specified by
    > [RFC7230].  Confusingly, in HTTP the Content-Coding is found in a field called
    > "Content-Encoding", however "Content-Coding" is the correct term.

    Combining some better use of references (see your point above) with this input, I came up with:

       Content-Coding:  A name registered in the HTTP Content Coding
          registry [IANA.http-parameters] as specified by Section 8.5 of
          [RFC7230], indicating an encoding transformation with semantics
          further specified in Section 3.1.2.1 of [RFC7231].  Confusingly,
          in HTTP the Content-Coding is found in a header field called
          "Content-Encoding", however "Content-Coding" is the correct term.

    (Links in the HTML version on every section or registry reference, which are not visible in this plaintext copy-paste.)

    Now in https://protect2.fireeye.com/v1/url?k=b63ae234-e9a1db32-b63aa2af-86ee86bd5107-3248b112897beaf1&q=1&e=38e64623-52dd-4890-be02-23258b6d566d&u=https%3A%2F%2Fgithub.com%2Fcore-wg%2Fsenml-data-ct%2Fcommit%2F90a3deb

    > The other confusing section was this in section 3:
    > 
    >  If no "@" sign is present outside the media type parameters, the
    >  Content-Coding is not specified and the "identity" Content-Coding is used -- 
    >  no encoding transformation is employed.
    > 
    > "If no @ sign is present outside" is a really clunky turn of phrase that left
    > me more confused than the examples!  I assume this construction was used
    > because theoretically an '@' sign could be present inside the media-type, or
    > inside a parameter, if correctly quoted.  I would suggest at least changing
    > "present outside" to after, or trailing, or something.
    > 
    > Maybe this?
    > 
    > If no "@" sign is present after the media-type parameters, then no
    > Content-Coding has been specified, and the "identity" Content-Coding is used --
    > no encoding transformation is employed.

    I restructured the paragraph along these lines:

       To indicate that a Content-Coding is used with a Content-Type, the
       Content-Coding value is appended to the Content-Type value (media
       type and parameters, if any), separated by a "@" sign.  For example
       (using a Content-Coding value of "deflate" as defined in
       Section 4.2.2 of [RFC7230]):

       text/plain; charset=utf-8@deflate

       If no "@" sign is present after the media type and parameters, then
       no Content-Coding has been specified, and the "identity" Content-
       Coding is used -- no encoding transformation is employed.

    (Again, a link in the HTML version on the section reference.)

    Now in https://protect2.fireeye.com/v1/url?k=28321037-77a92931-283250ac-86ee86bd5107-7440f4e9314603fa&q=1&e=38e64623-52dd-4890-be02-23258b6d566d&u=https%3A%2F%2Fgithub.com%2Fcore-wg%2Fsenml-data-ct%2Fpull%2F4%2Fcommits%2F4d994bb

    > Other than those two slightly confusing bits, great document - I enjoyed
    > reading it and the intentions, purpose and use of this document are clear.

    Thank you!

    Grüße, Carsten

    _______________________________________________
    art mailing list
    art@ietf.org
    https://www.ietf.org/mailman/listinfo/art