Re: [core] AD review of draft-ietf-core-senml-data-ct-04

Carsten Bormann <cabo@tzi.org> Mon, 06 September 2021 09:01 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C98703A081C; Mon, 6 Sep 2021 02:01:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DNbbBjZSa-9h; Mon, 6 Sep 2021 02:00:58 -0700 (PDT)
Received: from gabriel-smtp.zfn.uni-bremen.de (gabriel-smtp.zfn.uni-bremen.de [IPv6:2001:638:708:32::15]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8723A3A27BB; Mon, 6 Sep 2021 02:00:58 -0700 (PDT)
Received: from [192.168.217.118] (p548dcf6e.dip0.t-ipconnect.de [84.141.207.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4H32S55SWGz2xQd; Mon, 6 Sep 2021 11:00:53 +0200 (CEST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <8DC48816-852A-47D9-B533-37D9FB69E97A@ericsson.com>
Date: Mon, 6 Sep 2021 11:00:53 +0200
Cc: "draft-ietf-core-senml-data-ct.all@ietf.org" <draft-ietf-core-senml-data-ct.all@ietf.org>, "core@ietf.org" <core@ietf.org>
X-Mao-Original-Outgoing-Id: 652611653.25512-965265c644234126ad709bfa231480ef
Content-Transfer-Encoding: quoted-printable
Message-Id: <A79FF21A-2EFD-46DE-9CEF-1F895F44AB3B@tzi.org>
References: <8DC48816-852A-47D9-B533-37D9FB69E97A@ericsson.com>
To: Francesca Palombini <francesca.palombini=40ericsson.com@dmarc.ietf.org>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/9OsW3sCTgLyLSyjMe8O7ljwQstk>
Subject: Re: [core] AD review of draft-ietf-core-senml-data-ct-04
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Sep 2021 09:01:03 -0000

Hi Francesca,

thank you for this in-depth review.

> On 2021-08-23, at 22:07, Francesca Palombini <francesca.palombini=40ericsson.com@dmarc.ietf.org> wrote:
> 
> Thank you for the work on this document. Please take care of these minor comments at the same time as the Last Call comments.
> 
> Francesca
> 
> 1. -----
> 
> FP: First of all, I wanted to confirm with the WG that the status "proposed standard" is the appropriate one here. Just making sure this was considered by the working group and the authors, as I note that the standard track is not needed for the IANA registrations, which require only expert review.

This subject comes up so often that it is hard to remember whether we discussed it specifically for data-ct.
The document has started out as specifying standards track and it doesn’t look that ever changed, so I can’t find a specific event where we would have discussed this.
I also couldn’t find records of a discussion in the minutes of CoRE meetings of the last 2½ years or so (side note: I actually wrote a tool to mine the minutes as they are not arranged in a way that would aid that mining).

Generally, you are right that simply registering a couple of SenML labels does create the entries in the registry.  However, here the intention was to also standardize the information that goes in a field under those labels.  To make this document referenceable without causing the equivalent of a downref in an SDO that wants to depend on this field, it is best advanced as a standards-track document.

(I have said before that different treatment of the std vs. info distinction in different areas of the IETF is a leading cause for confusion, but this is probably not the document to fix this for.)

> 2. -----
> 
>  used to send various kinds of data.  In the example given in
>  Figure 1, a temperature value, an indication whether a lock is open,
>  and a data value (with SenML field "vd") read from an NFC reader is
>  sent in a single SenML pack.
> 
> 
> FP: Might be worth stating in the sentence above that the example uses JSON and base64 encoding.

Added:
+The example is given in SenML JSON representation, so the "vd" (data
+value) field is encoded as a base64url string (without
+padding), as per {{Section 5 of -senml}}.

Now in https://github.com/core-wg/senml-data-ct/commit/a3b0510 (with a few additional reference fixes).

> 3. -----
> 
> 
>  Media-Type-Name:  A combination of a type-name and a subtype-name
>     registered in [IANA.media-types] as per [RFC6838], conventionally
>     identified by the two names separated by a slash.
> 
> FP: RFC 6838 is an informative reference, I wonder if it wouldn't make more sense to bring it up to normative, given that type-name and subtype-name (and media types in general) need to be understood in this specification.

If all copies of RFC 6838 get deleted, the data-ct spec still makes sense.
The ABNF from 6838 is copied over, not referenced.
This is why this isn’t labeled as a normative reference, but there is no strong reason not to do that.

> 4. -----
> 
>  Content-Type:  A Media-Type-Name, optionally associated with
>     parameters (separated from the media type name and from each other
>     by a semicolon).  In HTTP and many other protocols, used in a
> 
> FP: Please add a reference to the RFC defining media types parameters.

That would be RFC 2045 (as far as the syntax is concerned — semantics is in RFC 2046).

Added a reference to RFC 2045 (amazingly, these RFCs don’t have a “references” section, so I don’t know whether RFC 2046 is a normative reference for 2045, but for all intents and purposes, it is):

-: A Media-Type-Name, optionally associated with parameters (separated from
+: A Media-Type-Name, optionally associated with parameters
+  ({{Section 5 of -mime1}}, separated from


RFC 6838 gives the syntax for parameter names as

      parameter-name = restricted-name

However, we opted to whole-sale copy the RFC 7231 syntax, which is a bit more permissive.

Now in https://github.com/core-wg/senml-data-ct/commit/20da9a8

> 5. ----
> 
>     "Content-Encoding"; we *never* use this term (except when we are
>     in error).
> 
> FP: It is not clear to me the goal of what stated in parenthesis.

Unfortunately, there are lots of RFCs that get this wrong (including our own Section 12.3 in RFC 7252…).
The parenthesis may be a bit terse to make this explicit.

Bron had some nice replacement text in his artart review, which turned into
https://github.com/core-wg/senml-data-ct/commit/90a3deb

> 6. -----
> 
> FP: There is a subtle difference between Content-Format and Content-Format-Spec, the latter being the "string representation" of the former. By reading the two definitions, it does feel like the same thing is specified twice, it might be worth moving the following to Content-Format-Spec:
> 
>      , identified by (1) a numeric identifier defined by the
>     "CoAP Content-Formats" subregistry of [IANA.core-parameters] as
>     per [RFC7252] or (2) a Content-Format-String.

I couldn’t quite make this work, as this then looks like Content-Format always is  represented as a pair — having the description as the alternative is best left in that definition.

> Also, Content-Format-Spec right now mentions "Content-Format number". If you don't do the change above, it might be worth adding the following clarification:
> 
> OLD:
>  Content-Format:  the combination of a Content-Type and a Content-
>     Coding, identified by (1) a numeric identifier defined by the
>     "CoAP Content-Formats" subregistry of [IANA.core-parameters] as
>     per [RFC7252] or (2) a Content-Format-String.
> NEW:
>  Content-Format:  the combination of a Content-Type and a Content-
>     Coding, identified by (1) a numeric identifier defined by the
>     "CoAP Content-Formats" subregistry of [IANA.core-parameters] as
>     per [RFC7252] (referred to as Content-Format number) or (2) a
>     Content-Format-String.
> 
> (Content-Format number is used also in section 3)

Added in https://github.com/core-wg/senml-data-ct/commit/6923d8c

> 7. -----
> 
> FP: I would have appreciated an example of use or the "bct" field in Section 4.

Added in https://github.com/core-wg/senml-data-ct/commit/e8181d6

[Ari: Can you cross-check this new example?]

> 8. -----
> 
> FP: I think an example using a Content-Format-String including a parameter could have been useful.

Added in https://github.com/core-wg/senml-data-ct/commit/78622c8

> 9. -----
> 
> FP: In Section 8, several columns for the registration of SenML labels are missing: CBOR label, exi ID.

As they should be:

RFC8428 12.2:  […] the
  CBOR labels SHOULD be left empty as CBOR will use the string encoding
  for any new labels. The EI column contains the EXI schemaId value of
  the first schema that includes this label, or it is empty if this
  label was not intended for use with EXI.

(Of course, we can discuss whether data-ct is “intended for use with EXI”.)

All the changes above, plus some related house-keeping, are in
https://github.com/core-wg/senml-data-ct/pull/5 — summary in https://github.com/core-wg/senml-data-ct/pull/5/files

Grüße, Carsten