Re: [core] Spencer Dawkins' No Objection on draft-ietf-core-block-19: (with COMMENT)

Carsten Bormann <cabo@tzi.org> Fri, 29 April 2016 19:06 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 115CC12D728; Fri, 29 Apr 2016 12:06:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.62
X-Spam-Level:
X-Spam-Status: No, score=-2.62 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T0oy3I4W8FBV; Fri, 29 Apr 2016 12:06:51 -0700 (PDT)
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E7E212D724; Fri, 29 Apr 2016 12:06:51 -0700 (PDT)
Received: from mfilter36-d.gandi.net (mfilter36-d.gandi.net [217.70.178.167]) by relay5-d.mail.gandi.net (Postfix) with ESMTP id D3B2B41C088; Fri, 29 Apr 2016 21:06:49 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at mfilter36-d.gandi.net
Received: from relay5-d.mail.gandi.net ([IPv6:::ffff:217.70.183.197]) by mfilter36-d.gandi.net (mfilter36-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id arRV_dgOqqLM; Fri, 29 Apr 2016 21:06:48 +0200 (CEST)
X-Originating-IP: 93.199.242.26
Received: from nar-3.local (p5DC7F21A.dip0.t-ipconnect.de [93.199.242.26]) (Authenticated sender: cabo@cabo.im) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 6869D41C07D; Fri, 29 Apr 2016 21:06:45 +0200 (CEST)
Message-ID: <5723B0C4.7020601@tzi.org>
Date: Fri, 29 Apr 2016 21:06:44 +0200
From: Carsten Bormann <cabo@tzi.org>
User-Agent: Postbox 4.0.8 (Macintosh/20151105)
MIME-Version: 1.0
To: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>
References: <20160418044805.28780.94432.idtracker@ietfa.amsl.com> <571864D3.2000906@tzi.org> <CAKKJt-eqHjJPp3_oVg7hcw5acVKvOnwzd-EbZEZmctDRu0WQ5Q@mail.gmail.com>
In-Reply-To: <CAKKJt-eqHjJPp3_oVg7hcw5acVKvOnwzd-EbZEZmctDRu0WQ5Q@mail.gmail.com>
X-Enigmail-Version: 1.2.3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/core/HrYwZblpJ98YyTu0W_6rkDAx3zc>
Cc: draft-ietf-core-block@ietf.org, core-chairs@ietf.org, The IESG <iesg@ietf.org>, "core@ietf.org" <core@ietf.org>
Subject: Re: [core] Spencer Dawkins' No Objection on draft-ietf-core-block-19: (with COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Apr 2016 19:06:54 -0000

Hi Spencer,

I think I have addressed your comments in draft-ietf-core-block-20

Diff: https://www.ietf.org/rfcdiff?url2=draft-ietf-core-block-20

Specifically:

> My problem was that I didn't understand from the text that the same
> method of pacing packets that contained complete requests was being used
> to pace packets that contained blocks. I think that I can derive what
> you're saying from the draft, but it wasn't clear to me.
> 
> I saw that in the thread of Mirja's Discuss, you suggested adding this
> point more explicitly. That would solve my issue here.

See the new text in the introduction.

>  
> 
>     > I'm reading this text,
>     >
>     >    In most cases, all blocks being transferred for a body (except for
>     >    the last one) will be of the same size.
>     >
>     > and then this text
>     >
>     >       *  The block size implied by SZX MUST match the size of the
>     >          payload in bytes, if the M bit is set.  (SZX does not govern
>     >          the payload size if M is unset).  For Block2, if the request
>     >          suggested a larger value of SZX, the next request MUST
>     move SZX
>     >          down to the size given in the response.  (The effect is that,
>     >          if the server uses the smaller of (1) its preferred block size
>     >          and (2) the block size requested, all blocks for a body
>     use the
>     >          same block size.)
>     >
>     > and realizing that I'm confused about why all the blocks for a body
>     might
>     > NOT use the same block size. Maybe this doesn't matter (because an
>     > implementation would need to be prepared for the case when all the
>     blocks
>     > don't use the same block size)?
> 
>     The first request may be using a block size that is larger than what the
>     server prefers.  That is one case where the block size changes during a
>     whole transfer.  See also Figure 4 for an example where the client
>     prefers a smaller block size than the server sent initially.
> 
>     So, yes, an implementation needs to be prepared for cases where at least
>     the initial block is of a different size than the following (full)
>     blocks.  I believe this is evident to the implementers at least from the
>     examples.
> 
> 
> That's very helpful. 
> 
> Would it be correct to say (in the first paragraph I included above)
> something like
> 
>     In most cases, all blocks being transferred for a body (except for
>     the last one) will be of the same size. If the first request uses a
> bigger
>     block size than the receiver prefers, subsequent requests will use
>     the preferred block size.
> 
> just so you're not relying on implementers to figure out what to
> implement solely from the examples?

Thanks for the text suggestion.  That text is now in the last paragraph
of the introduction to section 2.

Grüße, Carsten